Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'pre-buid' typo in build-android target #2281

Merged
merged 1 commit into from
Oct 19, 2018
Merged

Fix 'pre-buid' typo in build-android target #2281

merged 1 commit into from
Oct 19, 2018

Conversation

uusijani
Copy link

The build-android target calls the pre-build target as pre-buid, resulting in build failure for the build-android target. This PR fixes the issue.

(PR #2272 did the same for a typo in the build-pr target.)

enahum
enahum approved these changes Oct 19, 2018
View reviewed changes
Copy link
Contributor

@enahum enahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uusijani thank you very much, nice catch

@enahum enahum added the 4: Reviews Complete All reviewers have approved the pull request label Oct 19, 2018
@enahum enahum merged commit f65cf86 into mattermost:master Oct 19, 2018
@enahum enahum added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Oct 19, 2018
enahum pushed a commit that referenced this pull request Oct 19, 2018
@uusijani @enahum
Fix 'pre-buid' typo in build-android target (#2281)
2e4cdc8
@enahum enahum added the CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone label Oct 19, 2018
@uusijani uusijani deleted the buid_typo_fix branch October 19, 2018 12:11
@enahum enahum removed the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Feb 7, 2019
@lindy65 lindy65 added the Tests/Not Needed Does not require tests label Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enahum enahum enahum approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Tests/Not Needed Does not require tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uusijani @enahum @lindy65