Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM-21613 Fix iOS Share extension alert message when file size is larger than allowed #3792

Merged
merged 1 commit into from
Jan 10, 2020
Merged

MM-21613 Fix iOS Share extension alert message when file size is larger than allowed #3792

merged 1 commit into from
Jan 10, 2020

Conversation

enahum
Copy link
Contributor

@enahum enahum commented Jan 9, 2020

Summary

When removing the user session token from the entities file the config and license were also removed, this PR adds back the config and license needed by the share extension.

Also makes a bit more robust the parsing of the file_info of the uploaded files to avoid creating a complete empty post.

Ticket Link

https://mattermost.atlassian.net/browse/MM-21613

@enahum enahum added 2: Dev Review Requires review by a core commiter CherryPick/Approved Meant for the quality or patch release tracked in the milestone 3: QA Review Requires review by a QA tester labels Jan 9, 2020
@enahum enahum added this to the v1.27 milestone Jan 9, 2020
@enahum enahum changed the title Fix iOS Share extension alert message when file size is larger than allowed MM-21613 Fix iOS Share extension alert message when file size is larger than allowed Jan 9, 2020
@enahum
Copy link
Contributor Author

enahum commented Jan 9, 2020

Already triggered the build of the PR

chuttam
chuttam approved these changes Jan 9, 2020
View reviewed changes
Copy link

@chuttam chuttam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

@migbot migbot removed the 2: Dev Review Requires review by a core commiter label Jan 9, 2020
lindy65
lindy65 approved these changes Jan 10, 2020
View reviewed changes
Copy link

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @enahum - this is fixed and I see the error message when file size is larger than allowed 👍

@lindy65 lindy65 added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Jan 10, 2020
@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label Jan 10, 2020
@enahum enahum merged commit 1e42a87 into master Jan 10, 2020
@enahum enahum deleted the MM-21613 branch January 10, 2020 10:41
@mattermost-build mattermost-build mentioned this pull request Jan 10, 2020
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuttam chuttam chuttam approved these changes

@migbot migbot migbot approved these changes

@lindy65 lindy65 lindy65 approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone QA Review Done
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.
6 participants
@enahum @chuttam @migbot @lindy65 @mattermod @hanzei