MM-21892 Fix TypeError cause by mm-redux#1006 #3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enahum
added
2: Dev Review
chuttam
approved these changes
Jan 21, 2020
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "mattermost-mobile", | |||
| "version": "1.27.0", | |||
| "version": "1.27.1", | |||
There was a problem hiding this comment.
Glad that this diff is making its way to master via this commit too. I'd noticed it come up on current master.
How come it didn't make it as part of the version bump commit? Did I miss something in review?
There was a problem hiding this comment.
I don't think the fastlane script runs npm i after updating package.json so package-lock.json is never changed?
migbot
approved these changes
Jan 21, 2020
migbot
added
4: Reviews Complete
mattermod
added
CherryPick/Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR mattermost/mattermost-redux#1006 removed the
RequestStatusflagged that were being used in the SlashSuggestion component.We are not able to remove the flag to track if the request is still in progress as the component will not receive further prop updates.
Ticket Link
https://mattermost.atlassian.net/browse/MM-21892