-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-57267] Calls: Update post UI #7965
Conversation
@@ -363,7 +363,7 @@ export const canEndCall = async (serverUrl: string, channelId: string) => { | |||
return false; | |||
} | |||
|
|||
return isSystemAdmin(currentUser.roles) || currentUser.id === call.ownerId; | |||
return isSystemAdmin(currentUser.roles) || currentUser.id === call.hostId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, we've sent hostId since 2022-11.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, running this against a previous plugin would make it fail because the backend check would be on the owner ID. Not overly worried though.
width: 0, | ||
height: 2, | ||
}, | ||
shadowRadius: 3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the figma values for shadows aren't accurate. Maybe the react native values don't map properly or something.
I played around with the values and this seemed to get things closer between android and iOS and inline with the design.
shadowColor: 'rgba(0,0,0,0.32)',
shadowOffset: {
width: 0,
height: 1,
},
shadowOpacity: 0.24,
shadowRadius: 1,
elevation: 2,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, you're right, looks better. React native must do shadows a bit differently. Updated to 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks SO much better now. Thanks @cpoile!
Just the minor nit on the shadows that I noted in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@@ -363,7 +363,7 @@ export const canEndCall = async (serverUrl: string, channelId: string) => { | |||
return false; | |||
} | |||
|
|||
return isSystemAdmin(currentUser.roles) || currentUser.id === call.ownerId; | |||
return isSystemAdmin(currentUser.roles) || currentUser.id === call.hostId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, running this against a previous plugin would make it fail because the backend check would be on the owner ID. Not overly worried though.
* MM-58259 - allow current host to run /end call; fix deprecated test fns * update call card UI * update call ended icon * make joinCall async; adding loading spinner to join/start button * Revert "make joinCall async; adding loading spinner to join/start button" This reverts commit bbb1366. * shadowRadius 3 -> 1
Summary
Ticket Link
Checklist
Device Information
Release Note