Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-49370] Fix test error caused by missing arm64 docker manifest #332

Merged
merged 2 commits into from
Jan 8, 2023

Conversation

mirshahriar
Copy link
Contributor

@mirshahriar mirshahriar commented Jan 5, 2023

Summary

Presslabs does not provide arm64 docker image. To fix this, we need to use images for linux/x86_64 platofrm.

docker pull --platform=linux/x86_64 quay.io/presslabs/mysql-operator:0.4.0
kind load docker-image quay.io/presslabs/mysql-operator:0.4.0

But by default Presslabs MySQL Operator uses following image for mysql
percona@sha256:713c1817615b333b17d0fbd252b0ccc53c48a665d4cfcb42178167435a957322

Similarly, this version does not have arm64 variant. And we can't load exact version (of linux/x86_64) into kind.

Thats why, we need to tell mysql operator to use percona:5.7.26 instead of sha so that we can load linux/x86_64 of percona:5.7.26 into kind.

Passing following flag in operator to override version

--mysql-versions-to-image=5.7.26=percona:5.7.26

Ticket Link

Fixes MM-49370

Release Note

Fix test error caused by missing arm64 docker manifest

@mm-cloud-bot mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 5, 2023
@mirshahriar mirshahriar self-assigned this Jan 5, 2023
@mirshahriar mirshahriar added the 2: Dev Review Requires review by a developer label Jan 5, 2023
Copy link
Contributor

@fmartingr fmartingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I can’t try it myself right now but it seems that is fixes our current development issue. Thank you!

Copy link
Collaborator

@gabrieljackson gabrieljackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix! 👍

@mirshahriar mirshahriar merged commit fc440cf into master Jan 8, 2023
@mirshahriar mirshahriar deleted the MM-49370 branch January 8, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a developer release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants