fixed the test app #353

levb · 2022-08-15T17:45:12Z

appclient no longer requires a userID to work
DM[Post] errors out if the creator's user ID is not known, with a empty sender user_id, perhaps Call does not expand acting_user message. Note that the Bot user id is always expanded.
Fixed the test apps' subscription parameters

@DHaussermann I did not review every expand in the test app, but it does not use DM nor DMPost so should be OK.

Embedded does not appear to work, will debug it separately, perhaps @mickmister can help?

levb · 2022-08-15T17:46:52Z

apps/appclient/mattermost_client.go

 }

 func AsActingUser(cc apps.Context) *Client {
-	return as(cc.ActingUser.Id, cc.ActingUserAccessToken, cc)
+	client := as(cc.ActingUserAccessToken, cc)


Deferring the error handling for no user ID until DMPost

codecov-commenter · 2022-08-15T18:10:33Z

Codecov Report

Merging #353 (a49040e) into lev-example-expand-notify (60e221d) will not change coverage.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##           lev-example-expand-notify     #353   +/-   ##
==========================================================
  Coverage                      21.23%   21.23%           
==========================================================
  Files                             81       81           
  Lines                           5190     5190           
==========================================================
  Hits                            1102     1102           
  Misses                          3974     3974           
  Partials                         114      114

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mickmister · 2022-08-15T18:25:03Z

apps/appclient/mattermost_client.go

@@ -170,8 +175,6 @@ func (c *Client) Call(creq apps.CallRequest) (*apps.CallResponse, error) {
 }

 func (c *Client) CreatePost(post *model.Post) (*model.Post, error) {
-	post.UserId = c.userID


👍 I figured this wasn't required because it's going through the API with token

* wip * wip: goapp builds * more wip * wip * fixed examples README port ref * removed a couple accidental changes * wip - switching to a different task * use functional options for better readability of the app * a few fixes * notify command * tests pass * style + comments + minor * Eliminated Context.ActingUserID altogether * wip stash * wip /info works again, with IDs only * wip example-expand user action seems to work (happy) * Fixed expand level none parsing * moved/rewrote all REST API tests * goapp, and use it in REST API tests * Makefile adjustment * space * moved code around * Update apps/goapp/bindable.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * PR feedback * PR feedback: comment * PR feedback: remove ServiceNow reference * PR feedback: strings * PR feedback: experimental * fixed a test * remamed invoke_call.go back to call.go to see the diff better * make all works, moved a bunch of test stubs to restapitest * ci to use go 1.18.2 * up golangci-lint to 1.46.1 * Updated OAuth2 REST tests * add test for AppsMetadata returned by proxy * bindings test * passes rest test again * more generic bindings test * more bindings-related cleanup * wip * more bindings * finished bindings test * reenabled other tests * beginning of notify test * more refactoring * touches * more touches * notify tests * Update server/appservices/subscriptions.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * added test for SubjectUserLeftTeam * notify all subjects, happy, no expand * lint * removed scratchpad lines * PR feedback: typo * Update server/proxy/invoke_oauth2.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * Update server/proxy/service.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * test user_created with expand and all client combinations * attempted to add test-rest-api to coverage * Revert "attempted to add test-rest-api to coverage" This reverts commit fcbcb4e. * bot_joined_channel * lint * comments * bot_left_channel + refactoring * bot_joined/left_team * lint * go 1.18.3 * more ci go version * updated mmserver from 6.6 to current * more tests * fixed E2E docker image back to 6.6 * fixed E2E docker image back to 6.6 once more * lowered required server to 6.6 fot the E2E tests to pass * restructuring tests/precision * added bot_left_channel, more restructuring/fixes * style * saved a second off the test by using cached values for comparisons, where possible * All tests pass * type in cicrleci config * Update server/httpin/service.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * Update server/proxy/invoke_bindings.go Co-authored-by: Daniel Espino García <larkox@gmail.com> * Update server/proxy/invoke_bindings.go Co-authored-by: Daniel Espino García <larkox@gmail.com> * style * fixed static and added a test * comment * Uninstall cleans out subscriptions * removed old notfy tests * added uninstall test * Finished uninstall test * lint * i18n * PR feedback and fixes * PR feedback + TestRESTAPI/echo/email_expansion_is_controlled_by_server_settings * renamed call.go -> invoke_call.go for consistency * PR feedback: added comments * fixed tests * Examples: lifecycle, webhooks * Example: OAuth2 * serverless example + small fixes for static * fixed bindings test * wip * fixed the go.mod mess * PR feedback: comments and strins * set content-type json * fixed the test app (#353) * Update mattermost-server to 7.2, improve circle-ci caching (#354) * fixed the test app * Updated to server v7.2 * go mod tidy * try release 7.1 * try 1 * try 2 * try 3 * try 4 * try 5 * try 6 * fixed embedded binding in test app (appID) * test app update Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> Co-authored-by: Daniel Espino García <larkox@gmail.com>

* wip * wip: goapp builds * more wip * wip * fixed examples README port ref * removed a couple accidental changes * wip - switching to a different task * use functional options for better readability of the app * a few fixes * notify command * tests pass * style + comments + minor * Eliminated Context.ActingUserID altogether * wip stash * wip /info works again, with IDs only * wip example-expand user action seems to work (happy) * Fixed expand level none parsing * moved/rewrote all REST API tests * goapp, and use it in REST API tests * Makefile adjustment * space * moved code around * Update apps/goapp/bindable.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * PR feedback * PR feedback: comment * PR feedback: remove ServiceNow reference * PR feedback: strings * PR feedback: experimental * fixed a test * remamed invoke_call.go back to call.go to see the diff better * make all works, moved a bunch of test stubs to restapitest * ci to use go 1.18.2 * up golangci-lint to 1.46.1 * Updated OAuth2 REST tests * add test for AppsMetadata returned by proxy * bindings test * passes rest test again * more generic bindings test * more bindings-related cleanup * wip * more bindings * finished bindings test * reenabled other tests * beginning of notify test * more refactoring * touches * more touches * notify tests * Update server/appservices/subscriptions.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * added test for SubjectUserLeftTeam * notify all subjects, happy, no expand * lint * removed scratchpad lines * PR feedback: typo * Update server/proxy/invoke_oauth2.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * Update server/proxy/service.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * test user_created with expand and all client combinations * attempted to add test-rest-api to coverage * Revert "attempted to add test-rest-api to coverage" This reverts commit fcbcb4e. * bot_joined_channel * lint * comments * bot_left_channel + refactoring * bot_joined/left_team * lint * go 1.18.3 * more ci go version * updated mmserver from 6.6 to current * more tests * fixed E2E docker image back to 6.6 * fixed E2E docker image back to 6.6 once more * lowered required server to 6.6 fot the E2E tests to pass * restructuring tests/precision * added bot_left_channel, more restructuring/fixes * style * saved a second off the test by using cached values for comparisons, where possible * All tests pass * type in cicrleci config * Update server/httpin/service.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * Update server/proxy/invoke_bindings.go Co-authored-by: Daniel Espino García <larkox@gmail.com> * Update server/proxy/invoke_bindings.go Co-authored-by: Daniel Espino García <larkox@gmail.com> * style * fixed static and added a test * comment * Uninstall cleans out subscriptions * removed old notfy tests * added uninstall test * Finished uninstall test * lint * i18n * PR feedback and fixes * PR feedback + TestRESTAPI/echo/email_expansion_is_controlled_by_server_settings * renamed call.go -> invoke_call.go for consistency * PR feedback: added comments * fixed tests * Examples: lifecycle, webhooks * Example: OAuth2 * serverless example + small fixes for static * fixed bindings test * wip * fixed the go.mod mess * PR feedback: comments and strins * set content-type json * fixed the test app (#353) * Update mattermost-server to 7.2, improve circle-ci caching (#354) * fixed the test app * Updated to server v7.2 * go mod tidy * try release 7.1 * try 1 * try 2 * try 3 * try 4 * try 5 * try 6 * kv goapp example * Added a REST API test for KV prefixes * touches on kv example Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> Co-authored-by: Daniel Espino García <larkox@gmail.com>

fixed the test app

a49040e

levb added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Aug 15, 2022

levb requested review from mickmister, DHaussermann and catalintomai August 15, 2022 17:45

levb commented Aug 15, 2022

View reviewed changes

mickmister approved these changes Aug 15, 2022

View reviewed changes

catalintomai approved these changes Aug 16, 2022

View reviewed changes

levb removed the 2: Dev Review Requires review by a core committer label Aug 16, 2022

levb merged commit 49ab502 into lev-example-expand-notify Aug 16, 2022

levb deleted the lev-fix-test-app branch August 16, 2022 14:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixed the test app #353

fixed the test app #353

levb commented Aug 15, 2022

levb Aug 15, 2022

codecov-commenter commented Aug 15, 2022

mickmister Aug 15, 2022

fixed the test app #353

fixed the test app #353

Conversation

levb commented Aug 15, 2022

levb Aug 15, 2022

Choose a reason for hiding this comment

codecov-commenter commented Aug 15, 2022

Codecov Report

mickmister Aug 15, 2022

Choose a reason for hiding this comment