Update mattermost-server to 7.2, improve circle-ci caching #354

levb · 2022-08-16T22:21:40Z

Updated the server dependency to v7.2
improved caching and build performance in circleci

codecov-commenter · 2022-08-17T16:02:39Z

Codecov Report

Merging #354 (ac6ae2e) into lev-example-expand-notify (49ab502) will not change coverage.
The diff coverage is n/a.

❗ Current head ac6ae2e differs from pull request most recent head 9caf384. Consider uploading reports for the commit 9caf384 to get more accurate results

@@                    Coverage Diff                     @@
##           lev-example-expand-notify     #354   +/-   ##
==========================================================
  Coverage                      21.23%   21.23%           
==========================================================
  Files                             81       81           
  Lines                           5190     5190           
==========================================================
  Hits                            1102     1102           
  Misses                          3974     3974           
  Partials                         114      114

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

…termost-plugin-apps into lev-update-to-7-2

mickmister · 2022-08-18T18:32:13Z

.circleci/config.yml

+    save_cache:
+      key: go-mod-v4-{{ checksum "go.sum" }}
+      paths:
+        - "~/go/pkg/mod"


Maybe use $GOPATH instead?

The env variables do not appear to work ubiquitously, this seems an easy (and idiomatic?) reference in the cimg world.

mickmister · 2022-08-18T19:18:36Z

.circleci/config.yml

@@ -39,79 +39,35 @@ commands:
      - aws-s3/copy:
          from: << parameters.filename >>
          to: << parameters.bucket >>
-          arguments: '--acl public-read --cache-control no-cache'
-
-  install-golangci-lint:


Why is this no longer necessary?

Because golangci is already installed? Or did I miss the point of that step?

levb · 2022-08-22T17:16:09Z

.circleci/config.yml

+      paths:
+        - "~/go/pkg/mod"
+  - &restore_cypress_cache
+    restore_cache:


@mickmister this is not working, see attached,

appears that package-lock.json is changed by the build, so the cache is saved for a different sha.

We should fix this - at the very least because we are continuously generating large caches, 0/5 we generate in master, refer to the cache by the commited package-lock.json sha

* wip * wip: goapp builds * more wip * wip * fixed examples README port ref * removed a couple accidental changes * wip - switching to a different task * use functional options for better readability of the app * a few fixes * notify command * tests pass * style + comments + minor * Eliminated Context.ActingUserID altogether * wip stash * wip /info works again, with IDs only * wip example-expand user action seems to work (happy) * Fixed expand level none parsing * moved/rewrote all REST API tests * goapp, and use it in REST API tests * Makefile adjustment * space * moved code around * Update apps/goapp/bindable.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * PR feedback * PR feedback: comment * PR feedback: remove ServiceNow reference * PR feedback: strings * PR feedback: experimental * fixed a test * remamed invoke_call.go back to call.go to see the diff better * make all works, moved a bunch of test stubs to restapitest * ci to use go 1.18.2 * up golangci-lint to 1.46.1 * Updated OAuth2 REST tests * add test for AppsMetadata returned by proxy * bindings test * passes rest test again * more generic bindings test * more bindings-related cleanup * wip * more bindings * finished bindings test * reenabled other tests * beginning of notify test * more refactoring * touches * more touches * notify tests * Update server/appservices/subscriptions.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * added test for SubjectUserLeftTeam * notify all subjects, happy, no expand * lint * removed scratchpad lines * PR feedback: typo * Update server/proxy/invoke_oauth2.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * Update server/proxy/service.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * test user_created with expand and all client combinations * attempted to add test-rest-api to coverage * Revert "attempted to add test-rest-api to coverage" This reverts commit fcbcb4e. * bot_joined_channel * lint * comments * bot_left_channel + refactoring * bot_joined/left_team * lint * go 1.18.3 * more ci go version * updated mmserver from 6.6 to current * more tests * fixed E2E docker image back to 6.6 * fixed E2E docker image back to 6.6 once more * lowered required server to 6.6 fot the E2E tests to pass * restructuring tests/precision * added bot_left_channel, more restructuring/fixes * style * saved a second off the test by using cached values for comparisons, where possible * All tests pass * type in cicrleci config * Update server/httpin/service.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * Update server/proxy/invoke_bindings.go Co-authored-by: Daniel Espino García <larkox@gmail.com> * Update server/proxy/invoke_bindings.go Co-authored-by: Daniel Espino García <larkox@gmail.com> * style * fixed static and added a test * comment * Uninstall cleans out subscriptions * removed old notfy tests * added uninstall test * Finished uninstall test * lint * i18n * PR feedback and fixes * PR feedback + TestRESTAPI/echo/email_expansion_is_controlled_by_server_settings * renamed call.go -> invoke_call.go for consistency * PR feedback: added comments * fixed tests * Examples: lifecycle, webhooks * Example: OAuth2 * serverless example + small fixes for static * fixed bindings test * wip * fixed the go.mod mess * PR feedback: comments and strins * set content-type json * fixed the test app (#353) * Update mattermost-server to 7.2, improve circle-ci caching (#354) * fixed the test app * Updated to server v7.2 * go mod tidy * try release 7.1 * try 1 * try 2 * try 3 * try 4 * try 5 * try 6 * fixed embedded binding in test app (appID) * test app update Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> Co-authored-by: Daniel Espino García <larkox@gmail.com>

* wip * wip: goapp builds * more wip * wip * fixed examples README port ref * removed a couple accidental changes * wip - switching to a different task * use functional options for better readability of the app * a few fixes * notify command * tests pass * style + comments + minor * Eliminated Context.ActingUserID altogether * wip stash * wip /info works again, with IDs only * wip example-expand user action seems to work (happy) * Fixed expand level none parsing * moved/rewrote all REST API tests * goapp, and use it in REST API tests * Makefile adjustment * space * moved code around * Update apps/goapp/bindable.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * PR feedback * PR feedback: comment * PR feedback: remove ServiceNow reference * PR feedback: strings * PR feedback: experimental * fixed a test * remamed invoke_call.go back to call.go to see the diff better * make all works, moved a bunch of test stubs to restapitest * ci to use go 1.18.2 * up golangci-lint to 1.46.1 * Updated OAuth2 REST tests * add test for AppsMetadata returned by proxy * bindings test * passes rest test again * more generic bindings test * more bindings-related cleanup * wip * more bindings * finished bindings test * reenabled other tests * beginning of notify test * more refactoring * touches * more touches * notify tests * Update server/appservices/subscriptions.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * added test for SubjectUserLeftTeam * notify all subjects, happy, no expand * lint * removed scratchpad lines * PR feedback: typo * Update server/proxy/invoke_oauth2.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * Update server/proxy/service.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * test user_created with expand and all client combinations * attempted to add test-rest-api to coverage * Revert "attempted to add test-rest-api to coverage" This reverts commit fcbcb4e. * bot_joined_channel * lint * comments * bot_left_channel + refactoring * bot_joined/left_team * lint * go 1.18.3 * more ci go version * updated mmserver from 6.6 to current * more tests * fixed E2E docker image back to 6.6 * fixed E2E docker image back to 6.6 once more * lowered required server to 6.6 fot the E2E tests to pass * restructuring tests/precision * added bot_left_channel, more restructuring/fixes * style * saved a second off the test by using cached values for comparisons, where possible * All tests pass * type in cicrleci config * Update server/httpin/service.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * Update server/proxy/invoke_bindings.go Co-authored-by: Daniel Espino García <larkox@gmail.com> * Update server/proxy/invoke_bindings.go Co-authored-by: Daniel Espino García <larkox@gmail.com> * style * fixed static and added a test * comment * Uninstall cleans out subscriptions * removed old notfy tests * added uninstall test * Finished uninstall test * lint * i18n * PR feedback and fixes * PR feedback + TestRESTAPI/echo/email_expansion_is_controlled_by_server_settings * renamed call.go -> invoke_call.go for consistency * PR feedback: added comments * fixed tests * Examples: lifecycle, webhooks * Example: OAuth2 * serverless example + small fixes for static * fixed bindings test * wip * fixed the go.mod mess * PR feedback: comments and strins * set content-type json * fixed the test app (#353) * Update mattermost-server to 7.2, improve circle-ci caching (#354) * fixed the test app * Updated to server v7.2 * go mod tidy * try release 7.1 * try 1 * try 2 * try 3 * try 4 * try 5 * try 6 * kv goapp example * Added a REST API test for KV prefixes * touches on kv example Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> Co-authored-by: Daniel Espino García <larkox@gmail.com>

Lev Brouk added 4 commits August 15, 2022 10:39

fixed the test app

a49040e

Updated to server v7.2

838b004

go mod tidy

23c0cac

try release 7.1

cda3058

levb changed the base branch from master to lev-example-expand-notify August 16, 2022 22:23

try 1

027b11c

levb force-pushed the lev-update-to-7-2 branch from 7023abb to 027b11c Compare August 16, 2022 23:36

Lev Brouk added 5 commits August 16, 2022 17:00

try 2

e9698b4

try 3

3672fb1

try 4

63b9013

try 5

d41ea00

try 6

ac6ae2e

Merge branch 'lev-example-expand-notify' of github.com:mattermost/mat…

9caf384

…termost-plugin-apps into lev-update-to-7-2

levb changed the title ~~update mattermost-server to 7.2~~ Update mattermost-server to 7.2, improve circle-ci caching Aug 17, 2022

levb requested review from mickmister and catalintomai August 17, 2022 16:07

levb added the 2: Dev Review Requires review by a core committer label Aug 17, 2022

levb marked this pull request as ready for review August 17, 2022 16:08

mickmister approved these changes Aug 18, 2022

View reviewed changes

catalintomai approved these changes Aug 22, 2022

View reviewed changes

levb commented Aug 22, 2022

View reviewed changes

levb added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Aug 22, 2022

levb merged commit 8d98116 into lev-example-expand-notify Aug 22, 2022

levb deleted the lev-update-to-7-2 branch August 22, 2022 17:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update mattermost-server to 7.2, improve circle-ci caching #354

Update mattermost-server to 7.2, improve circle-ci caching #354

levb commented Aug 16, 2022 •

edited

codecov-commenter commented Aug 17, 2022 •

edited

mickmister Aug 18, 2022

levb Aug 20, 2022

mickmister Aug 18, 2022

levb Aug 20, 2022

levb Aug 22, 2022

Update mattermost-server to 7.2, improve circle-ci caching #354

Update mattermost-server to 7.2, improve circle-ci caching #354

Conversation

levb commented Aug 16, 2022 • edited

codecov-commenter commented Aug 17, 2022 • edited

Codecov Report

mickmister Aug 18, 2022

Choose a reason for hiding this comment

levb Aug 20, 2022

Choose a reason for hiding this comment

mickmister Aug 18, 2022

Choose a reason for hiding this comment

levb Aug 20, 2022

Choose a reason for hiding this comment

levb Aug 22, 2022

Choose a reason for hiding this comment

levb commented Aug 16, 2022 •

edited

codecov-commenter commented Aug 17, 2022 •

edited