count dispatches #3
Conversation
Keep track of when the plugin started and the number of dispatches that have occurred since that time. Include these stats, the current time, and the computed number of dispatches per second in the stats emitted by `window.logStoreStatistics`.
| @@ -7,16 +7,25 @@ import manifest from './manifest'; | |||
| // eslint-disable-next-line import/no-unresolved | |||
| import {PluginRegistry} from './types/mattermost-webapp'; | |||
|
|
|||
| const globalStats = { | |||
| Start: Date.now(), | |||
| NumDispatches: 0, | |||
There was a problem hiding this comment.
This is very coarse -- a better solution might be to track in buckets of time, so we can correlate perceived performance with the number of dispatches observed near that unit of time. But this might be good enough as a baseline.
There was a problem hiding this comment.
We could also add something to count which actions were dispatched the most too
|
Might want to bump the plugin version actually |
|
Oh, right! I'm used to the incident collaboration workflow, which no longer requires managing |
webapp/src/index.tsx
Outdated
| export default class Plugin { | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars, @typescript-eslint/no-empty-function | ||
| public async initialize(registry: PluginRegistry, store: Store<GlobalState, Action<Record<string, unknown>>>) { | ||
| window.webappDebugStore = store; | ||
| store.subscribe(() => { |
There was a problem hiding this comment.
Should we unsubscribe in case we update the plugin afterwards? I don't know how much we care about leaking these subscriptions
There was a problem hiding this comment.
Yep, I can add that -- though deinitialize isn't "reliable". It works if you explicitly disable a plugin, but not if you just upload a replacement. I don't think the leak here will matter (compared to the issue being debugged at present!), but we could always give explicit instructions.
hmhealey
added
the
4: Reviews Complete
Summary
Keep track of when the plugin started and the number of dispatches that have occurred since that time. Include these stats, the current time, and the computed number of dispatches per second in the stats emitted by
window.logStoreStatistics.