Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue 150] Cross-plugin task: Enable the CircleCI "test" job in each plugin repo that has a webapp plugin #151

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

sibasankarnayak
Copy link
Contributor

Configured `plugin-ci/test' for demo plugin

Ticket here
Fixes #150

@mattermod
Copy link
Contributor

The file .circleci/config.yml is in the blocklist for external contributors. Hence, these changes are not tested by the CI pipeline active until the build is re-triggered by a core committer or the PR is merged. Please be careful when reviewing it.
/cc @mattermost/core-security @mattermost/core-build-engineers

@mattermod
Copy link
Contributor

Hello @sibasankarnayak,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@hanzei hanzei requested a review from jfrerich October 26, 2021 18:26
@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Oct 26, 2021
@hanzei hanzei added this to the v0.10.0 milestone Oct 26, 2021
@jfrerich jfrerich removed the 2: Dev Review Requires review by a core committer label Oct 27, 2021
@jfrerich
Copy link
Contributor

@hanzei, are you ok with merging these after the two Dev Reviews?

@jfrerich jfrerich added the 4: Reviews Complete All reviewers have approved the pull request label Oct 27, 2021
@jfrerich jfrerich merged commit 4bb6264 into mattermost:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross-plugin task: Enable the CircleCI "test" job in each plugin repo that has a webapp plugin
4 participants