Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM-21683: expand boolean defaults for testing #83

Merged
merged 2 commits into from Jan 23, 2020
Merged

MM-21683: expand boolean defaults for testing #83

merged 2 commits into from Jan 23, 2020

Conversation

lieut-data
Copy link
Member

Summary

Add new boolean interactive dialog elements to test the various defaults.

Ticket Link

Relates-to: MM-21683

@lieut-data
MM-21683: expand boolean defaults for testing
bc6f2a0 
Add new boolean interactive dialog elements to test the various defaults.

Relates-to: MM-21683
@lieut-data lieut-data added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jan 13, 2020
@lieut-data lieut-data mentioned this pull request Jan 13, 2020
Merged
@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Jan 14, 2020
@hanzei hanzei requested a review from prapti January 14, 2020 10:33
@hanzei hanzei added this to the v0.5.0 milestone Jan 14, 2020
prapti
prapti suggested changes Jan 21, 2020
View reviewed changes
Copy link

@prapti prapti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting change to the help text for boolean selectors from "Pick a choice" to something that reflects that selecting the option is mandatory ("Choice required"?)

@lieut-data
Copy link
Member Author

Good call, @prapti! What do you think of this instead?
image

prapti
prapti approved these changes Jan 23, 2020
View reviewed changes
Copy link

@prapti prapti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣 Very precise. Thank you @lieut-data!

@prapti prapti added QA Review Done PR has been approved by QA 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jan 23, 2020
@lieut-data lieut-data merged commit 003d122 into master Jan 23, 2020
@lieut-data lieut-data deleted the mm-21683-improved-boolean-default-testing branch January 23, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prapti prapti prapti approved these changes

@migbot migbot migbot approved these changes

@hanzei hanzei hanzei approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request QA Review Done PR has been approved by QA
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lieut-data @prapti @migbot @hanzei