Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a way to shrink notification bodies per-subscription #470

Closed
mickmister opened this issue Aug 17, 2021 · 1 comment · Fixed by #534
Closed

Provide a way to shrink notification bodies per-subscription #470

mickmister opened this issue Aug 17, 2021 · 1 comment · Fixed by #534
Labels
1: PM Review Requires review by a product manager

Comments

@mickmister
Copy link
Member

Currently "issue created" events cause the whole PR body to show in the resulting notification in Mattermost. Most other (I believe all other) events have a much slimmer display, removing the body of the issue/PR.

The idea here is to allow subscriptions to be configurable so the user can adjust if the issue/PR body should be shown or not. See the linked Mattermost thread below for more details.

cc @aaronrothschild

Issue created from a Mattermost message by @mickmister.
@mickmister mickmister added the 1: PM Review Requires review by a product manager label Aug 17, 2021
@mickmister
Copy link
Member Author

Here's an example of two different kinds of notifications side-by-side

image

ijansky added a commit to ijansky/mattermost-plugin-github that referenced this issue Feb 9, 2022
@ijansky
[mattermostGH-470] Add a flag to enable brief, title-only notifications
79c5d58
TeodorPt added a commit to ijansky/mattermost-plugin-github that referenced this issue Feb 11, 2022
@TeodorPt
[mattermostGH-470] Pass config to template rendering together with event
ac5d99f
TeodorPt added a commit to ijansky/mattermost-plugin-github that referenced this issue Feb 11, 2022
@TeodorPt
[mattermostGH-470] Pass config to template rendering together with event
9e2d257
ijansky added a commit to ijansky/mattermost-plugin-github that referenced this issue Feb 16, 2022
@ijansky
[mattermostGH-470] Add a flag to enable brief, title-only notifications
fd0b32b
ijansky pushed a commit to ijansky/mattermost-plugin-github that referenced this issue Feb 16, 2022
@TeodorPt @ijansky
[mattermostGH-470] Pass config to template rendering together with event
18794d8
ijansky pushed a commit to ijansky/mattermost-plugin-github that referenced this issue Feb 16, 2022
@TeodorPt @ijansky
[mattermostGH-470] Pass config to template rendering together with event
a18553f
@ijansky ijansky mentioned this issue Feb 16, 2022
Merged
TeodorPt added a commit to ijansky/mattermost-plugin-github that referenced this issue Feb 17, 2022
@TeodorPt
[mattermostGH-470] Pass config to template rendering together with event
00f7389
TeodorPt added a commit to ijansky/mattermost-plugin-github that referenced this issue Feb 17, 2022
@TeodorPt
[mattermostGH-470] Pass config to template rendering together with event
ca92c97
TeodorPt added a commit to ijansky/mattermost-plugin-github that referenced this issue Feb 17, 2022
@TeodorPt
[mattermostGH-470] Pass config to template rendering together with event
6c88096
ijansky added a commit to ijansky/mattermost-plugin-github that referenced this issue Feb 17, 2022
@ijansky
[mattermostGH-470] Add a flag to enable brief, title-only notifications
cff06d8
ijansky pushed a commit to ijansky/mattermost-plugin-github that referenced this issue Feb 17, 2022
@TeodorPt @ijansky
[mattermostGH-470] Pass config to template rendering together with event
8cbf330
@mickmister mickmister mentioned this issue Mar 2, 2022
Closed
TeodorPt pushed a commit to ijansky/mattermost-plugin-github that referenced this issue Apr 1, 2022
@ijansky @TeodorPt
[mattermostGH-470] Add a flag to enable brief, title-only notifications
00bed67
TeodorPt added a commit to ijansky/mattermost-plugin-github that referenced this issue Apr 1, 2022
@TeodorPt
[mattermostGH-470] Pass config to template rendering together with event
ebddf34
TeodorPt added a commit to ijansky/mattermost-plugin-github that referenced this issue Apr 1, 2022
@TeodorPt
[mattermostGH-470] Make flags more configurable and change tite-only …
8334bc6 
…to render-style
TeodorPt added a commit to ijansky/mattermost-plugin-github that referenced this issue Apr 1, 2022
@TeodorPt
[mattermostGH-470] Add tests for render-style
2f437b5
TeodorPt added a commit to ijansky/mattermost-plugin-github that referenced this issue Apr 1, 2022
@TeodorPt
[mattermostGH-470] Add tests for render-style
c82a29a
TeodorPt added a commit to ijansky/mattermost-plugin-github that referenced this issue Apr 1, 2022
@TeodorPt
[mattermostGH-470] Add tests for render-style
f5f20e3
TeodorPt added a commit to ijansky/mattermost-plugin-github that referenced this issue Apr 1, 2022
@TeodorPt
[mattermostGH-470] Add tests for render-style
00dd0ac
TeodorPt added a commit to ijansky/mattermost-plugin-github that referenced this issue Apr 1, 2022
@TeodorPt
[mattermostGH-470] Add tests for render-style
a0899b1
TeodorPt added a commit to ijansky/mattermost-plugin-github that referenced this issue Apr 1, 2022
@TeodorPt
[mattermostGH-470] Add tests for render-style
fea4888
TeodorPt pushed a commit to ijansky/mattermost-plugin-github that referenced this issue Apr 8, 2022
@ijansky @TeodorPt
[mattermostGH-470] Add a flag to enable brief, title-only notifications
ff5b4ac
TeodorPt added a commit to ijansky/mattermost-plugin-github that referenced this issue Apr 8, 2022
@TeodorPt
[mattermostGH-470] Pass config to template rendering together with event
3bb4708
TeodorPt added a commit to ijansky/mattermost-plugin-github that referenced this issue Apr 8, 2022
@TeodorPt
[mattermostGH-470] Make flags more configurable and change tite-only …
7ca3cde 
…to render-style
TeodorPt added a commit to ijansky/mattermost-plugin-github that referenced this issue Apr 8, 2022
@TeodorPt
[mattermostGH-470] Add tests for render-style
bb9c024
mickmister added a commit that referenced this issue Aug 22, 2022
@ijansky @TeodorPt
@mickmister @mattermod
[GH-470] allow users to specify notifications verbosity using a new r…
4043d0b 
…ender-style flag (#534)

* [GH-470] Add a flag to enable brief, title-only notifications

* [GH-470] Pass config to template rendering together with event

* [GH-470] Make flags more configurable and change tite-only to render-style

* [GH-470] Add tests for render-style

* Address comments for PR 534

* Turn features into a flag argument for subscription add input

* Update flag const names and documentation

* add --verbose flag to npm install

Co-authored-by: Teodor Petrican <teodor.petrican@gmail.com>
Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
@avas27JTG avas27JTG mentioned this issue Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1: PM Review Requires review by a product manager
Projects
None yet
Milestone
No milestone
1 participant
@mickmister