Bump version to 2.2.0.

[avas27JTG]

Summary

• Provide a way to shrink notification bodies per-subscription #470
• Change OAuth complete timeout to 2 minutes #606
• Log non actionable errors on WARN level #628
• Add build info #598
• Feature: Synchronize emoji reactions on posts generated by the plugin #500
• mm-241 - adds aria labels to right hand side elements  #462
• Duplicate bot DM is being created when a user is mentioned on a PR assigned to the user #558
• [MM-51245] Handle relative paths in permalinks #656
• GitHub Create and Attach does not show results when org lock is set to a user's workspace #548
• [MM-50985] Remove usage of model.AppError #648
• [MM-52397] Move client package into root directory #671
• [MM-42918] Add debug information for setup wizard #679
• API rate limit exceeded for user ID #613
• Update flows.go #690
• Pull Request Reviews are not posted. #686
• Update go version to 1.21 #700
• [GH-418]: Fixed issue #418 'Added --exclude option to subscriptions command'. #683
• [GH-512,513] Fixed issue #512 and #513 on github plugin 'Updated subscription success messages' #661
• [GH-378]:Fixed issue #378 'Check for webhook while subscribing' #664
• [GH-693] Fix improper rendering of some unreads in the response of "/github todo" command #699
• [GH-593] Add feature flag for new pull requests #712
• [GH-717] Implement subscription notification for pull request "reopened" event #718
• [GH-719] Pushed commits events: add option to show Author instead of committer #729
• [MM-166] Fix issue: decription not visible in tooltip and removed "see more" link #735

[hanzei]

Can we get the open PRs that only require QA review into this release?

• [GH-418]: Fixed issue #418 'Added --exclude option to subscriptions command'. #683
• [GH-512,513] Fixed issue #512 and #513 on github plugin 'Updated subscription success messages' #661
• [GH-378]:Fixed issue #378 'Check for webhook while subscribing' #664
• [GH-693] Fix improper rendering of some unreads in the response of "/github todo" command #699

[avas27JTG]

Can we get the open PRs that only require QA review into this release?

• [GH-418]: Fixed issue #418 'Added --exclude option to subscriptions command'. #683
• [GH-512,513] Fixed issue #512 and #513 on github plugin 'Updated subscription success messages' #661
• [GH-378]:Fixed issue #378 'Check for webhook while subscribing' #664
• [GH-693] Fix improper rendering of some unreads in the response of "/github todo" command #699

Sure, let me look

[avas27JTG]

Can we get the open PRs that only require QA review into this release?

• [GH-418]: Fixed issue #418 'Added --exclude option to subscriptions command'. #683
• [GH-512,513] Fixed issue #512 and #513 on github plugin 'Updated subscription success messages' #661
• [GH-378]:Fixed issue #378 'Check for webhook while subscribing' #664
• [GH-693] Fix improper rendering of some unreads in the response of "/github todo" command #699

Sure, let me look

@hanzei I added them to this release milestone, and the QA will start testing these issues, after which we can merge them into the master.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7da125a) 15.85% compared to head (ff05dfc) 15.85%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #709   +/-   ##
=======================================
  Coverage   15.85%   15.85%           
=======================================
  Files          15       15           
  Lines        5778     5778           
=======================================
  Hits          916      916           
  Misses       4820     4820           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AayushChaudhary0001]

Tested and approved
All the changes merged are working fine, LGTM.

[avas27JTG]

Can we get the open PRs that only require QA review into this release?

• [GH-418]: Fixed issue #418 'Added --exclude option to subscriptions command'. #683
• [GH-512,513] Fixed issue #512 and #513 on github plugin 'Updated subscription success messages' #661
• [GH-378]:Fixed issue #378 'Check for webhook while subscribing' #664
• [GH-693] Fix improper rendering of some unreads in the response of "/github todo" command #699

Sure, let me look

@hanzei I added them to this release milestone, and the QA will start testing these issues, after which we can merge them into the master.

@hanzei can you please approve the PR if it looks good to you?

[avas27JTG]

@mickmister min_server_version is changed to 7.1.0 in this PR #598 so, should we still keep this release as v2.2.0 or change it to v3.0.0?.

[mickmister]

@avas27JTG I'm genuinely not sure if bumping the min server version constitutes a new major version of the plugin. We haven't done that in the past.

I'm thinking no, because the main reason we do major version changes is so that the admin is aware of breaking changes. In this case, the only side effect is they just won't be able to upgrade if they are on an older server version. There's not really a breaking change in that regard.

[avas27JTG]

@avas27JTG I'm genuinely not sure if bumping the min server version constitutes a new major version of the plugin. We haven't done that in the past.

I'm thinking no, because the main reason we do major version changes is so that the admin is aware of breaking changes. In this case, the only side effect is they just won't be able to upgrade if they are on an older server version. There's not really a breaking change in that regard.

Makes sense, thanks @mickmister we will keep it as a minor release.

[hanzei]

I would like (1/5) to get #712 into the release, but I'm fine with releasing the code as it is.

[avas27JTG]

I would like (1/5) to get #712 into the release, but I'm fine with releasing the code as it is.

Yes, we have planned to include it here, this is in QA review currently.

[mickmister]

I think we should also try to get #718 into the release. Very small impactful PR

[avas27JTG]

@mickmister @hanzei #712 and #718 are now included.

[hanzei]

@avas27JTG @AayushChaudhary0001 Are we good to merge the PR and cut the release?

[mickmister]

@hanzei I created an RC build and requested to be installed on community https://community.mattermost.com/core/pl/zd4h5ifbtjngbmi8d87we3x5wa

[avas27JTG]

@avas27JTG @AayushChaudhary0001 Are we good to merge the PR and cut the release?

Yes @hanzei we have created a playbook for it as per our release process and RC is also created by @mickmister

[mickmister]

@avas27JTG @raghavaggarwal2308 Are there any recent changes to the master branch that we don't want to include in this release? Wondering if we can get this in there #729. Let me know, and I'll cut another RC with the latest changes

[raghavaggarwal2308]

Are there any recent changes to the master branch that we don't want to include in this release?

@mickmister No I think we can cut the RC with latest changes. We have just merged the changes for description issue and see more link in the tooltip after our last RC (#735).

[mickmister]

@raghavaggarwal2308 Can you please merge the latest into this branch to get #729 into the release?

[raghavaggarwal2308]

@mickmister The branch and PR description is updated now
cc: @avas27JTG

[hanzei]

@mickmister Are we good to cut the release? Is there anything blocking it?

[mickmister]

@hanzei Yes I think we're good to go. We've had 36e72f4 running on community for a bit now, and only a few changes/fixes have been added since then.