Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Synchronize emoji reactions on posts generated by the plugin #500

Closed
mickmister opened this issue Oct 13, 2021 · 2 comments · Fixed by #632
Closed

Feature: Synchronize emoji reactions on posts generated by the plugin #500

mickmister opened this issue Oct 13, 2021 · 2 comments · Fixed by #632
Labels
Difficulty/2:Medium Medium ticket Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature

Comments

@mickmister
Copy link
Member

mickmister commented Oct 13, 2021

When the GitHub bot creates a post, it's always related to some specific issue/PR or comment. If a user reacts to the post in Mattermost with one of the 8 emojis supported for reactions on GitHub, the plugin should proxy this reaction to the appropriate PR/comment on GitHub. Likewise, if the user removes their emoji reaction in Mattermost, we should remove it in GitHub.

We don't need to perform synchronization from GitHub to Mattermost. If someone reacts to a PR/comment on GitHub, the plugin doesn't need to propagate that reaction to the associated post(s).

Going forward, we should store the (issue/PR or comment) URL in the post.props field for all posts made by the bot. This way, we can deterministically figure out which PR or comment is associated with this post.

@mickmister mickmister added Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers Hacktoberfest Tech/Go Difficulty/2:Medium Medium ticket Type/Enhancement New feature or improvement of existing feature labels Oct 13, 2021
@mickmister
Copy link
Member Author

Note that there is progress on this ticket in an abandoned PR LokeshN#1

Kshitij-Katiyar added a commit to Brightscout/mattermost-plugin-github that referenced this issue Jan 13, 2023
Kshitij-Katiyar added a commit to Brightscout/mattermost-plugin-github that referenced this issue Jan 17, 2023
…#17)

* test

* Feat for adding reactions to comments

* Fix checkstyle

* revert readme

* revert

* [MI-2597]:Fixed github issue mattermost#500 for emoji synchronisation

* [MI-2597]:Fixed review comments

* [MI-2597]:Fixed review comments

* [MI-2597]:Fixed review comments

Co-authored-by: LokeshN <nlokesh.17@gmail.com>
Kshitij-Katiyar added a commit to Brightscout/mattermost-plugin-github that referenced this issue Jan 31, 2023
@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Feb 2, 2023
Kshitij-Katiyar added a commit to Brightscout/mattermost-plugin-github that referenced this issue Feb 6, 2023
…n github plugin (#19)

* [MI-2688]:Fixed review comments by mm team for issue mattermost#500 on github plugin

* [MI-2688]:Fixed review comments

* [MI-2688]:Fixed review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment