Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate bot DM is being created when a user is mentioned on a PR assigned to the user #558

Closed
mickmister opened this issue Apr 7, 2022 · 4 comments · Fixed by #633
Closed

Duplicate bot DM is being created when a user is mentioned on a PR assigned to the user #558

mickmister opened this issue Apr 7, 2022 · 4 comments · Fixed by #633
Labels
Type/Enhancement New feature or improvement of existing feature

Comments

@mickmister
Copy link
Member

image
@hanzei
Copy link
Contributor

hanzei commented Apr 7, 2022

@mickmister Do you know if this is a regression?

@mickmister
Copy link
Member Author

@hanzei I do not know. I haven't looked into the issue other than creating this ticket

@sibasankarnayak sibasankarnayak mentioned this issue Apr 8, 2022
Closed
@hanzei hanzei added this to the v2.2.0 milestone Apr 12, 2022
@hanzei hanzei added the Type/Enhancement New feature or improvement of existing feature label Apr 12, 2022
@hanzei hanzei removed this from the v2.2.0 milestone Sep 20, 2022
@Kshitij-Katiyar
Copy link
Contributor

@mickmister There are 2 types of notification posted above, Mentioned and Commented. So which notification should have a higher priority than the other in this case should we post only mentioned notification or the commented one?

@mickmister
Copy link
Member Author

@Kshitij-Katiyar This was discussed here #559 (comment) but there was no conclusion made. Ideally we can say "mentioned in a PR assigned to you", but if not I think just "mentioned you in a comment" works

Kshitij-Katiyar added a commit to Brightscout/mattermost-plugin-github that referenced this issue Jan 17, 2023
@Kshitij-Katiyar
[MI-2634]:Fixed github issue mattermost#558 on duplicate notifications
4f0635c
@Kshitij-Katiyar Kshitij-Katiyar mentioned this issue Jan 17, 2023
Merged
Kshitij-Katiyar added a commit to Brightscout/mattermost-plugin-github that referenced this issue Jan 19, 2023
@Kshitij-Katiyar
[MI-2634]:Fixed github issue mattermost#558 on duplicate notifications (
92e3f24 
#18)

* [MI-2634]:Fixed github issue mattermost#558 on duplicate notifications

* [MI-2634]:Fixed review comments

* [MI-2634]:fixed review fixes

* [MI-2634]:Fixed review comments
@Kshitij-Katiyar Kshitij-Katiyar mentioned this issue Jan 19, 2023
Merged
@hanzei hanzei linked a pull request Feb 2, 2023 that will close this issue
[GH-558]:Fixed github issue "Duplicate notifications in case of mention and assignee" #633
Merged
hanzei pushed a commit that referenced this issue Feb 28, 2023
@Kshitij-Katiyar
[GH-558]:Fixed github issue "Duplicate notifications in case of menti…
4c66ed2 
…on and assignee" (#633)

* [MI-2634]:Fixed github issue #558 on duplicate notifications (#18)

* [MI-2634]:Fixed github issue #558 on duplicate notifications

* [MI-2634]:Fixed review comments

* [MI-2634]:fixed review fixes

* [MI-2634]:Fixed review comments

* [MM-558]:Fixed review comments

* [MM-558]:Added comments for notification

* [MI-558]:Fixed review comments
@avas27JTG avas27JTG mentioned this issue Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type/Enhancement New feature or improvement of existing feature
Projects
Brightscout Plugin Maintenance
Status: Done
Milestone
No milestone
4 participants
@mickmister @hanzei @sibasankarnayak @Kshitij-Katiyar