Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-52397] Move client package into root directory #671

Merged
merged 1 commit into from
May 10, 2023

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Apr 23, 2023

Summary

This makes the package more discoverable and makes it clear that it's not part of the plugin built.

Ticket Link

https://mattermost.atlassian.net/browse/MM-52397

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Apr 23, 2023
@hanzei hanzei requested a review from srkgupta April 23, 2023 21:07
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (c712474) 15.46% compared to head (7052368) 15.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #671   +/-   ##
=======================================
  Coverage   15.46%   15.46%           
=======================================
  Files          15       15           
  Lines        5497     5497           
=======================================
  Hits          850      850           
  Misses       4605     4605           
  Partials       42       42           
Impacted Files Coverage Δ
client/client.go 52.50% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels May 9, 2023
@hanzei hanzei requested a review from mickmister May 9, 2023 19:02
@hanzei hanzei added this to the v2.2.0 milestone May 9, 2023
@hanzei hanzei enabled auto-merge (squash) May 9, 2023 19:02
@hanzei hanzei merged commit a45515e into master May 10, 2023
8 checks passed
@hanzei hanzei deleted the MM-52397_client-root branch May 10, 2023 15:44
@avas27JTG avas27JTG mentioned this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants