Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-693] Fix improper rendering of some unreads in the response of "/github todo" command #699

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

raghavaggarwal2308
Copy link
Contributor

@raghavaggarwal2308 raghavaggarwal2308 commented Sep 26, 2023

Summary

The URL that was used to create the pretext of the unread message and the repo URL was missing in the body of Discussion and CheckSuite type unread. We updated the code to use the repo link present in the body of an unread message. Also, we couldn't find any possible way to get the URL of "Discussion" or "CheckSuite", so we are not displaying them as a link.

Screenshots

Earlier:
image

Now:
image

Possible risk:

  • If for some specific/unknown type of notification, the repo link is not present it might not be displayed properly.

What to test:

  • Links in the response of the /github todo command are rendered and working properly.
Steps to reproduce
  1. Connect your Github account to MM.
  2. Create notifications of different types on Github, Like Discussion, checkSuite, PullRequest, etc.
  3. Run the /github todo command in any MM channel.
Environment:

MM version: v7.8.2
Node version: 14.18.0
Go version: 1.19.0

Ticket Link

Fixes #693

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (92736d3) 15.78% compared to head (b2865f0) 15.92%.

❗ Current head b2865f0 differs from pull request most recent head accf785. Consider uploading reports for the commit accf785 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #699      +/-   ##
==========================================
+ Coverage   15.78%   15.92%   +0.13%     
==========================================
  Files          15       15              
  Lines        5574     5583       +9     
==========================================
+ Hits          880      889       +9     
  Misses       4652     4652              
  Partials       42       42              
Files Coverage Δ
server/plugin/utils.go 61.56% <100.00%> (+1.40%) ⬆️
server/plugin/plugin.go 5.54% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Sep 26, 2023
server/plugin/utils.go Show resolved Hide resolved
server/plugin/utils.go Outdated Show resolved Hide resolved
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mickmister mickmister removed the 2: Dev Review Requires review by a core committer label Sep 27, 2023
@hanzei hanzei added this to the v2.2.0 milestone Sep 29, 2023
@avas27JTG avas27JTG modified the milestones: v2.2.0, v2.3.0 Nov 9, 2023
@hanzei hanzei mentioned this pull request Nov 9, 2023
@avas27JTG avas27JTG modified the milestones: v2.3.0, v2.2.0 Nov 13, 2023
Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and Approved
All the links are reflected well and redirecting the user correctly to the desired page, LGTM.

@mickmister mickmister added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Nov 22, 2023
@mickmister mickmister merged commit af69820 into mattermost:master Nov 22, 2023
9 checks passed
@raghavaggarwal2308 raghavaggarwal2308 deleted the fix_issue_693 branch November 23, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unusable links in plugin messages
6 participants