Backport github plugin improvements #61
Labels
Hacktoberfest
Help Wanted
Community help wanted
Type/Task
A general task
Up For Grabs
Ready for help from the community. Removed when someone volunteers
Milestone
Comments
hanzei
added
Enhancement
Help Wanted
|
@hanzei to update the list |
Merged
hanzei
pushed a commit
that referenced
this issue
Mar 2, 2023
* Added RHS support to gilab plugin. (#1) * Added RHS Support 1. Opening right hand sidebar onclick of LHS buttons. 2. Displaying users merge requests, assignments, reviews and todos. 3. Displaying Labels on reviews , merge requests and assignments. * Adding RHS to gitlab 1. Displaying unread todos in RHS. * Review fixes 1. String in sigle quotes. 2. indentation. 3.removing extra spaces * Review Fixes 1. Fixing dependencies. 2. Adding EOF. * used string literals * use nullish coalescing operator * Error in api 1. Error while fetching reviews and pr's. * review fixes * review fixes * Review fixes. 1. Upgraded dependency versions. 2. Convertes sider_right.jsx to .tsx * Fixed linting errors and changed some eslint config Added a new dependency eslint-plugin-react-hooks and used that in .eslintrc.json Added some new rules in eslintrc related to typescript from the Github plugin * Fixed some more spacing issues * Apply suggestions from code review * Review fixes 1. Upgraded mattermost-redux version. 2. Moved constants. * Changed file extensions Co-authored-by: Manoj <manoj@brightscout.com> * Fix label details issue (#6) * Fixed issue with label details 1. Created a new func to get label details from api * Moved struct to top of file * Review fixes 1. Added logic to get label details in "yourAssignments" func. * Fixes name of struct * Fixed names of variables * Update RHS UI (#3) * Added RHS Support 1. Opening right hand sidebar onclick of LHS buttons. 2. Displaying users merge requests, assignments, reviews and todos. 3. Displaying Labels on reviews , merge requests and assignments. * Adding RHS to gitlab 1. Displaying unread todos in RHS. * Review fixes 1. String in sigle quotes. 2. indentation. 3.removing extra spaces * Displayed PR status * Improving RHS UI 1. Added status icon to PR's and reviews. 2. Added details of how many reviewers approved the PR. * fixed error in command_test file * Review Fixes 1. Fixing dependencies. 2. Adding EOF. * used string literals * use nullish coalescing operator * Error in api 1. Error while fetching reviews and pr's. * review fixes * review fixes * Review fixes. 1. Upgraded dependency versions. 2. Convertes sider_right.jsx to .tsx * Fixed issue with label details 1. Created a new func to get label details from api * Review fixes 1. Fixed warning in "npm run lint" command 2. Logged error while fetching pr details. 3. Removed extra variables. * Indentation fixes * Added space after semicolons * Review fixes 1. Added label details functionality to assignments. 2. Fixed error messages. * Review fixes 1. Removed trailing spaces. 2. Removed logger.Logger from "fetchPrDetails" func. * Review fixes 1. Fixed spacing in error message. * Review fixes 1. Passed logger to function * Fixed linting error * [MI-1823 & MI-1839]Review fixes for PR in mattermost 1. Defined abdolute paths. 2. Fixed indentation. 3. Removed redundant code. 4. Defined constants for strings. * [MI-1823]Indentation fix and removed white space * Review fix: Added blank line in gitlab_items.tsx * [MI-1823]Fixed getReviews api 1. Get reviews api was fetching merge requests assigned to the user. Fixed it to fetch the merge requests in which user is added as a reviewer. * Review fixes * [MI-1957] Review fixes of RHS support PR (#14) * [MI-1957] Do review fixes * [MI-1957] Self review fixes * [MI-1957] Bug fix * [MI-1957] Review fixes 1 * [MI-1957] Review fix 2 * [MI-1957] Review fix * [MI-1957] Review fixes 3 * [MI-1957] Add eof * [MI-1957] Correct translations * [MI-1957] Review fix * [MI-1957] Add a comment * [MI-1957] Correct comment * [MI-1957] Review fixes * [MI-2024] Gitlab PR review fixes (#19) * [MI-2024] Gitlab PR review fixes * [MI-2024] Fix error * [MI-2024] Review fix * [MI-2024] Revert changes * [MI-2024] Review fixes * Fix a constant for storing author * [MI-2389] Fix review fixes for PR rhs support * [MI-2389] Update a comment * [MI-2407] Review fixes for PR rhs support * [MI-2433] Review fixes 1. Removed extra useEffect for componentDidMount * [MI-2433] Review fixes 1. Created a generic usePrevious hook * Fix lint errors * [MI-2595] Review fixes on Gitlab PR #300 (Add RHS Support) * [MI-2845] Added space after link in RHS card. --------- Co-authored-by: Manoj <manoj@brightscout.com> Co-authored-by: ayusht2810 <100013900+ayusht2810@users.noreply.github.com> Co-authored-by: ayusht2810 <ayush.thakur@joshtechnologygroup.com> Co-authored-by: ayusht2810 <ayush.thakur@brightscout.com>
raghavaggarwal2308
added a commit
to Brightscout/mattermost-plugin-gitlab
that referenced
this issue
May 7, 2023
hanzei
pushed a commit
that referenced
this issue
Jun 19, 2023
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com> Co-authored-by: Nityanand Rai <nityanand.rai@brightscout.com> Co-authored-by: kshitij katiyar <90389917+Kshitij-Katiyar@users.noreply.github.com> Co-authored-by: Manoj <manoj@brightscout.com> Co-authored-by: Nityanand13 <107465508+Nityanand13@users.noreply.github.com>
avas27JTG
pushed a commit
that referenced
this issue
Nov 29, 2023
* MI-1845: Added tooltip for pull request and issue links * MI-1845: Done review fixes * Added the verbose flag to the npm install command in Makefile to fix failing CI * Fixed lint errors * Added regex for url valiation and constants for link types and states * Fixed linting errors * Removed unnecessary escape character * Minor code improvement * Fixed CI lint error * Added babel config for optional chaining * Added missing trailing comma * Fixed typo * [MI-1919] Fixes issue in link tooltip 1. Heading and description text overlays in tooltip when crosses a certain limit * [MI-1995] Fixed failing CI in link tooltip PR 1. Fixed the error "'gitlab.com' can be anywhere in the URL, and arbitrary hosts may come before or after it." * Fixed spacing around 'on' using js instead of using css * [MI-2755] Review fixes on gitlab PR #301 * [MI 2837]: Done the review fixes of a gitlab PR #301 (#30) * [MI-2837] Review fixes on gitlab PR #301 * [MI-2837]: Review fixes done 1. Written the test cases properly * [MI-2837]: Review fixes done 1. Improved code readability 2. Improved code consistency * [MI-2837]: Review fixes done 1. Improved code quality * [MI-2937]: Added EOF * [MI-2837]: Review fixes done 1. Improved code readability --------- Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com> * [MI-2963]: Did the review fixes of gitlab PR #301 (#32) * [MI-2963]: Did the review fixes of gitlab PR #301 1.Improved the unit tests 2.Improved the code readability * [MI-2963]: Fixed linting error * [MI-2963]: Review fixes done 1. Improved unit tests * [MI-2963]: Review fixes done 1. Added default in switch cases * [MI-2963]: Review fixes done 1. Dispatched the error * [MI-2963]: Review fixes done 1. Improved code readability * [MI-2963]:Review fixes done 1. Improved code readability * [MI-2963]: Review fxes done 1. Improved the description of a unit test * [MI-2986] Review fixes on Gitlab PR #301(Add link tooltip) 1. Replaced the deprecated icon component. 2. Added a return statement to avoid unnecessary code execution. --------- Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com> Co-authored-by: Nityanand Rai <107465508+Nityanand13@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: