[GH-61]: RHS Support #300

raghavaggarwal2308 · 2022-06-03T18:14:20Z

Summary

Added functionality to displays the details of users's open merge requests, merge requests needing review, assignments and unreads (todos) in the right-hand sidebar onclick of the buttons(respective icons) in the left-hand sidebar/team sidebar.

Created a new "SidebarRight" component and registered it as a RHS component and stored the "showRHSPluginAction" action in redux to use whenever needed to display the sidebar.
Stored the state of RHS in redux to display the different possible views.
Created API endpoint to fetch additional details of merge requests to display the merge request's commit status and number of approvals.
Added warning icon after merge request title if there are conflicts in the merge request.

Screenshots

RHS with open merge requests
RHS with unreads (todos)
RHS with no items to display

Ticket

Fixes #61 (Adding RHS support and Improve RHS UI and content)

* Added RHS Support 1. Opening right hand sidebar onclick of LHS buttons. 2. Displaying users merge requests, assignments, reviews and todos. 3. Displaying Labels on reviews , merge requests and assignments. * Adding RHS to gitlab 1. Displaying unread todos in RHS. * Review fixes 1. String in sigle quotes. 2. indentation. 3.removing extra spaces * Review Fixes 1. Fixing dependencies. 2. Adding EOF. * used string literals * use nullish coalescing operator * Error in api 1. Error while fetching reviews and pr's. * review fixes * review fixes * Review fixes. 1. Upgraded dependency versions. 2. Convertes sider_right.jsx to .tsx * Fixed linting errors and changed some eslint config Added a new dependency eslint-plugin-react-hooks and used that in .eslintrc.json Added some new rules in eslintrc related to typescript from the Github plugin * Fixed some more spacing issues * Apply suggestions from code review * Review fixes 1. Upgraded mattermost-redux version. 2. Moved constants. * Changed file extensions Co-authored-by: Manoj <manoj@brightscout.com>

mattermod · 2022-06-03T18:14:24Z

Hello @raghavaggarwal2308,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

codecov · 2022-06-03T18:17:39Z

Codecov Report

Patch coverage: 6.66% and project coverage change: -0.14 ⚠️

Comparison is base (2534105) 32.40% compared to head (3336353) 32.27%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
- Coverage   32.40%   32.27%   -0.14%     
==========================================
  Files          21       21              
  Lines        3419     3433      +14     
==========================================
  Hits         1108     1108              
- Misses       2201     2215      +14     
  Partials      110      110

Impacted Files	Coverage Δ
server/api.go	`23.14% <6.66%> (-0.69%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

raghavaggarwal2308 · 2022-06-03T18:26:49Z

/check-cla

* Fixed issue with label details 1. Created a new func to get label details from api * Moved struct to top of file * Review fixes 1. Added logic to get label details in "yourAssignments" func. * Fixes name of struct

* Added RHS Support 1. Opening right hand sidebar onclick of LHS buttons. 2. Displaying users merge requests, assignments, reviews and todos. 3. Displaying Labels on reviews , merge requests and assignments. * Adding RHS to gitlab 1. Displaying unread todos in RHS. * Review fixes 1. String in sigle quotes. 2. indentation. 3.removing extra spaces * Displayed PR status * Improving RHS UI 1. Added status icon to PR's and reviews. 2. Added details of how many reviewers approved the PR. * fixed error in command_test file * Review Fixes 1. Fixing dependencies. 2. Adding EOF. * used string literals * use nullish coalescing operator * Error in api 1. Error while fetching reviews and pr's. * review fixes * review fixes * Review fixes. 1. Upgraded dependency versions. 2. Convertes sider_right.jsx to .tsx * Fixed issue with label details 1. Created a new func to get label details from api * Review fixes 1. Fixed warning in "npm run lint" command 2. Logged error while fetching pr details. 3. Removed extra variables. * Indentation fixes * Added space after semicolons * Review fixes 1. Added label details functionality to assignments. 2. Fixed error messages. * Review fixes 1. Removed trailing spaces. 2. Removed logger.Logger from "fetchPrDetails" func. * Review fixes 1. Fixed spacing in error message. * Review fixes 1. Passed logger to function

raghavaggarwal2308 · 2022-06-09T17:04:07Z

Merged the following changes is this PR:

Created API endpoint to fetch additional details of merge requests to display the merge request's commit status and number of approvals.
Added warning icon after merge request title if there are conflicts in the merge request.

Ticket

Fixes #61 (Improve RHS UI and content)

webapp/.eslintrc.json

pvev · 2022-06-17T09:54:55Z

webapp/babel.config.js

+// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
+// See LICENSE.txt for license information.
+
+const config = {


same for this babel changes, what is the reason behind adding this?

The files I added are for typescript. Earliar there was not typescript file in the code, so no loaders were configured for .ts and .tsx files. That's why I added babel-loader and this file contains the babel-loader configurations.

pvev · 2022-06-17T09:56:40Z

webapp/package.json

+        "@primer/octicons-react": "10.1.0",
+        "core-js": "3.6.5",
+        "csstype": "3.0.3",
+        "mattermost-redux": "5.27.0",


I noticed there was a very specific version of redux. Was it for a specific reason? my question is like, is there any risk of regression for upgrading to 5.27?

There is a type defined in mattermost-redux named "Theme" it was not present in the version specified earliar, that's why updated it to this version.

ok, if there are not risk of regressions with this update I am ok with it.

pvev · 2022-06-17T09:57:51Z

webapp/src/actions/index.js

@@ -179,8 +242,8 @@ export function getGitlabUser(userID) {
        const user = getState()[`plugins-${id}`].gitlabUsers[userID];
        if (
            user &&
-      user.last_try &&
-      Date.now() - user.last_try < GITLAB_USER_GET_TIMEOUT_MILLISECONDS
+            user.last_try &&


pvev · 2022-06-17T09:58:01Z

webapp/src/actions/index.js

@@ -168,6 +213,24 @@ export function getUnreads() {
    };
 }

+/**


webapp/src/components/sidebar_buttons/sidebar_buttons.jsx

webapp/src/components/sidebar_right/gitlab_items.tsx

pvev · 2022-06-17T11:10:36Z

webapp/src/components/sidebar_right/gitlab_items.tsx

+import {formatTimeSince} from '../../utils/date_utils';
+import {GitlabItemsProps, Label} from "../../types/gitlab_items"
+
+export const notificationReasons: Record<string, string> = {


@mickmister what is the process to define/validate the wording for the plugin?

@cwarnermm Do you mind looking through the wording of the user-facing strings shown here?

@cwarnermm Would you be able to take a look at the user-facing strings here?

webapp/src/components/sidebar_right/gitlab_items.tsx

pvev · 2022-06-17T11:13:26Z

webapp/src/components/sidebar_right/gitlab_items.tsx

+    return (
+      <div key={item.id} style={style.container}>
+        <div>
+          <strong>


👍 nice use of semantic html

webapp/src/components/sidebar_right/gitlab_items.tsx

mattermod · 2022-12-19T01:01:52Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

…ab into rhs_support

[MI-2595] Review fixes on Gitlab PR mattermost#300 (Add RHS Support)

…ab into rhs_support

mickmister · 2023-01-24T01:22:04Z

@raghavaggarwal2308 Please make sure these changes are compatible with the chanegs from #333

raghavaggarwal2308 · 2023-02-02T11:51:43Z

@mickmister Tested, the changes are compatible with the changes of PR #333

mickmister · 2023-02-08T00:29:46Z

@DHaussermann This is ready for QA review

mattermost-build · 2023-02-18T01:01:28Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

hanzei · 2023-02-21T07:18:41Z

/update-branch

mattermost-build · 2023-02-21T07:18:43Z

We don't have permissions to update this PR, please contact the submitter to apply the update.

hanzei · 2023-02-21T07:23:48Z

@DHaussermann Gentle reminder to review the PR

DHaussermann · 2023-03-01T22:38:57Z

Hi @raghavaggarwal2308
This is looking good! I only have 1 small thing.

Is it easy to add 1 whitespace character between the end of the link and the beginning of the remaining data where the project name is?

…ab into rhs_support

raghavaggarwal2308 · 2023-03-02T07:31:01Z

@DHaussermann Fixed 👍🏽 (Added whitespace character between the end of the link and the beginning of the remaining data)

DHaussermann

Tested and passed

Ensured all record types now show in LHS
Link are functional
Styling shows as expected based on what is available in GitHub
Ensured labels also show as applicable
Tested in light and dark themes
Tested in browser and dektop app

LGTM!
Huge thanks for implementing this @raghavaggarwal2308 🎉 This is a huge improvement.

raghavaggarwal2308 requested a review from mickmister as a code owner June 3, 2022 18:14

raghavaggarwal2308 changed the title ~~[GL-61]: RHS Support #103~~ [GL-61]: RHS Support Jun 3, 2022

raghavaggarwal2308 changed the title ~~[GL-61]: RHS Support~~ [GH-61]: RHS Support Jun 3, 2022

raghavaggarwal2308 added 3 commits June 9, 2022 12:07

Fix label details issue (#6)

b2ba792

* Fixed issue with label details 1. Created a new func to get label details from api * Moved struct to top of file * Review fixes 1. Added logic to get label details in "yourAssignments" func. * Fixes name of struct

Fixed names of variables

d53cf00

Fixed linting error

af6cea3

mickmister requested review from pvev, DHaussermann and levb June 12, 2022 20:50

mickmister added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jun 12, 2022