Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-237] Number of Issues, Notes etc. not correct: API call responds are limited #366

Merged
merged 9 commits into from
Mar 28, 2023

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Mar 28, 2023

Summary

Resubmission of #284

Ticket Link

Fixes #237

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.16 ⚠️

Comparison is base (69abca9) 32.33% compared to head (f0c38fd) 32.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
- Coverage   32.33%   32.17%   -0.16%     
==========================================
  Files          21       21              
  Lines        3451     3468      +17     
==========================================
  Hits         1116     1116              
- Misses       2225     2242      +17     
  Partials      110      110              

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hanzei
Copy link
Collaborator Author

hanzei commented Mar 28, 2023

Merging as #284 has been approved

@hanzei hanzei enabled auto-merge (squash) March 28, 2023 16:13
internGitlab.WithContext(ctx),
)
opt := &internGitlab.ListMergeRequestsOptions{
AssigneeID: internGitlab.AssigneeID(user.GitlabUserID),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering why this changed from ReviewerID to AssigneeID

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good catch 👍 That's a bad merge. Submitted #368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number of Issues, Notes etc. not correct: API call responds are limited
3 participants