Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly fetch reviewer for LHS #368

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Correctly fetch reviewer for LHS #368

merged 1 commit into from
Mar 30, 2023

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Mar 30, 2023

Summary

Caused by a bad merge.

Thanks for catching that @mickmister 💯

Ticket Link

#366

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5adb3d0) 32.17% compared to head (5f063e8) 32.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #368   +/-   ##
=======================================
  Coverage   32.17%   32.17%           
=======================================
  Files          21       21           
  Lines        3468     3468           
=======================================
  Hits         1116     1116           
  Misses       2242     2242           
  Partials      110      110           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Have we kept the functionality consistent with before?

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Mar 30, 2023
@hanzei
Copy link
Collaborator Author

hanzei commented Mar 30, 2023

@mickmister Yes indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants