Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-35518 - Add CodeQL check #151

Closed
wants to merge 1 commit into from
Closed

MM-35518 - Add CodeQL check #151

wants to merge 1 commit into from

Conversation

srkgupta
Copy link

Summary

Added step to run automated CodeQL checks. Once this file is merged, the codeql checks (code scanning checks) will automatically be performed on following conditions:

  • new pull requests to master branch
  • scheduled to run every week once (it automatically pulls the latest codeql checks added, if any)

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-35518

@srkgupta srkgupta self-assigned this May 10, 2021
@srkgupta srkgupta requested a review from cpoile May 10, 2021 11:38
@hanzei hanzei self-requested a review May 11, 2021 18:14
@hanzei hanzei added the 2: Dev Review Requires review by a core committer label May 12, 2021
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The starter-template contains boiler plate code for community members to pick up. I'm hesitant to include this CI pipeline into it as it has nothing to do with plugins specifically.

Is there an urgent need to check the code of this repo despite it's template nature?

@srkgupta
Copy link
Author

Hi @hanzei
Thanks for checking. I initially added the codeql here thinking this might be a base against which other plugin repos would have been created. However upon looking into the code, I found there's nothing much here other than just boilerplate code. So we can skip this one. I will go ahead and close this. Thanks.

@srkgupta srkgupta closed this May 12, 2021
@srkgupta srkgupta removed the request for review from cpoile May 12, 2021 12:47
@hanzei hanzei deleted the codeql branch May 12, 2021 12:47
@hanzei hanzei added Invalid This doesn't seem right and removed 2: Dev Review Requires review by a core committer labels May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants