Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve explanation message for disabled setting "Enable Personal Meeting ID" #199

Closed
vmakarenko opened this issue Nov 10, 2020 · 2 comments · Fixed by #324
Closed

Improve explanation message for disabled setting "Enable Personal Meeting ID" #199

vmakarenko opened this issue Nov 10, 2020 · 2 comments · Fixed by #324
Assignees
@larkox
Labels
Type/Enhancement New feature or improvement of existing feature
Milestone
v1.7.0

Comments

@vmakarenko
Copy link

For the moment the plugin redirects to
image
page and gives no idea how to proceed further, e.g. change the setting in https://zoom.us/profile/setting
@hanzei hanzei added the Triage label Nov 10, 2020
@catalintomai
Copy link

catalintomai commented Nov 10, 2020 •
edited

FYI: In Zoom one can disable personal meeting Id. Can we make the user aware of it?

@larkox
Copy link
Contributor

larkox commented Nov 13, 2020

What we can do right now is check the PMI to be a valid PMI (!= -1), and if the PMI is invalid, not create the meeting and tell the user to enable PMI.

@hanzei hanzei added Type/Enhancement New feature or improvement of existing feature and removed Triage labels Nov 16, 2020
@hanzei hanzei mentioned this issue Nov 17, 2020
Merged
@raghavaggarwal2308 raghavaggarwal2308 mentioned this issue Nov 23, 2023
Merged
@avas27JTG avas27JTG added this to the next milestone milestone Nov 29, 2023
avas27JTG added a commit that referenced this issue Jan 2, 2024
@raghavaggarwal2308 @avas27JTG
[GH-199] Added a ephemeral message if the user is using PMI and his/h…
e22524d 
…er PMI setting is disable on Zoom. (#324)

* [MI-3763] Added a emhemeral message if the user is using PMI and his/her PMI setting is disable on Zoom.

* [MI-3763] Fix the issue for PMI setting "Ask"

* [MI-3763] Fixed a minor issue

* [MI-3763] Fix issues:
1. Setting command not working in threads view
2. Slack attachment to ask for PMI setting not getting posted in threads view.

* [MI-3763] Review fix

* [MI-3763] Create a meeting with unique ID if PMI is disabled on zoom

* [MM-4] Review fixes: Send generic error in case of error while creating meeting

* [MM-4] Review fix

* [MM-4] Review fixes

---------

Co-authored-by: Abhishek Verma <72438220+avas27JTG@users.noreply.github.com>
@avas27JTG avas27JTG modified the milestones: v1.8.0, v1.7.0 Jan 18, 2024
@avas27JTG avas27JTG mentioned this issue Jan 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larkox larkox

Labels
Type/Enhancement New feature or improvement of existing feature
Projects
None yet
Milestone
v1.7.0
5 participants
@larkox @vmakarenko @hanzei @catalintomai @avas27JTG