Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version v1.7.0. #322

Merged
merged 9 commits into from Feb 23, 2024
Merged

Conversation

avas27JTG
Copy link
Contributor

@avas27JTG avas27JTG commented Nov 20, 2023

Summary

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e8dfd09) 18.41% compared to head (b0adf26) 18.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #322   +/-   ##
=======================================
  Coverage   18.41%   18.41%           
=======================================
  Files           9        9           
  Lines        1515     1515           
=======================================
  Hits          279      279           
  Misses       1185     1185           
  Partials       51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mickmister
Copy link
Member

The PR says it's out of date with the master branch

@mickmister
Copy link
Member

/update-branch

@mattermost-build
Copy link
Contributor

We don't have permissions to update this PR, please contact the submitter to apply the update.

@avas27JTG avas27JTG added this to the v2.0.0 milestone Jan 4, 2024
@arush-vashishtha
Copy link

arush-vashishtha commented Jan 12, 2024

While performing the sanity testing I found an issue related to the limit in the Meeting topic while creating a meeting through the slash command /zoom start <meeting topic> for a very long meeting topic in any desired channel or DM/GM on MM.

Steps to reproduce:
Run the slash command /zoom start <meeting topic> with a very long meeting topic in any desired channel or DM/GM on MM.

Expected result:
The Zoom meeting should be created for very long meeting topic.

Actual result:
Zoom meeting is not created for very long meeting topic.

image
cc @raghavaggarwal2308 @AayushChaudhary0001

@arush-vashishtha
Copy link

This PR have been tested for all the PRs included, the basic flows and slash commands in the above mentioned list and they are working fine. Nonetheless found another issue regarding the "emojis" added to the meeting topic in the slash command /zoom start <meeting topic>.

Steps to Reproduce:
Run the slash command /zoom start <meeting topic> in any desired channel or DM/GM on MM and add emojis in the meeting topic.

Expected result:
The emoji should render properly in the meeting topic on slack attachment for the new meeting in the desired channel or DM/GM on MM.

Actual result:
The emoji name is being displayed in the meeting topic instead of the emoji in the desired channel or DM/GM on MM.

image

cc @raghavaggarwal2308 @AayushChaudhary0001

@raghavaggarwal2308
Copy link
Contributor

While performing the sanity testing I found an issue related to the limit in the Meeting topic while creating a meeting through the slash command /zoom start <meeting topic> for a very long meeting topic in any desired channel or DM/GM on MM.

Steps to reproduce: Run the slash command /zoom start <meeting topic> with a very long meeting topic in any desired channel or DM/GM on MM.

Expected result: The Zoom meeting should be created for very long meeting topic.

Actual result: Zoom meeting is not created for very long meeting topic.

image cc @raghavaggarwal2308 @AayushChaudhary0001

@arush-vashishtha I don't think this issue is related to any of the PR created in this release. Can you please create a separate issue for this? We can pick this up in an upcoming release.

@arush-vashishtha
Copy link

@arush-vashishtha I don't think this issue is related to any of the PR created in this release. Can you please create a separate issue for this? We can pick this up in an upcoming release.

A separate issue has been created, please look into it.
#336

@mickmister
Copy link
Member

@raghavaggarwal2308 The PR got closed since the issue was linked in the PR description, even though it was linked to comment

CleanShot 2024-01-29 at 21 18 42

@mickmister mickmister reopened this Jan 30, 2024
@mickmister
Copy link
Member

mickmister commented Jan 30, 2024

@avas27JTG Heads up that the PR needs to be sync'd with master

@mickmister mickmister merged commit 8034413 into mattermost:master Feb 23, 2024
18 checks passed
@raghavaggarwal2308 raghavaggarwal2308 deleted the release-bump-1.7.0 branch February 26, 2024 08:28
@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants