GH-200: Pass topic to zoom start #209

kott · 2021-01-18T21:25:34Z

Summary

With this change we will be able to pass a meeting topic to the Zoom start command, e.g. /zoom start <meeting name>. Now the chat message containing the meeting's information will also include the topic, rather than just zoom meeting.

Ticket Link

Fixes #200

mattermod · 2021-01-18T21:25:37Z

Hello @kott,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

codecov · 2021-01-18T22:13:45Z

Codecov Report

Merging #209 (ddddc88) into master (ddea06a) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master    #209   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           8       8           
  Lines         854     858    +4     
======================================
- Misses        854     858    +4

Impacted Files	Coverage Δ
server/command.go	`0.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddea06a...ddddc88. Read the comment docs.

larkox

Great work! LGTM. Thanks for contributing!

mickmister

What a great feature! Thanks for this contribution @kott! Also great job on extracting out the command parsing 👍

Functionally looks good to me, though wondering your thoughts on one suggestion 🙂

mickmister · 2021-01-20T06:02:10Z

server/command.go

@@ -107,8 +122,10 @@ func (p *Plugin) runStartCommand(args *model.CommandArgs, user *model.User) (str
 		return "Error checking previous messages", nil
 	}

+	_, _, topic := p.parseCommand(args.Command)


It seems a bit off how there are two calls the parseCommand, ignoring certain return values in each call. What are your thoughts on having runStartCommand accept a topic string parameter to avoid this function call here?

Yeah that's a good point. Just pushed a change.

…mattermost-plugin-zoom into mattermostGH-200-add-meeting-topic * 'mattermostGH-200-add-meeting-topic' of github.com:kott/mattermost-plugin-zoom: Update plugin.json (mattermost#208)

mattermod · 2021-01-31T01:01:18Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

emilyacook · 2021-02-03T21:50:53Z

@DHaussermann gentle ping, I think this is waiting on your review?

DHaussermann · 2021-02-07T18:01:24Z

@larkox I could test this now. I just wasn't not sure if we need to resolve and merge #147 .

Please advise if this can be independently merged and tested.

mattermod · 2021-02-18T01:01:21Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

lindy65 · 2021-05-27T09:39:31Z

Hi @DHaussermann @larkox - any news on this review? I'm helping to review stale PRs and wonder if this one can be closed if not required / isn't a priority? Thanks!

hanzei · 2021-10-28T07:58:42Z

@dipak-demansol Could you please review this PR? (Medium priority)

dipak-demansol · 2021-10-28T08:41:41Z

@dipak-demansol Could you please review this PR? (Medium priority)

sure

dipak-demansol · 2021-11-10T13:19:09Z

@hanzei i tested this, its working but i found a minor issue, after discussing with @DHaussermann i will add the Review.

dipak-demansol

The functionality for this is looking good!
One request would be, is it possible to also update the slash command auto complete functionality for start with help text such as topic (optional) This would help users discover the new functionality.

hanzei · 2021-11-11T08:04:40Z

The functionality for this is looking good! One request would be, is it possible to also update the slash command auto complete functionality for start with help text such as topic (optional) This would help users discover the new functionality.

@kott Would you be interested in adding auto complete for this feature? If not, don't worry. We can merge this PR as it is.

kott · 2021-11-28T20:24:47Z

The functionality for this is looking good! One request would be, is it possible to also update the slash command auto complete functionality for start with help text such as topic (optional) This would help users discover the new functionality.

@kott Would you be interested in adding auto complete for this feature? If not, don't worry. We can merge this PR as it is.

@hanzei I'd be happy do it but maybe as a separate PR?

hanzei · 2021-11-29T11:51:09Z

@kott Sound good to me 👍 Merging as it is

add topic functionality to slash command

d1e4f00

kott requested a review from larkox as a code owner January 18, 2021 21:25

cleanup

c4c1ec7

larkox requested a review from mickmister January 19, 2021 07:23

larkox added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jan 19, 2021

larkox approved these changes Jan 19, 2021

View reviewed changes

Merge branch 'master' into mattermostGH-200-add-meeting-topic

8babb7f

mickmister approved these changes Jan 20, 2021

View reviewed changes

mickmister removed the 2: Dev Review Requires review by a core committer label Jan 20, 2021

mickmister requested a review from DHaussermann January 20, 2021 06:07

kott added 2 commits January 20, 2021 10:13

runStartCommand accepts topic

cf46737

Merge branch 'mattermostGH-200-add-meeting-topic' of github.com:kott/…

fe95408

…mattermost-plugin-zoom into mattermostGH-200-add-meeting-topic * 'mattermostGH-200-add-meeting-topic' of github.com:kott/mattermost-plugin-zoom: Update plugin.json (mattermost#208)

mattermod added the Lifecycle/1:stale label Jan 31, 2021

emilyacook removed the Lifecycle/1:stale label Feb 3, 2021

mattermod added the Lifecycle/1:stale label Feb 18, 2021

hanzei requested a review from dipak-demansol October 28, 2021 07:58

Merge branch 'master' into mattermostGH-200-add-meeting-topic

1a05822

dipak-demansol approved these changes Nov 10, 2021

View reviewed changes

dipak-demansol removed the 3: QA Review Requires review by a QA tester label Nov 10, 2021

dipak-demansol added the QA Review Done PR has been approved by QA label Nov 10, 2021

Merge branch 'master' into mattermostGH-200-add-meeting-topic

f707df8

hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed QA Review Done PR has been approved by QA labels Nov 11, 2021

hanzei added this to the v2.0.0 milestone Nov 11, 2021

Merge branch 'master' into mattermostGH-200-add-meeting-topic

ddddc88

hanzei mentioned this pull request Nov 29, 2021

Add auto complete for zoom topic command #244

Closed

hanzei removed the Lifecycle/1:stale label Nov 29, 2021

hanzei merged commit 655befa into mattermost:master Nov 29, 2021

This was referenced Nov 14, 2023

Bump version v2.0.0 (closed, renamed to v1.7.0) #321

Closed

Bump version v1.7.0. #322

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-200: Pass topic to zoom start #209

GH-200: Pass topic to zoom start #209

kott commented Jan 18, 2021

mattermod commented Jan 18, 2021

codecov bot commented Jan 18, 2021 •

edited

larkox left a comment

mickmister left a comment

mickmister Jan 20, 2021

kott Jan 20, 2021

mattermod commented Jan 31, 2021

emilyacook commented Feb 3, 2021

DHaussermann commented Feb 7, 2021

mattermod commented Feb 18, 2021

lindy65 commented May 27, 2021

hanzei commented Oct 28, 2021

dipak-demansol commented Oct 28, 2021

dipak-demansol commented Nov 10, 2021

dipak-demansol left a comment •

edited

hanzei commented Nov 11, 2021

kott commented Nov 28, 2021

hanzei commented Nov 29, 2021

GH-200: Pass topic to zoom start #209

GH-200: Pass topic to zoom start #209

Conversation

kott commented Jan 18, 2021

Summary

Ticket Link

mattermod commented Jan 18, 2021

codecov bot commented Jan 18, 2021 • edited

Codecov Report

larkox left a comment

Choose a reason for hiding this comment

mickmister left a comment

Choose a reason for hiding this comment

mickmister Jan 20, 2021

Choose a reason for hiding this comment

kott Jan 20, 2021

Choose a reason for hiding this comment

mattermod commented Jan 31, 2021

emilyacook commented Feb 3, 2021

DHaussermann commented Feb 7, 2021

mattermod commented Feb 18, 2021

lindy65 commented May 27, 2021

hanzei commented Oct 28, 2021

dipak-demansol commented Oct 28, 2021

dipak-demansol commented Nov 10, 2021

dipak-demansol left a comment • edited

Choose a reason for hiding this comment

hanzei commented Nov 11, 2021

kott commented Nov 28, 2021

hanzei commented Nov 29, 2021

codecov bot commented Jan 18, 2021 •

edited

dipak-demansol left a comment •

edited