Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom installation docs update #245

Merged
merged 12 commits into from Jan 10, 2022
Merged

Conversation

justinegeffen
Copy link
Contributor

This PR removes reverences to a previously removed 'enable password based authentication' toggle in the setup documentation. It also replaces the image of the settings. Fixes: #229

@justinegeffen justinegeffen changed the title Add files via upload Zoom installation docs update Dec 7, 2021
@justinegeffen justinegeffen added the 2: Dev Review Requires review by a core committer label Dec 7, 2021
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #245 (be118c6) into master (65af542) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #245   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           8       8           
  Lines         882     882           
======================================
  Misses        882     882           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65af542...be118c6. Read the comment docs.

Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. LGTM, just small comments, but nothing blocking.

docs/installation/install-zoom-plugin.md Outdated Show resolved Hide resolved
* Users don't need to authorize their Zoom accounts before starting their first Zoom meeting. The only requirement is that their Mattermost account uses the same email address as their Zoom account.
* Users can't connect their Mattermost/Zoom accounts if their emails do not match.
* **User-level app**
* Each user needs to connect their Zoom account with their Mattermost account before they can use the integration. When they try to create a meeting for the first time, they'll receive a message to connect their account, and will need to click **Approve** on the pop-up confirmation notice.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if worth it, but the actual flow is:

  • They try to create a meeting
  • They must follow a link
  • The link will redirect to a zoom owned website
  • On this site, if they are not logged in, they will be asked to log in into zoom
  • Once they are logged in, they will see the "approve" button.

Probably with what is already written, everything is clear, but wanted to make sure.

@hanzei hanzei added the Awaiting Submitter Action Blocked on the author label Dec 20, 2021
@justinegeffen justinegeffen added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer Awaiting Submitter Action Blocked on the author labels Jan 10, 2022
@justinegeffen justinegeffen merged commit 1188a27 into master Jan 10, 2022
@justinegeffen justinegeffen deleted the justinegeffen-zoom-config branch January 10, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update mattermost-setup.md to remove references to "Enable Password Based Authentication"
3 participants