Handle test notifications #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enahum
approved these changes
Feb 23, 2022
|
@enahum Do we want to merge this already? I don't see any reason to delay the merge. |
|
Definitely delayed and waiting for #87 I rather have it here and not deployed by mistake. |
agnivade
approved these changes
Mar 29, 2022
| "version": msg.Version, | ||
| "channel_id": msg.ChannelID, | ||
| "is_crt_enabled": msg.IsCRTEnabled, | ||
| } | ||
|
|
||
| if msg.Badge != -1 { |
There was a problem hiding this comment.
Maybe better to check for < 0? 0/5
enahum
added
2: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Handle test notifications.
Related PRs:
Mobile (Gekidou): mattermost/mattermost-mobile#6002
Server: mattermost/mattermost#19610
Ticket Link
None