Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add server_id & team_id to notification payload #87

Merged
merged 4 commits into from
Apr 1, 2022
Merged

Add server_id & team_id to notification payload #87

merged 4 commits into from
Apr 1, 2022

Conversation

enahum
Copy link
Contributor

@enahum enahum commented Oct 23, 2021

Summary

  • Add the server identifier to the notification payload (this will be required for mobile app v2)
  • Add teamId to message and id-loaded notification payload
  • Adds content-available to message notification type on iOS (required for v2, may cause problems with v1)

@enahum enahum added 1: Dev Review Requires review by a core commiter Do Not Merge Should not be merged until this label is removed labels Oct 23, 2021
@enahum enahum removed the 1: Dev Review Requires review by a core commiter label Oct 25, 2021
@hanzei hanzei added the 2: Reviews Complete All reviewers have approved the pull request label Jan 5, 2022
@cpanato
Copy link
Contributor

cpanato commented Jan 20, 2022

@enahum this PR are still valid? if yes can you rebase it then we can merge? or what is missing to merge this?

@enahum
Copy link
Contributor Author

enahum commented Jan 20, 2022

@cpanato This is still valid but do not want to merge yet

@cpanato
Copy link
Contributor

cpanato commented Jan 20, 2022

@cpanato This is still valid but do not want to merge yet

thanks!

@github-actions
Copy link

github-actions bot commented Jan 20, 2022 •
edited

Unit Test Results

  1 files  ±0    5 suites  ±0   16s ⏱️ ±0s
18 tests ±0  18 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6806a18. ± Comparison against base commit 6e9237f.

♻️ This comment has been updated with latest results.

@enahum enahum mentioned this pull request Feb 15, 2022
Merged
@enahum enahum mentioned this pull request Mar 1, 2022
Merged
@enahum enahum removed the Do Not Merge Should not be merged until this label is removed label Mar 28, 2022
@enahum enahum merged commit df42caf into master Apr 1, 2022
@enahum enahum deleted the server-id branch April 1, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnivade agnivade agnivade approved these changes

@anurag6713 anurag6713 anurag6713 approved these changes

@cpanato cpanato cpanato approved these changes

Assignees
No one assigned
Labels
2: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
5 participants
@enahum @cpanato @agnivade @anurag6713 @hanzei