-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable EnablePublicChannelsMaterialization by default #9418
Merged
crspeller
merged 2 commits into
master
from
disable-EnablePublicChannelsMaterialization-by-default
Sep 17, 2018
Merged
disable EnablePublicChannelsMaterialization by default #9418
crspeller
merged 2 commits into
master
from
disable-EnablePublicChannelsMaterialization-by-default
Sep 17, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating triggers on Amazon RDS seems to reqiure extra privileges. More investigation is required.
jwilander
reviewed
Sep 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to set the default in model/config.go too right?
You are correct -- fixed! |
jwilander
approved these changes
Sep 17, 2018
crspeller
approved these changes
Sep 17, 2018
crspeller
deleted the
disable-EnablePublicChannelsMaterialization-by-default
branch
September 17, 2018 14:37
amyblais
added
Docs/Needed
Requires documentation
Changelog/Not Needed
Does not require a changelog entry
labels
Sep 17, 2018
lieut-data
added a commit
that referenced
this pull request
Sep 17, 2018
This reverts commit 5786b0d, now that the feature is safe to enable by default.
jwilander
pushed a commit
that referenced
this pull request
Sep 18, 2018
amyblais
added
Docs/Not Needed
Does not require documentation
and removed
Docs/Needed
Requires documentation
labels
Sep 18, 2018
Tests done as https://mattermost.atlassian.net/browse/MM-11947 adding label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2: Dev Review
Requires review by a developer
Changelog/Not Needed
Does not require a changelog entry
Docs/Not Needed
Does not require documentation
Tests/Done
Required release tests have been written
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Creating triggers on Amazon RDS seems to reqiure extra privileges. More
investigation is required. See https://pre-release.mattermost.com/core/pl/ddmtpshtyp843y1sk46smeo8jo for discussion.
Ticket Link
N/A.