Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable EnablePublicChannelsMaterialization by default #9418

Merged
merged 2 commits into from Sep 17, 2018
Merged

disable EnablePublicChannelsMaterialization by default #9418

merged 2 commits into from Sep 17, 2018

Conversation

lieut-data
Copy link
Member

Summary

Creating triggers on Amazon RDS seems to reqiure extra privileges. More
investigation is required. See https://pre-release.mattermost.com/core/pl/ddmtpshtyp843y1sk46smeo8jo for discussion.

Ticket Link

N/A.

@lieut-data
disable EnablePublicChannelsMaterialization by default
224b459 
Creating triggers on Amazon RDS seems to reqiure extra privileges. More
investigation is required.
@lieut-data lieut-data added the 2: Dev Review Requires review by a developer label Sep 14, 2018
jwilander
jwilander reviewed Sep 14, 2018
View reviewed changes
Copy link
Member

@jwilander jwilander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to set the default in model/config.go too right?

@lieut-data
Copy link
Member Author

You are correct -- fixed!

@crspeller crspeller merged commit 5786b0d into master Sep 17, 2018
@crspeller crspeller deleted the disable-EnablePublicChannelsMaterialization-by-default branch September 17, 2018 14:37
@amyblais amyblais added Docs/Needed Requires documentation Changelog/Not Needed Does not require a changelog entry labels Sep 17, 2018
lieut-data added a commit that referenced this pull request Sep 17, 2018
@lieut-data
Revert "disable EnablePublicChannelsMaterialization by default (#9418)"
0b3c73d 
This reverts commit 5786b0d, now that
the feature is safe to enable by default.
jwilander pushed a commit that referenced this pull request Sep 18, 2018
@lieut-data @jwilander
Revert "disable EnablePublicChannelsMaterialization by default (#9418)…
0204c45 
…" (#9427)

This reverts commit 5786b0d, now that
the feature is safe to enable by default.
@amyblais amyblais added Docs/Not Needed Does not require documentation and removed Docs/Needed Requires documentation labels Sep 18, 2018
@DHaussermann
Copy link

Tests done as https://mattermost.atlassian.net/browse/MM-11947 adding label.

@DHaussermann DHaussermann added the Tests/Done Required release tests have been written label Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwilander jwilander jwilander approved these changes

@crspeller crspeller crspeller approved these changes

Assignees
No one assigned
Labels
2: Dev Review Requires review by a developer Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Done Required release tests have been written
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lieut-data @DHaussermann @jwilander @crspeller @amyblais