Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-42030: Migrate Threads RHS tour tip to tippy based tour tip #10099

Closed
wants to merge 5 commits into from
Closed

MM-42030: Migrate Threads RHS tour tip to tippy based tour tip #10099

wants to merge 5 commits into from

Conversation

codedsun
Copy link
Contributor

Summary

Ticket Link

mattermost/mattermost#19802

Related Pull Requests

  • Has server changes (please link here)
  • Has mobile changes (please link here)

Screenshots

Release Note

NONE

@mattermod
Copy link
Contributor

Hello @codedsun,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@mattermod mattermod requested review from a team and hmhealey and removed request for a team March 30, 2022 15:06
@mattermod mattermod added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester Contributor labels Mar 30, 2022
@AshishDhama AshishDhama requested review from AshishDhama and jfrerich and removed request for hmhealey March 30, 2022 15:14
@codedsun codedsun marked this pull request as draft March 30, 2022 15:21
@codedsun codedsun marked this pull request as ready for review March 30, 2022 16:47
@AshishDhama AshishDhama added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Mar 30, 2022
@AshishDhama
Copy link
Contributor

@codedsun Could you please fix the broken test.

@saturninoabril
Copy link
Member

@AshishDhama I think it failed due to dependency with root-portal. So maybe either handle null value of appendTo in TourTipBackdrop component like

if (!appendTo) {
    return null;
}

or modify the test (rhs_header_post.spec.tsx) to render DOM elements with root-portal together with component (RhsHeaderPost) under test.

@mattermod
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@AshishDhama
Copy link
Contributor

@codedsun Were you able to add the patch?

@angeloskyratzakos angeloskyratzakos removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label May 5, 2022
@AshishDhama AshishDhama mentioned this pull request May 9, 2022
Merged
@AshishDhama
Copy link
Contributor

/update-branch

@AshishDhama
Copy link
Contributor

@jfrerich @jgilliam17 This pr is ready for review

jfrerich
jfrerich approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@jfrerich jfrerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AshishDhama AshishDhama added Setup Cloud Test Server Setup a test server using Mattermost Cloud and removed Lifecycle/1:stale labels May 13, 2022
@AshishDhama AshishDhama removed the 2: Dev Review Requires review by a core commiter label May 16, 2022
AshishDhama
AshishDhama approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@AshishDhama AshishDhama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AshishDhama
Copy link
Contributor

@jgilliam17 Gentle reminder on this one.

@jgilliam17
Copy link
Contributor

/update-branch

@jgilliam17 jgilliam17 added Setup Cloud Test Server Setup a test server using Mattermost Cloud and removed Setup Cloud Test Server Setup a test server using Mattermost Cloud labels May 24, 2022
@mm-cloud-bot mm-cloud-bot removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label May 24, 2022
@jgilliam17 jgilliam17 added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label May 24, 2022
@mm-cloud-bot mm-cloud-bot removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label May 24, 2022
@jgilliam17
Copy link
Contributor

/e2e-test

@mattermod
Copy link
Contributor

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/198144

@jgilliam17 jgilliam17 added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label May 24, 2022
@mm-cloud-bot
Copy link

No Kubernetes clusters available at the moment, please contact the Mattermost Cloud Team or wait a bit.

@mm-cloud-bot mm-cloud-bot removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label May 24, 2022
@jgilliam17 jgilliam17 added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label May 24, 2022
@mm-cloud-bot mm-cloud-bot removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label May 24, 2022
@mm-cloud-bot
Copy link

Test server destroyed

@saturninoabril
Copy link
Member

/update-branch

@saturninoabril
Copy link
Member

/e2e-test

@mattermod
Copy link
Contributor

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/198266

@jgilliam17
Copy link
Contributor

Thanks @codedsun and also @saturninoabril for fixing the pipeline and running the e2es.
There are few failures related to this PR. @codedsun Please see the report here and let us know if you need help addressing these

@mattermod
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

jgilliam17
jgilliam17 suggested changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@jgilliam17 jgilliam17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codedsun Let me know if you have any questions about addressing E2E failures
See comment here: #10099 (comment)

@AshishDhama
Copy link
Contributor

closing in favour of #11107

@AshishDhama AshishDhama closed this Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jgilliam17 jgilliam17 jgilliam17 requested changes

@jfrerich jfrerich jfrerich approved these changes

@AshishDhama AshishDhama AshishDhama approved these changes

Assignees
No one assigned
Labels
3: QA Review Requires review by a QA tester Contributor Lifecycle/1:stale release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@codedsun @mattermod @AshishDhama @saturninoabril @jgilliam17 @mm-cloud-bot @jfrerich @angeloskyratzakos