MM-45494: Edit message history #11555

AshishDhama · 2022-11-07T10:04:35Z

Summary

This PR introduces a new feature for users to

see the edit history of their edited messages
restore an old version

Ticket Link

Fixes mattermost/mattermost#20864
JIRA: https://mattermost.atlassian.net/browse/MM-45494

Related Pull Requests

Has server changes MM-45494: Edit message history mattermost#21601

Screenshots

Screen.Recording.2022-09-11.at.14.48.46.mov

Release Note

Give ability to users to see the history of edited messages and restore an old version with current version.

AshishDhama · 2023-01-30T12:33:35Z

/e2e-test

mattermost-build · 2023-01-30T12:33:37Z

The command /e2e-test requires all PR checks to pass.

AshishDhama · 2023-02-02T05:33:05Z

/e2e-test

mattermost-build · 2023-02-02T05:33:07Z

The command /e2e-test requires all PR checks to pass.

AshishDhama · 2023-02-02T05:33:23Z

/update-branch

jgilliam17 · 2023-02-02T14:47:46Z

/e2e-test

mattermost-build · 2023-02-02T14:47:50Z

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

jgilliam17 · 2023-02-02T21:32:58Z

Thanks @sinansonmez
E2E report - looks good, no PR related failures when compared to master
2 tests failing due to #user-profile-popover, also fail on other prs. I'll create a follow up ticket for that and link here if you'd like to pick it up
Help Wanted ticket created: https://mattermost.atlassian.net/browse/MM-50295

sinansonmez · 2023-02-02T22:45:18Z

Thanks @jgilliam17 I commented on the issue to assign it to myself.

I suppose, after your final checks, my 2 PRs (mattermost/mattermost#20945 and #11069) are ready to be merged.

jgilliam17 · 2023-02-02T23:43:28Z

Thanks for picking up another Help Wanted ticket @sinansonmez
Can you please rebase branch with master and fix conflicts.
@AshishDhama please let me know if anything else needs to be done before merge of all 3 PRs? Thanks 🙂

sinansonmez · 2023-02-02T23:45:34Z

Thanks @jgilliam17 i just updated branches and fixed conflicts in my PRs. Ashish just need to pull the changes

jgilliam17

Suggesting test case ID

jgilliam17 · 2023-02-02T23:59:22Z

e2e/cypress/tests/integration/messaging/message_edit_post_history_spec.ts

+        });
+    });
+
+    it('MM-TXXX_1 Show and restore older versions of a message', () => {


Suggested change

it('MM-TXXX_1 Show and restore older versions of a message', () => {

it('MM-T5381_1 Show and restore older versions of a message', () => {

jgilliam17 · 2023-02-02T23:59:38Z

e2e/cypress/tests/integration/messaging/message_edit_post_history_spec.ts

+        });
+    });
+
+    it('MM-TXXX_2 Show, restore older versions of a message and click undo in toast', () => {


Suggested change

it('MM-TXXX_2 Show, restore older versions of a message and click undo in toast', () => {

it('MM-T5381_2 Show, restore older versions of a message and click undo in toast', () => {

jgilliam17 · 2023-02-02T23:59:48Z

e2e/cypress/tests/integration/messaging/message_edit_post_history_spec.ts

+        });
+    });
+
+    it('MM-TXXX_3 Edit history should not be available when user lacks edit own posts permissions', () => {


Suggested change

it('MM-TXXX_3 Edit history should not be available when user lacks edit own posts permissions', () => {

it('MM-T5381_3 Edit history should not be available when user lacks edit own posts permissions', () => {

AshishDhama · 2023-02-06T17:16:26Z

closing this in favour of original

mm-cloud-bot · 2023-02-06T17:16:36Z

Test server destroyed

mm-cloud-bot · 2023-02-06T17:16:38Z

Test server destroyed

sinansonmez and others added 30 commits August 27, 2022 23:10

check post owner and add click listener to edited

8e68690

change style of the text

55ea3ad

align naming of the variable

f04abe9

new rhs state added

96eadf7

add empty component

6d9b8a1

add header

cfc0aea

pass post to the action

67ff52f

add post edit item

becdda5

fix showhistory action

c53b30b

restore icon button is added

3e6d00d

fix user image and name alignment

5d00921

add currentVersion indicator

a9e2049

implement toggle

cce0dc3

update selectedPostId in global state

3a142d1

update state with channelId and selectedPost time

ff916de

fix visibility

703d8c1

Merge branch 'mattermost:master' into MM-45494-edit-message-history

ffd2f17

fix background color

d3b6cbd

fix background on hover

150fa9a

fix message visibility

b9a6f3d

fix edited icon

e3e67fa

delete unnecessary space

cd2049a

add overwrite name

b2ba751

additional post check

0c71094

add client call

5fcfe94

add postEditHistory to global state

112fa27

call get post edit history

3e33dca

update selector and reducer

038dcee

fix style

34d48a6

get postedithistory from globalState

e0c2a9c

sinansonmez added 3 commits January 24, 2023 23:10

revert changes on channel display name

2815d4d

fix root post/ reply edit history

58b743d

write e2e tests for edit post history

f830a83

matthewbirtch added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Jan 27, 2023

sinansonmez and others added 4 commits January 31, 2023 20:51

add check for edit own post permission

6b23801

Merge branch 'master' into MM-45494-edit-message-history

e8912db

add e2e test for without edit own post permission

092b817

fix test

fc9733f

Merge branch 'master' into MM-45494-edit-message-history

bba2fd5

jgilliam17 self-requested a review February 2, 2023 23:43

jgilliam17 approved these changes Feb 2, 2023

View reviewed changes

jgilliam17 reviewed Feb 3, 2023

View reviewed changes

This was referenced Feb 6, 2023

MM-45494: Edit message history #11069

Merged

MM-45494: Add endpoint for message history mattermost/mattermost#20945

Merged

AshishDhama closed this Feb 6, 2023

mattermost-build removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Feb 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MM-45494: Edit message history #11555

MM-45494: Edit message history #11555

AshishDhama commented Nov 7, 2022

AshishDhama commented Jan 30, 2023

mattermost-build commented Jan 30, 2023

AshishDhama commented Feb 2, 2023

mattermost-build commented Feb 2, 2023

AshishDhama commented Feb 2, 2023

jgilliam17 commented Feb 2, 2023

mattermost-build commented Feb 2, 2023

jgilliam17 commented Feb 2, 2023

sinansonmez commented Feb 2, 2023 •

edited

Loading

jgilliam17 commented Feb 2, 2023

sinansonmez commented Feb 2, 2023

jgilliam17 left a comment

jgilliam17 Feb 2, 2023

jgilliam17 Feb 2, 2023

jgilliam17 Feb 2, 2023

AshishDhama commented Feb 6, 2023

mm-cloud-bot commented Feb 6, 2023

mm-cloud-bot commented Feb 6, 2023

	it('MM-TXXX_1 Show and restore older versions of a message', () => {
	it('MM-T5381_1 Show and restore older versions of a message', () => {

	it('MM-TXXX_2 Show, restore older versions of a message and click undo in toast', () => {
	it('MM-T5381_2 Show, restore older versions of a message and click undo in toast', () => {

	it('MM-TXXX_3 Edit history should not be available when user lacks edit own posts permissions', () => {
	it('MM-T5381_3 Edit history should not be available when user lacks edit own posts permissions', () => {

MM-45494: Edit message history #11555

MM-45494: Edit message history #11555

Conversation

AshishDhama commented Nov 7, 2022

Summary

Ticket Link

Related Pull Requests

Screenshots

Release Note

AshishDhama commented Jan 30, 2023

mattermost-build commented Jan 30, 2023

AshishDhama commented Feb 2, 2023

mattermost-build commented Feb 2, 2023

AshishDhama commented Feb 2, 2023

jgilliam17 commented Feb 2, 2023

mattermost-build commented Feb 2, 2023

jgilliam17 commented Feb 2, 2023

sinansonmez commented Feb 2, 2023 • edited Loading

jgilliam17 commented Feb 2, 2023

sinansonmez commented Feb 2, 2023

jgilliam17 left a comment

Choose a reason for hiding this comment

jgilliam17 Feb 2, 2023

Choose a reason for hiding this comment

jgilliam17 Feb 2, 2023

Choose a reason for hiding this comment

jgilliam17 Feb 2, 2023

Choose a reason for hiding this comment

AshishDhama commented Feb 6, 2023

mm-cloud-bot commented Feb 6, 2023

mm-cloud-bot commented Feb 6, 2023

sinansonmez commented Feb 2, 2023 •

edited

Loading