This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Converted jquery.dragster.js from jquery plugin to vanilla js #3646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
added
2: Dev Review
saturninoabril
suggested changes
Sep 12, 2019
There was a problem hiding this comment.
Thanks @niklabh! It works great. See comments for other request.
|
Also, this fails on existing test |
jespino
reviewed
Sep 12, 2019
jespino
reviewed
Sep 12, 2019
jespino
reviewed
Sep 12, 2019
jespino
suggested changes
Sep 12, 2019
There was a problem hiding this comment.
Small changes needed, but in general looks good to me (besides the @saturninoabril comments).
Tests passing on local. |
|
Removed target.off jquery function in last commit. Using removeEventListener from inside the lib using js closure. |
|
Doing querySelector instead of querySelectorAll inside the lib now. |
I can see it's failing. Curious, how do you run the test on local? |
niklabh
force-pushed
the
jquery-dragster-vanilla
branch
from
10d8be4
to
1fd2104
Compare
Passing now. |
saturninoabril
approved these changes
Sep 16, 2019
jespino
added
4: Reviews Complete
|
Merged! Thanks @niklabh! 🎉 |
amyblais
added
Changelog/Not Needed
jwilander
pushed a commit
that referenced
this pull request
Sep 24, 2019
* Converted jquery.dragster.js to vanilla js * fix test * removed jquery * unbinding events on unmount; not checking class before classList.add * added new test; fixed old test
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
…most#3646) * Converted jquery.dragster.js to vanilla js * fix test * removed jquery * unbinding events on unmount; not checking class before classList.add * added new test; fixed old test
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
…most#3646) * Converted jquery.dragster.js to vanilla js * fix test * removed jquery * unbinding events on unmount; not checking class before classList.add * added new test; fixed old test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converted jquery.dragster.js from jquery plugin to vanilla js
Ticket Link
Fixes: mattermost/mattermost#11429