MM-20078: Migrate 'components/admin_console/radio_setting.jsx' and associated tests to TypeScript

[allenl7]

Summary

Migrate 'components/admin_console/radio_setting.jsx' and associated tests to TypeScript

Ticket Link

https://mattermost.atlassian.net/browse/MM-20078

[lindy65]

Thanks @allenlai18 👍

Would you be open to adding tests for your PR please?

[devinbinnie]

LGTM! Thanks @allenlai18!

[allenl7]

Thanks @allenlai18 👍

Would you be open to adding tests for your PR please?

@lindy65 Yes. I would be open. What test are you talking about though?

[lindy65]

Hi @allenlai18 :)

Thanks, In the title it mentions 'associated tests' so I'm not sure whether any unit tests existed already? If they do, then it would be converting them to TypeScript. If none exist, it would mean writing unit tests for this PR...

[jespino]

@allenlai18 you can base your tests in other similar files in the same directory, for example color_setting.test.tsx.

[allenl7]

Hi @allenlai18 :)

Thanks, In the title it mentions 'associated tests' so I'm not sure whether any unit tests existed already? If they do, then it would be converting them to TypeScript. If none exist, it would mean writing unit tests for this PR...

@lindy65 @jespino :) Gotcha, so there is exists a unit test for radio_setting.tsx but it's for the one in /widgets/settings/ . I migrated the one in admin_console. They both have the exact same component name and filename. Would it be better to rename them?

I will write unit test for admin_console RadioSetting

[lindy65]

Thanks @allenlai18, appreciated 👍

I'll defer to @jespino for your question on renaming...

[jespino]

I don't think so, one of the is a widget that is design to be generally used (but is only used in one place for now) and the other is scoped to the admin console, I think we can keep both as they are.

[jespino]

Now looks good to me. Thanks @allenlai18! 🎉

[allenl7]

Now looks good to me. Thanks @allenlai18! 🎉

@jespino I do not have much experience in writing unit test. please let me know if there are any suggestions or things that I could have done better!

--
it looks like its failling expect(received).toMatchSnapshot(). do i need to create a snapshot and push that?

[jespino]

@allenlai18 yes, you had to add it, thanks

[jespino]

Merged! thanks @allenlai18! 🎉