MM-27802 Cypress test for MM-T40 (1.0) Plugin remains enabled when upgraded #6294
Conversation
jfrerich
added
2: Dev Review
There was a problem hiding this comment.
Thank you so much @jfrerich for this test! The test is great! It also passes without fail but when the plugin is copied in the 'fixture' folder. So I've requested to add a comment to download and copy it in the required folder.
However, the test should go into a different folder from the one you've added to. I apologize for the confusion and I can see why that is. But this one is slightly different from the system console test. I think the rest of the plugin overwrite, enable, disable test etc. are in the Plugins folder in TM4J. Would you mind adding this test to the "Plugins" folder in cypress? It currently has a 'marketplace' subfolder, but I think it's fine to add a new spec file parallel to the marketplace subfolder.
Sorry about the long story, but please let me know if there is any confusion! (The other plugin tests in TM4J are missing from Cypress because I think they're automated in Selenium - the legacy automated test env).
Thank you Jason!
| @@ -108,6 +110,64 @@ describe('Draw Plugin - Upload', () => { | |||
| cy.findByText(/Installed Plugins/).scrollIntoView().should('be.visible'); | |||
| cy.findByTestId('com.mattermost.draw-plugin').should('not.exist'); | |||
| }); | |||
|
|
|||
| it('M27802-MT40-Plugin remains enabled when upgraded', () => { | |||
| // * upload Demo plugin from the browser | |||
There was a problem hiding this comment.
The test as written here will require the demo plugin to be copied into the 'fixture' folder inside cypress, instead of it getting downloaded from the browser. That will actually be fine as well; however, to note that please add a comment above this test to download both the plugin versions from https://github.com/mattermost/mattermost-plugin-demo/releases (or the direct link to the release bundles within that link). I will also update the test case to reflect that. Thank you!
There was a problem hiding this comment.
I added the notes to the top of the test spec. If you prefer it directly above the it() block, I can move it. If you need any additional changes, please let me know!
There was a problem hiding this comment.
|
@thanks for the extremely detailed response. I am modifying the PR now! |
There was a problem hiding this comment.
Thanks @jfrerich! Overall looks good, tested and passed, except for few suggestions.
|
Thanks for the feedback, @saturninoabril! I have addressed your PR change requests. I noticed in the cypress desktop I'm using version
|
|
Please ignore the updates. The next is major version 5.0 and there might be some breaking change in our tests. Also, others are seeing issues with 4.12.1 and so there's a PR to downgrade to 4.8.0 - #6304 |
There was a problem hiding this comment.
Thanks @jfrerich for updating. Last comments and I'm all good.
prapti
added
4: Reviews Complete
…graded (#6294) * test for plugin enabled after second upload * remove new test and revert to original. test was added to incorrect location * add new plugin upgrade test * update nits * remove v.0.2.0 demo plugin after test finishes * pass in filename to attachFile fuction as 'filename' parameter * remove the plugin with inside the "after" hook
Summary
Cypress test for MM-T40 Plugin remains enabled when upgraded
Test Case: MM-T40
Additional Notes
The code for this test case has some similarities to the previous test that exists in this file. The other tests uses the draw plugin and I chose to leave it as is and add the new test case for the following reasons.
Ticket Link
https://mattermost.atlassian.net/browse/MM-27802