Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

revert cypress to 4.8.0 #6304

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Conversation

Willyfrog
Copy link
Contributor

Summary

Downgrade cypress to 8.4.0 to have more stable tests

while trying to create this test i was running into many different problems as either it was taking longer to load some elements or it break while typing/waiting for no reason. Downgrading seems to get stable results.

@Willyfrog Willyfrog added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Aug 28, 2020
e2e/package.json Outdated Show resolved Hide resolved
Co-authored-by: Saturnino Abril <saturnino.abril@gmail.com>
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Willyfrog! Please change title and description to 4.8.0.

@Willyfrog Willyfrog changed the title revert cypress to 8.4.0 revert cypress to 4.8.0 Aug 28, 2020
@saturninoabril saturninoabril removed the 3: QA Review Requires review by a QA tester label Aug 28, 2020
@hmhealey hmhealey added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Aug 31, 2020
@hmhealey hmhealey merged commit 20964f7 into mattermost:master Aug 31, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Sep 6, 2020
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
* revert cypress to 8.4.0

* Update e2e/package.json

Co-authored-by: Saturnino Abril <saturnino.abril@gmail.com>

Co-authored-by: Saturnino Abril <saturnino.abril@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
4 participants