This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Migrate headerOverlay string ref to functional ones in channel_info_button.js #6661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nel_info_button.js
|
Hello @sowmiyamuthuraman, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
jasonblais
added
2: Dev Review
ashishbhate
approved these changes
Oct 7, 2020
hanzei
added
the
Setup Cloud Test Server
|
/update-branch |
jgilliam17
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
Thank you @sowmiyamuthuraman
Tested, looks good to merge.
- Verified/tested around channel info modal/channel info button in mobile view - as expected.
jgilliam17
added
4: Reviews Complete
|
Test server destroyed |
|
/update-branch |
|
Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour. |
|
Trying to auto merge this PR. |
|
Pull Request successfully merged |
amyblais
added
Changelog/Not Needed
jfrerich
pushed a commit
that referenced
this pull request
Oct 23, 2020
…utton.js (#6661) Automatic Merge
calebroseland
pushed a commit
that referenced
this pull request
Oct 27, 2020
…utton.js (#6661) Automatic Merge
This was referenced Sep 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mattermost/mattermost#15797 (comment)
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29308