Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Migrate 'components/announcement_bar/default_announcement_bar' module and associated tests to TypeScript #6963

Merged
merged 12 commits into from Nov 19, 2020
Merged

Migrate 'components/announcement_bar/default_announcement_bar' module and associated tests to TypeScript #6963

merged 12 commits into from Nov 19, 2020

Conversation

morganrconnolly
Copy link
Contributor

@morganrconnolly morganrconnolly commented Oct 29, 2020 •
edited by hanzei

Summary

Updates components/announcement_bar/default_announcement_bar/ to typsescript

Ticket Link

fixes mattermost/mattermost#16119

Related Pull Requests

  • Has server changes (please link here)
  • Has redux changes (please link here)
  • Has mobile changes (please link here)

Screenshots

@mattermod
Copy link
Contributor

Hello @morganrconnolly,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@hanzei hanzei added the Work in Progress Not yet ready for review label Oct 30, 2020
@hanzei
Copy link
Contributor

hanzei commented Oct 30, 2020

Hey @morganrconnolly,

Thanks for raising this PR 👍 CI complains about a couple of linter issues. Could you please take a look? You can find the log here.

@morganrconnolly
Copy link
Contributor Author

@hanzei I fixed the linter errors. Thanks for letting me know what needed to happen next! C:

@hanzei
Copy link
Contributor

hanzei commented Nov 3, 2020

Thanks @morganrconnolly! Could you please run npm run updatesnapshot to let the tests pass?

@morganrconnolly
Copy link
Contributor Author

@hanzei done C:

@hanzei hanzei added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester and removed Work in Progress Not yet ready for review labels Nov 4, 2020
@hanzei
Copy link
Contributor

hanzei commented Nov 4, 2020

@morganrconnolly Awesome! Queued your PR for review

@hahmadia
Copy link
Contributor

hahmadia commented Nov 4, 2020

/update-branch

@hahmadia hahmadia changed the title Migrate announcement bar to ts Migrate 'components/announcement_bar/default_announcement_bar' module and associated tests to TypeScript Nov 4, 2020
hahmadia
hahmadia suggested changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@hahmadia hahmadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions. Thanks!

components/announcement_bar/default_announcement_bar/announcement_bar.tsx Outdated Show resolved Hide resolved
components/announcement_bar/default_announcement_bar/announcement_bar.tsx Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@mattermod
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

@morganrconnolly
Copy link
Contributor Author

@hanzei incorporated your feedback !

@hahmadia hahmadia removed the 2: Dev Review Requires review by a core commiter label Nov 18, 2020
@hanzei hanzei added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Nov 19, 2020
saturninoabril
saturninoabril approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @morganrconnolly for your contribution! LGTM, tested and passed.

@saturninoabril saturninoabril added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Nov 19, 2020
@mm-cloud-bot
Copy link

Test server destroyed

@saturninoabril saturninoabril merged commit 2e2a84d into mattermost:master Nov 19, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@saturninoabril saturninoabril saturninoabril approved these changes

@nevyangelova nevyangelova nevyangelova approved these changes

@hahmadia hahmadia hahmadia approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
8 participants
@morganrconnolly @mattermod @hanzei @hahmadia @mm-cloud-bot @saturninoabril @nevyangelova @amyblais