This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-34366 Wip: Migrate 'components/post_view/post_list_virtualized' and associated tests to TypeScript #8344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fork sync
Syncronize fork
…cript add type definitions for 'dynamic-virtualized-list` package.
…cript Refactor tests in `post_list_virtualized.test.jsx` for PostList component.
|
@naftalimurgor: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. I understand the commands that are listed here |
|
Hello @naftalimurgor, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
mattermod
added
2: Dev Review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is work in progress for this issue: mattermost/mattermost#17289 which is migration of
post_list_virtualized.jsxand related tests to TypeScript. This is a work in progress. This pr makes type definitions available fordynamic-size-listcomponent. See related issue here mattermost/dynamic-virtualized-list#22for
dynamic-size-listcomponent which is used inPostListcomponent.Ticket Link
JIRA: https://mattermost.atlassian.net/browse/MM-34366
This is one of more pull requests to come.
This pull request provides type definitions for component used in
PostListcomponentRelated Pull Requests