MM-16114 Preventing plugin startup failure if bot account already exists as regular user. #11077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crspeller
added
2: Dev Review
|
So, no in-MM messages? I really don't mean to make work for you... But:
|
|
@cpoile Ya. We figured the value of those where low and there isn't a good system admin notification mechanism. Part of this change is the plugin won't fail to start https://github.com/mattermost/mattermost-server/pull/11077/files#diff-7c191d59bfe26e51b1828e40ccfc46f8R52 it will just start using the account even though it's not a bot. The plan is to improve this for 5.14 to better encourage migration to bot accounts. |
cpoile
approved these changes
Jun 8, 2019
crspeller
added a commit
that referenced
this pull request
Jun 10, 2019
crspeller
added
CherryPick/Done
hanzei
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
Wipeout55
pushed a commit
to Wipeout55/mattermost-server
that referenced
this pull request
Jun 11, 2019
hanzei
added a commit
to mattermost/mattermost-plugin-zoom
that referenced
this pull request
Jun 13, 2019
hanzei
added a commit
to mattermost/mattermost-plugin-zoom
that referenced
this pull request
Jun 13, 2019
crspeller
pushed a commit
to mattermost/mattermost-plugin-zoom
that referenced
this pull request
Jun 13, 2019
* Refactor zoom package * Update dependency for mattermost/mattermost#11077
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows the plugin to takeover a regular user account with EnsureBot while logging an error letting the admin know what happened.