license, openGraph tests: convert to testify #12919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/check-cla |
hanzei
added
2: Dev Review
hanzei
requested changes
Oct 25, 2019
hanzei
approved these changes
Oct 26, 2019
| @@ -4,6 +4,8 @@ import ( | |||
| "net/http" | |||
| "testing" | |||
|
|
|||
| "github.com/stretchr/testify/require" | |||
|
|
|||
| } | ||
| _, err := Client.DoApiGet("/license/client", "") | ||
| require.Error(t, err, "get /license/client did not return an error") | ||
| require.Equal(t, err.StatusCode, http.StatusNotImplemented, |
There was a problem hiding this comment.
Nit: you can combine these lines.
| } | ||
| _, err = Client.DoApiGet("/license/client?format=junk", "") | ||
| require.Error(t, err, "get /license/client?format=junk did not return an error") | ||
| require.Equal(t, err.StatusCode, http.StatusBadRequest, |
There was a problem hiding this comment.
Nit: you can combine these lines.
ghost
requested review from
devinbinnie and
imisshtml
and removed request for
a team
|
Rebasing branch on latest upstream master (caused 4 removed commits, so force pushed to keep the merge log clean) |
hanzei
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
jozuenoon
pushed a commit
to jozuenoon/mattermost-server
that referenced
this pull request
Nov 2, 2019
* master: (70 commits) Run unused against codebase (mattermost#12968) [MM-12623] Create CLI command "config reset" (mattermost#10296) Migrate tests from store/storetest/status_store.go to use test… (mattermost#12873) Fix golangci-lint target (mattermost#12985) [MM-16437] Plugin crashes the server when calling WriteHeader with an invalid http code (mattermost#11276) MM-18060: Include deleted posts in compliance export. (mattermost#12957) [MM-18331] When patching a bot send websocket notification (mattermost#12373) [MM-19473] Fix data race on user login (mattermost#12870) license, openGraph tests: convert to testify (mattermost#12919) oauth_test: use testify (mattermost#12949) [MM-18830] Unhelpful error message when adding bot to a channel before adding to team (mattermost#12844) emoji_test: update to use testify (mattermost#12932) MM-19310 - Wrong validation message when Bot name ends in a . (mattermost#12905) Migrate tests from store/storetest/oauth_store.go to use testify (mattermost#12875) Include extra metadata when clicking an interactive button (mattermost#12697) MM-19553: Generate valid passwords on bulk import. (mattermost#12871) Convert api4/webhook_test.go t.Fatal calls into require/assert calls (mattermost#12904) Fix golangci-lint target for non GOPATH installations (mattermost#12934) MM-17888 Check plugin Helpers minimum server version comments (mattermost#12663) [MM-18898] Stringify plugin.Log* parameters (mattermost#12700) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update
api4/license_test.goandapi4/openGraph_test.goto usetestify.Ticket Link
Fixes #12860
MM-19625