Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emoji_test: update to use testify #12932

Merged
merged 2 commits into from
Oct 31, 2019
Merged

emoji_test: update to use testify #12932

merged 2 commits into from
Oct 31, 2019

Conversation

drekar
Copy link
Contributor

@drekar drekar commented Oct 26, 2019 •
edited

Summary

Update api4/emoji_test.go to use testify.

Ticket Link

Fixes #12861
MM-19624

@hanzei hanzei added 2: Dev Review Requires review by a developer Tests/Not Needed New release tests not required labels Oct 26, 2019
@hanzei hanzei requested a review from a team October 26, 2019 08:14
@ghost ghost requested review from iomodo and removed request for a team October 26, 2019 08:14
iomodo
iomodo suggested changes Oct 26, 2019
View reviewed changes
Copy link
Contributor

@iomodo iomodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Couple of minor improvements below.
One other thing, there are some assert.True and assert.Equal in the code. I'm 0/5 whether we should change them to require or not.

api4/emoji_test.go Outdated Show resolved Hide resolved
api4/emoji_test.go Show resolved Hide resolved
@hanzei hanzei marked this pull request as ready for review October 26, 2019 18:55
@hanzei hanzei added this to the v5.18.0 milestone Oct 26, 2019
@drekar
Copy link
Contributor Author

drekar commented Oct 29, 2019

Rebased off upstream master.

@drekar drekar requested a review from iomodo October 30, 2019 12:31
@drekar
Copy link
Contributor Author

drekar commented Oct 30, 2019 •
edited

One other thing, there are some assert.True and assert.Equal in the code. I'm 0/5 whether we should change them to require or not.

Thanks @iomodo ; I am also a fan of replacing assert statements with require. The moment than an expected condition is not met, the underlying state machine is in an unknown position, and thus subsequent tests can not be trusted. "Fail Fast and Fail Often", or so the aphorism goes.

However, I am receiving suggestions to go the other way on other PRs, which is likely a pragmatic approach of displaying as many problems in one test-run as possible to save time at the expense of strict correctness, which is a position I fully understand. So for now, I suppose I'll leave things as-is due to ambiguity :)

mgdelacroix
mgdelacroix approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@mgdelacroix mgdelacroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @drekar!

iomodo
iomodo approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@iomodo iomodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @drekar

@iomodo iomodo added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Oct 31, 2019
@iomodo iomodo merged commit df0bb8a into mattermost:master Oct 31, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 31, 2019
jozuenoon pushed a commit to jozuenoon/mattermost-server that referenced this pull request Nov 2, 2019
Merge branch 'master' into MM-19355
88660d0 
* master: (70 commits)
  Run unused against codebase (mattermost#12968)
  [MM-12623] Create CLI command "config reset" (mattermost#10296)
  Migrate tests from store/storetest/status_store.go to use test… (mattermost#12873)
  Fix golangci-lint target (mattermost#12985)
  [MM-16437] Plugin crashes the server when calling WriteHeader with an invalid http code (mattermost#11276)
  MM-18060: Include deleted posts in compliance export. (mattermost#12957)
  [MM-18331] When patching a bot send websocket notification (mattermost#12373)
  [MM-19473] Fix data race on user login (mattermost#12870)
  license, openGraph tests: convert to testify (mattermost#12919)
  oauth_test: use testify (mattermost#12949)
  [MM-18830] Unhelpful error message when adding bot to a channel before adding to team (mattermost#12844)
  emoji_test: update to use testify (mattermost#12932)
  MM-19310 - Wrong validation message when Bot name ends in a . (mattermost#12905)
  Migrate tests from store/storetest/oauth_store.go to use testify (mattermost#12875)
  Include extra metadata when clicking an interactive button (mattermost#12697)
  MM-19553: Generate valid passwords on bulk import. (mattermost#12871)
  Convert api4/webhook_test.go t.Fatal calls into require/assert calls (mattermost#12904)
  Fix golangci-lint target for non GOPATH installations (mattermost#12934)
  MM-17888 Check plugin Helpers minimum server version comments (mattermost#12663)
  [MM-18898] Stringify plugin.Log* parameters (mattermost#12700)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgdelacroix mgdelacroix mgdelacroix approved these changes

@iomodo iomodo iomodo approved these changes

Assignees

@mgdelacroix mgdelacroix

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Hacktoberfest Tests/Not Needed New release tests not required
Projects
None yet
Milestone
v5.18.0
Development

Successfully merging this pull request may close these issues.

Migrate tests from "api4/emoji_test.go" to use testify
6 participants
@drekar @mgdelacroix @iomodo @mattermod @hanzei @amyblais