Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-42267: Update browse channel UI #23532

Merged
merged 75 commits into from Jun 15, 2023

Conversation

sinansonmez
Copy link
Collaborator

Summary

UI update for browse channel model.

Ticket Link

Fixes #21173
JIRA: https://mattermost.atlassian.net/browse/MM-42267

Screenshots

before after
Screen Shot 2023-05-29 at 18 01 29 Screen Shot 2023-05-29 at 16 43 00

Release Note

Updated UI for browse channel modal

@mm-cloud-bot mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 29, 2023
@mattermost-build
Copy link
Contributor

Hello @sinansonmez,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@sinansonmez sinansonmez added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels May 29, 2023
@mattermost-build
Copy link
Contributor

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

@sinansonmez
Copy link
Collaborator Author

As agreed with @hmhealey I have removed the member count from the modal as the current API to get info for each channel is quite heavy task.

@matthewbirtch One question. As we have removed the member count, do we still need to show a small dot before channel description in the channels that we are not member (as an example, ut or veritatis channels in the before screenshot)?

@esethna
Copy link
Contributor

esethna commented May 29, 2023

Thanks @sinansonmez! Agree with removing the dot if there's nothing infront of it

@matthewbirtch matthewbirtch added the Setup Cloud Test Server Setup an on-prem test server label May 29, 2023
@matthewbirtch
Copy link
Contributor

matthewbirtch commented May 29, 2023

As agreed with @hmhealey I have removed the member count from the modal as the current API to get info for each channel is quite heavy task.

@matthewbirtch One question. As we have removed the member count, do we still need to show a small dot before channel description in the channels that we are not member (as an example, ut or veritatis channels in the before screenshot)?

Yep, makes sense to remove the dot in this case if we're no longer showing the member count. I wasn't aware that we needed to do that, but if there are performance implications then so be it.

@sinansonmez
Copy link
Collaborator Author

/update-branch

@sinansonmez
Copy link
Collaborator Author

As agreed with @hmhealey I have removed the member count from the modal as the current API to get info for each channel is quite heavy task.
@matthewbirtch One question. As we have removed the member count, do we still need to show a small dot before channel description in the channels that we are not member (as an example, ut or veritatis channels in the before screenshot)?

Yep, makes sense to remove the dot in this case if we're no longer showing the member count. I wasn't aware that we needed to do that, but if there are performance implications then so be it.

@matthewbirtch @esethna dot is removed if there is nothing before it

image

@sinansonmez
Copy link
Collaborator Author

/e2e-tests

@mattermost-build
Copy link
Contributor

You don't have permissions to trigger this command.
It's only available for organization members.

@sinansonmez sinansonmez changed the title MM-42267: update browse channel MM-42267: Update browse channel UI May 29, 2023
@sinansonmez
Copy link
Collaborator Author

@esethna can you request review from developers? As there were some internal changes in MM, I dont who should review this?

@matthewbirtch matthewbirtch removed the Setup Cloud Test Server Setup an on-prem test server label Jun 1, 2023
Copy link
Contributor

@matthewbirtch matthewbirtch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good @sinansonmez! Thank you!

@M-ZubairAhmed
Copy link
Member

/update-branch

@M-ZubairAhmed
Copy link
Member

/e2e-test

@mattermost-build
Copy link
Contributor

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

@mm-cloud-bot
Copy link

New commit detected. SpinWick will upgrade if the updated docker image is available.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0/5 but shouldn't this essentially called browser_channels_modal cc @hmhealey I know that would create a big diff, but being clear in naming is always a good fallback

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0/5 to me as well

Copy link
Member

@hmhealey hmhealey Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave it as-is for now since this PR's pretty big. We could do a followup once this is in though to rename it to BrowseChannelsModal since you make a good point that it's not clear right now.

Historically, the modal was titled More Channels, but that's obviously changed since then. It's also less clear than some of our other historical names like the System Console being AdminConsole which is less ambiguous than MoreChannels

Copy link
Member

@hmhealey hmhealey Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, "More Channels" is the current title of that modal on master. I didn't realize it stayed that way even when we renamed the menu item to "Browse Channels". I guess I had just assumed they matched, and now I feel dumb for explaining the current state of it like it was some ancient MM trivia 😛

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome make sense @sinansonmez would you mind opening a follow up PR after we merge this on on the name change ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sure

@mm-cloud-bot
Copy link

Test server creation failed. See the logs for more information.

return (
<Modal
dialogClassName='a11y__modal more-modal more-modal--action'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad to see that we're getting rid of the original usage of more-modal. That's one of those overused classes in MM that makes working with our CSS styling difficult, so this'll definitely help to get rid of that eventually

}
}

// SearchableChannelList.defaultProps = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really hoped since this was a new component we could have written this in functional way but it's fine either ways. Also do you plan to remove this ?

@M-ZubairAhmed M-ZubairAhmed removed the 2: Dev Review Requires review by a developer label Jun 14, 2023
@saturninoabril
Copy link
Member

/e2e-test

@mattermost-build
Copy link
Contributor

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@sinansonmez
Copy link
Collaborator Author

@M-ZubairAhmed i think this is ready to merge

@sinansonmez sinansonmez removed the 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review label Jun 14, 2023
@hmhealey hmhealey added the 4: Reviews Complete All reviewers have approved the pull request label Jun 15, 2023
@hmhealey hmhealey merged commit 10cf522 into mattermost:master Jun 15, 2023
14 checks passed
@mattermost-build mattermost-build removed the Setup Cloud Test Server Setup an on-prem test server label Jun 15, 2023
@mm-cloud-bot
Copy link

Test server destroyed

@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Jun 15, 2023
ilies-bel pushed a commit to ilies-bel/mattermost that referenced this pull request Jun 26, 2023
* update more_channels for ui and show all channels

* update searchable channel list

* fix style

* fix tests

* fix style for delete icon

* fix failing tests

* fix style

* remove dot

* remove header button

* put back header button

* Fix duplicate keys in CombinedSystemMessage component (mattermost#23507)

* MM-52873 : Switch to npm's 'reselect' for Playbooks (mattermost#23396)

* Enable golangci-lint (attempt 2) (mattermost#23517)


This time we are just using the Makefile command
to see if that makes a difference
```release-note
NONE
```

* MM-52888 Always load users mentioned in message attachments (mattermost#23460)

Co-authored-by: Mattermost Build <build@mattermost.com>

* Prepare: run E2E smoketests with GitHub actions (mattermost#23301)

- Port E2E testing scripts from cypress-ui-automation
- Move server to docker-compose, move E2E images to ecrpublic
* Integrate General channel renaming, fixes
- Add local automation-dashboard
- Add readme
- Add E2E smoketests
- Bump postgres to 12

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
Co-authored-by: Saturnino Abril <saturnino.abril@gmail.com>
Co-authored-by: Antonis Stamatiou <stamatiou.antonis@gmail.com>

* MM-47064/MM-34345/MM-47072 Remove inheritance from Suggestion components and migrate to TS (mattermost#23455)

* MM-47064 Remove inheritance from Suggestion components

* Address feedback

* Fix users without DM channels not appearing in the channel switcher

---------

Co-authored-by: Mattermost Build <build@mattermost.com>

* MM-52544 Fix missing reply bar mention highlight (mattermost#23534)

* MM-52513: fixes deleting a reply (mattermost#23177)

* MM-52513: fixes deleting a reply

Currently when we receive a WS event for a reply being deleted we might
accidentally push it to a wrong team's store. This might happen if the
thread is already loaded in store and we are viewing another team.
In that case we were fetching the thread from the API using the team id
of the current team. The API returns the thread, even though the team id
is not the one which the thread belongs to.

This commit is fixing the above issue by getting the team id in which
the thread belongs to, or current team id in the case of DM/GM messages,
and using that to fetch the thread from the API.

PS: the fetching is needed since we don't send a thread_update WS event
upon deleting a reply, and we need to get the new participants list.

* Fixes team id on another occasion

* Refactors a bit

* Reverts returning empty string as team id

* Refactor a bit to pass the post as argument

---------

Co-authored-by: Kyriakos Ziakoulis <koox00@Kyriakoss-MacBook-Pro.local>
Co-authored-by: Kyriakos Ziakoulis <koox00@192.168.2.3>
Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com>

* Avoid calling the user count query in future if we get a count > 0 (mattermost#23545)

* Avoid calling the user count query in future if we get a count > 0

* re-adding mock session to avoid adding the old mitigation in future

* adjustments based on feedback

* MM-52365 - fix JS error banner (mattermost#23501)

* MM-52365 - fix js error banner

* add null type to bindings as an optional type

* Make used of typed atomic.Pointer (mattermost#23550)

* Make save_post_spec less affected by other E2E tests (mattermost#23541)

* Revert "Prepare: run E2E smoketests with GitHub actions (mattermost#23301)" (mattermost#23553)

This reverts commit 68be3a6.

* adding debug log when executing query (mattermost#23559)

* server/docker-compose.yml: updates to run HA in local after monorepo (mattermost#23552)

* [MM-52919] Remove all uses of window.desktop.version from webapp (mattermost#23558)

Co-authored-by: Mattermost Build <build@mattermost.com>

* [MM-21096] webapp: Migrate "components/suggestion/search_channel_with_permissions_provider.jsx" to Typescript (mattermost#23323)

* migrate to ts

* linting

* fix test

* refactor

* Remove accidental comments from merge

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com>

* fix server ci after renaming the project (mattermost#23576)

* Temporarily let AdvancedLoggingConfig take precedence over AdvancedLoggingJSON (mattermost#23578)

* Temporarily let AdvancedLoggingConfig take precedence over AdvancedLoggingJSON

* Repo name ci fixes (mattermost#23569)

* mattermost-server -> mattermost

* mattermost-server -> mattermost

* Empty-Commit

* Empty-Commit

* Empty-Commit

---------

Co-authored-by: Antonis Stamatiou <stamatiou.antonis@gmail.com>
Co-authored-by: Mattermost Build <build@mattermost.com>
Co-authored-by: Akis Maziotis <akis.maziotis@mattermost.com>

* MM-51585 : Fix duplicated date separator in center channel when Pinned posts RHS is open (mattermost#23068)

* Fix references from 'packages/*' to 'platform/*' in READMEs (mattermost#23498)

* [MM-52541] Mark files as deleted along with thread (mattermost#23226)

* mark thread files as deleted

* add missing check

* improve query

* Stopped rendering post preview if post is deleted

* Fixed lint error

* Fixed test

* updated types

* Removed deleted post from other post's embed data

* Added tests

* Apply suggestions from code review

Co-authored-by: Daniel Espino García <larkox@gmail.com>

* lint fix

---------

Co-authored-by: Konstantinos Pittas <konstantinos.pittas@mattermost.com>
Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com>
Co-authored-by: Mattermost Build <build@mattermost.com>
Co-authored-by: Harshil Sharma <18575143+harshilsharma63@users.noreply.github.com>
Co-authored-by: Daniel Espino García <larkox@gmail.com>

* MM-52476 Fix guest users access to playbooks. (mattermost#23279)

* Fix guest users access to playbooks.

* Fix guest access.

* Add guests list restriction.

* Update PULL_REQUEST_TEMPLATE.md to include Jira ticket for contributors (mattermost#23589)

* [MM-52836] : Migrate "components/admin_console/admin_definition_constants.jsx" to TypeScript (mattermost#23566)

* MM-52297 Fix reactions disappearing with search open and add testing utilities (mattermost#23510)

* MM-52297 Fix reactions disappearing when search is open

* Add unit tests and extra utilities

* Fix typing issue

* MM-53002: Fix ESR CI (mattermost#23599)

* Do not use the mattermost path

The /mattermost path is used by the image and it seems to conflict with
the container running the binary

* Use a regular machine in the esr-upgrade-diff job

* Add missing space

* [MM-52955] Fix panic for not found posts (mattermost#23561)

* [MM-52973] Avoid thundering herd problem in IsFirstUserAccount (mattermost#23549)

* [MM-45802] Clear CRT notification on deleted reply (mattermost#23568)

* reduce the counter on post deletion

* add test

* change translations

* fix collecting mentions for DMs

* add translation texts

* extract logic for getting mentions

* send WS event

* add e2e tests

* tidy mod

* WIP

* Deleting notification async

* Fixed a unit test

* Added more tests

* Updated i18n

* CI

* mattermost-server -> mattermost

* mattermost-server -> mattermost

---------

Co-authored-by: Konstantinos Pittas <konstantinos.pittas@mattermost.com>
Co-authored-by: Mattermost Build <build@mattermost.com>

* Includes mmctl into the mono-repo (mattermost#23091)

* Includes mmctl into the mono-repo

* Update to use the new public module paths

* Adds docs check to the mmctl CI

* Fix public utils import path

* Tidy up modules

* Fix linter

* Update CI tasks to use the new file structure

* Update CI references

* [MM-30432]: Allow users to specify different desktop notification sounds per channel (mattermost#21671)

* [MM-44165]: When Help link is left blank Help Resources option should not be visible in the help menu (mattermost#23609)

* Clean up at .github due to repo rename (mattermost#23580)

* update .github after repo rename

* update

* Update PULL_REQUEST_TEMPLATE.md

---------

Co-authored-by: M-ZubairAhmed <m-zubairahmed@protonmail.com>
Co-authored-by: Mattermost Build <build@mattermost.com>

* MM-52819 : "medical_symbol", "male_sign" and "female_sign" emojis are broken (mattermost#23538)

* [MM-52979]: Remove code around abandoned MUI modal migration (mattermost#23556)

* Re-export all React Testing Library functions (mattermost#23522)

* Fix panic if JSON null value is passed as channel update (mattermost#23629)

* MM-52818 - create config setting to enable/disable playbooks product (mattermost#23508)

* create config setting to enable/disable playbooks product

* fix to config name

* fix typo

* revert changes to package-lock.json

* update name of test

---------

Co-authored-by: Mattermost Build <build@mattermost.com>

* [MM-52926] Deprecating work templates (mattermost#23466)

Co-authored-by: Mattermost Build <build@mattermost.com>

* [MM-52839]: Migrate "components/admin_console/remove_file_setting.jsx" to Typescript (mattermost#23565)

* [MM-52833]: Migrate "components/admin_console/multiselect_settings.jsx" to Typescript (mattermost#23542)

* [MM-52835]: Migrate "components/admin_console/settings_group.jsx" and tests to Typescript (mattermost#23563)

* fix typo in index name for idx_teammembers_create_at (mattermost#23632)

* [MM-49989] Pass a context.Context to Client4 methods (mattermost#22922)

* Migrate all method in model/client4.go to accept a context.Context

* Fix th.*Client

* Fix remaining issues

* Empty commit to triger CI

* Fix test

* Add cancellation test

* Test that returned error is context.Canceled

* Fix bad merge

* Update mmctl code

---------

Co-authored-by: Mattermost Build <build@mattermost.com>

* Service environment (mattermost#23443)

* fix fileutils.TestFindFile on MacOS

* introduce model.ExternalServiceEnvironment

* pick license public key from external service env

* pick Stripe public key from external service env

* pick Rudder key from external service env

* configure Sentry DSN from external service env

* always log external_service_environment, Unsetenv

* clear faked BuildEnv, improve logging

* strip out unset GOTAGS

* fix Sentry tests

* simplify to just ServiceEnvironment

* relocate ServiceEnvironment in client config

* initialize CWS URLs based on service environment

* unset rudder key for boards dev

* harden service environment to avoid accidental production

* fix TestSentry again

* fix DEFAULT -> ENTERPRISE

* s/dev/test when naming playbooks rudder key

* simplify boards rudder key switch

* use uniform rudderKey variable names

* retain compatibility with existing pipeline

* reduce to just production/test

* unit test with valid test license

* simplify Playbooks telemetry initialization

* restore dev service environment

* emit ServiceEnvironment when running e2e tests

* [MM 22957] webapp a11y: fix sso btns focus issue (mattermost#23326)

* make suggested changes

* added form tag and removed event handler

* fix snapshot

---------

Co-authored-by: Mattermost Build <build@mattermost.com>

* Upgrade docker CI image to 23.0.1 (mattermost#23664)

Automatic Merge

* MM-52995: Fix opening DM/GM thread from thread footer (mattermost#23579)

* MM-52487: fix more playbooks tests (mattermost#23475)

* fix playbooks/channels/rhs/template_spec.js

* fix playbooks/channels/update_request_post_spec.js

* fix playbooks/runs/rdp_rhs_runinfo_spec.js

* fix playbooks/runs/rdp_rhs_statusupdates_spec.js

* remove enableexperimentalfeatures flag in e2e tests

* rdp_main_header_spec: simplify channel loaded assertion

* playbooks rhs participants: fix infinite fetch loop

* improved onboarding skipping

* simplify participants fetching

* Support json.RawMessage in configuration env overrides (mattermost#23610)

* support json.RawMessage in env overrides

* update more_channels for ui and show all channels

* remove header button

* put back header button

* [MM-52979]: Remove code around abandoned MUI modal migration (mattermost#23556)

* fix import

* update snapshot

* Update e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/accessibility_modals_dialogs_spec.js

* fix e2e tests

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com>
Co-authored-by: M-ZubairAhmed <m-zubairahmed@protonmail.com>
Co-authored-by: Agniva De Sarker <agnivade@yahoo.co.in>
Co-authored-by: mvitale1989 <mvitale1989@hotmail.com>
Co-authored-by: Saturnino Abril <saturnino.abril@gmail.com>
Co-authored-by: Antonis Stamatiou <stamatiou.antonis@gmail.com>
Co-authored-by: Kyriakos Z <3829551+koox00@users.noreply.github.com>
Co-authored-by: Kyriakos Ziakoulis <koox00@Kyriakoss-MacBook-Pro.local>
Co-authored-by: Kyriakos Ziakoulis <koox00@192.168.2.3>
Co-authored-by: Ben Cooke <benkcooke@gmail.com>
Co-authored-by: Pablo Andrés Vélez Vidal <pablovv2012@gmail.com>
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>
Co-authored-by: Devin Binnie <52460000+devinbinnie@users.noreply.github.com>
Co-authored-by: Sai Deepesh <saideepesh000@gmail.com>
Co-authored-by: Doug Lauder <wiggin77@warpmail.net>
Co-authored-by: Harshil Sharma <18575143+harshilsharma63@users.noreply.github.com>
Co-authored-by: Akis Maziotis <akis.maziotis@mattermost.com>
Co-authored-by: Hideaki Matsunami <mahaker@users.noreply.github.com>
Co-authored-by: Konstantinos Pittas <konstantinos.pittas+github@gmail.com>
Co-authored-by: Konstantinos Pittas <konstantinos.pittas@mattermost.com>
Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com>
Co-authored-by: Daniel Espino García <larkox@gmail.com>
Co-authored-by: Christopher Speller <crspeller@gmail.com>
Co-authored-by: Tejas Karelia <tejas.karelia17@gmail.com>
Co-authored-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>
Co-authored-by: KyeongSoo Kim <gaganso71@korea.ac.kr>
Co-authored-by: Matheus <20505926+MattSilvaa@users.noreply.github.com>
Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
Co-authored-by: Julien Tant <785518+JulienTant@users.noreply.github.com>
Co-authored-by: Karan Mishra <karan.m2704@gmail.com>
Co-authored-by: Judy Hanson <106325339+Esterjudith@users.noreply.github.com>
Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com>
Co-authored-by: Caleb Roseland <caleb@calebroseland.com>
sbishel added a commit to sbishel/mattermost that referenced this pull request Aug 15, 2023
* update more_channels for ui and show all channels

* update searchable channel list

* fix style

* fix tests

* fix style for delete icon

* fix failing tests

* fix style

* remove dot

* remove header button

* put back header button

* Fix duplicate keys in CombinedSystemMessage component (mattermost#23507)

* MM-52873 : Switch to npm's 'reselect' for Playbooks (mattermost#23396)

* Enable golangci-lint (attempt 2) (mattermost#23517)


This time we are just using the Makefile command
to see if that makes a difference
```release-note
NONE
```

* MM-52888 Always load users mentioned in message attachments (mattermost#23460)

Co-authored-by: Mattermost Build <build@mattermost.com>

* Prepare: run E2E smoketests with GitHub actions (mattermost#23301)

- Port E2E testing scripts from cypress-ui-automation
- Move server to docker-compose, move E2E images to ecrpublic
* Integrate General channel renaming, fixes
- Add local automation-dashboard
- Add readme
- Add E2E smoketests
- Bump postgres to 12

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
Co-authored-by: Saturnino Abril <saturnino.abril@gmail.com>
Co-authored-by: Antonis Stamatiou <stamatiou.antonis@gmail.com>

* MM-47064/MM-34345/MM-47072 Remove inheritance from Suggestion components and migrate to TS (mattermost#23455)

* MM-47064 Remove inheritance from Suggestion components

* Address feedback

* Fix users without DM channels not appearing in the channel switcher

---------

Co-authored-by: Mattermost Build <build@mattermost.com>

* MM-52544 Fix missing reply bar mention highlight (mattermost#23534)

* MM-52513: fixes deleting a reply (mattermost#23177)

* MM-52513: fixes deleting a reply

Currently when we receive a WS event for a reply being deleted we might
accidentally push it to a wrong team's store. This might happen if the
thread is already loaded in store and we are viewing another team.
In that case we were fetching the thread from the API using the team id
of the current team. The API returns the thread, even though the team id
is not the one which the thread belongs to.

This commit is fixing the above issue by getting the team id in which
the thread belongs to, or current team id in the case of DM/GM messages,
and using that to fetch the thread from the API.

PS: the fetching is needed since we don't send a thread_update WS event
upon deleting a reply, and we need to get the new participants list.

* Fixes team id on another occasion

* Refactors a bit

* Reverts returning empty string as team id

* Refactor a bit to pass the post as argument

---------

Co-authored-by: Kyriakos Ziakoulis <koox00@Kyriakoss-MacBook-Pro.local>
Co-authored-by: Kyriakos Ziakoulis <koox00@192.168.2.3>
Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com>

* Avoid calling the user count query in future if we get a count > 0 (mattermost#23545)

* Avoid calling the user count query in future if we get a count > 0

* re-adding mock session to avoid adding the old mitigation in future

* adjustments based on feedback

* MM-52365 - fix JS error banner (mattermost#23501)

* MM-52365 - fix js error banner

* add null type to bindings as an optional type

* Make used of typed atomic.Pointer (mattermost#23550)

* Make save_post_spec less affected by other E2E tests (mattermost#23541)

* Revert "Prepare: run E2E smoketests with GitHub actions (mattermost#23301)" (mattermost#23553)

This reverts commit 68be3a6.

* adding debug log when executing query (mattermost#23559)

* server/docker-compose.yml: updates to run HA in local after monorepo (mattermost#23552)

* [MM-52919] Remove all uses of window.desktop.version from webapp (mattermost#23558)

Co-authored-by: Mattermost Build <build@mattermost.com>

* [MM-21096] webapp: Migrate "components/suggestion/search_channel_with_permissions_provider.jsx" to Typescript (mattermost#23323)

* migrate to ts

* linting

* fix test

* refactor

* Remove accidental comments from merge

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com>

* fix server ci after renaming the project (mattermost#23576)

* Temporarily let AdvancedLoggingConfig take precedence over AdvancedLoggingJSON (mattermost#23578)

* Temporarily let AdvancedLoggingConfig take precedence over AdvancedLoggingJSON

* Repo name ci fixes (mattermost#23569)

* mattermost-server -> mattermost

* mattermost-server -> mattermost

* Empty-Commit

* Empty-Commit

* Empty-Commit

---------

Co-authored-by: Antonis Stamatiou <stamatiou.antonis@gmail.com>
Co-authored-by: Mattermost Build <build@mattermost.com>
Co-authored-by: Akis Maziotis <akis.maziotis@mattermost.com>

* MM-51585 : Fix duplicated date separator in center channel when Pinned posts RHS is open (mattermost#23068)

* Fix references from 'packages/*' to 'platform/*' in READMEs (mattermost#23498)

* [MM-52541] Mark files as deleted along with thread (mattermost#23226)

* mark thread files as deleted

* add missing check

* improve query

* Stopped rendering post preview if post is deleted

* Fixed lint error

* Fixed test

* updated types

* Removed deleted post from other post's embed data

* Added tests

* Apply suggestions from code review

Co-authored-by: Daniel Espino García <larkox@gmail.com>

* lint fix

---------

Co-authored-by: Konstantinos Pittas <konstantinos.pittas@mattermost.com>
Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com>
Co-authored-by: Mattermost Build <build@mattermost.com>
Co-authored-by: Harshil Sharma <18575143+harshilsharma63@users.noreply.github.com>
Co-authored-by: Daniel Espino García <larkox@gmail.com>

* MM-52476 Fix guest users access to playbooks. (mattermost#23279)

* Fix guest users access to playbooks.

* Fix guest access.

* Add guests list restriction.

* Update PULL_REQUEST_TEMPLATE.md to include Jira ticket for contributors (mattermost#23589)

* [MM-52836] : Migrate "components/admin_console/admin_definition_constants.jsx" to TypeScript (mattermost#23566)

* MM-52297 Fix reactions disappearing with search open and add testing utilities (mattermost#23510)

* MM-52297 Fix reactions disappearing when search is open

* Add unit tests and extra utilities

* Fix typing issue

* MM-53002: Fix ESR CI (mattermost#23599)

* Do not use the mattermost path

The /mattermost path is used by the image and it seems to conflict with
the container running the binary

* Use a regular machine in the esr-upgrade-diff job

* Add missing space

* [MM-52955] Fix panic for not found posts (mattermost#23561)

* [MM-52973] Avoid thundering herd problem in IsFirstUserAccount (mattermost#23549)

* [MM-45802] Clear CRT notification on deleted reply (mattermost#23568)

* reduce the counter on post deletion

* add test

* change translations

* fix collecting mentions for DMs

* add translation texts

* extract logic for getting mentions

* send WS event

* add e2e tests

* tidy mod

* WIP

* Deleting notification async

* Fixed a unit test

* Added more tests

* Updated i18n

* CI

* mattermost-server -> mattermost

* mattermost-server -> mattermost

---------

Co-authored-by: Konstantinos Pittas <konstantinos.pittas@mattermost.com>
Co-authored-by: Mattermost Build <build@mattermost.com>

* Includes mmctl into the mono-repo (mattermost#23091)

* Includes mmctl into the mono-repo

* Update to use the new public module paths

* Adds docs check to the mmctl CI

* Fix public utils import path

* Tidy up modules

* Fix linter

* Update CI tasks to use the new file structure

* Update CI references

* [MM-30432]: Allow users to specify different desktop notification sounds per channel (mattermost#21671)

* [MM-44165]: When Help link is left blank Help Resources option should not be visible in the help menu (mattermost#23609)

* Clean up at .github due to repo rename (mattermost#23580)

* update .github after repo rename

* update

* Update PULL_REQUEST_TEMPLATE.md

---------

Co-authored-by: M-ZubairAhmed <m-zubairahmed@protonmail.com>
Co-authored-by: Mattermost Build <build@mattermost.com>

* MM-52819 : "medical_symbol", "male_sign" and "female_sign" emojis are broken (mattermost#23538)

* [MM-52979]: Remove code around abandoned MUI modal migration (mattermost#23556)

* Re-export all React Testing Library functions (mattermost#23522)

* Fix panic if JSON null value is passed as channel update (mattermost#23629)

* MM-52818 - create config setting to enable/disable playbooks product (mattermost#23508)

* create config setting to enable/disable playbooks product

* fix to config name

* fix typo

* revert changes to package-lock.json

* update name of test

---------

Co-authored-by: Mattermost Build <build@mattermost.com>

* [MM-52926] Deprecating work templates (mattermost#23466)

Co-authored-by: Mattermost Build <build@mattermost.com>

* [MM-52839]: Migrate "components/admin_console/remove_file_setting.jsx" to Typescript (mattermost#23565)

* [MM-52833]: Migrate "components/admin_console/multiselect_settings.jsx" to Typescript (mattermost#23542)

* [MM-52835]: Migrate "components/admin_console/settings_group.jsx" and tests to Typescript (mattermost#23563)

* fix typo in index name for idx_teammembers_create_at (mattermost#23632)

* [MM-49989] Pass a context.Context to Client4 methods (mattermost#22922)

* Migrate all method in model/client4.go to accept a context.Context

* Fix th.*Client

* Fix remaining issues

* Empty commit to triger CI

* Fix test

* Add cancellation test

* Test that returned error is context.Canceled

* Fix bad merge

* Update mmctl code

---------

Co-authored-by: Mattermost Build <build@mattermost.com>

* Service environment (mattermost#23443)

* fix fileutils.TestFindFile on MacOS

* introduce model.ExternalServiceEnvironment

* pick license public key from external service env

* pick Stripe public key from external service env

* pick Rudder key from external service env

* configure Sentry DSN from external service env

* always log external_service_environment, Unsetenv

* clear faked BuildEnv, improve logging

* strip out unset GOTAGS

* fix Sentry tests

* simplify to just ServiceEnvironment

* relocate ServiceEnvironment in client config

* initialize CWS URLs based on service environment

* unset rudder key for boards dev

* harden service environment to avoid accidental production

* fix TestSentry again

* fix DEFAULT -> ENTERPRISE

* s/dev/test when naming playbooks rudder key

* simplify boards rudder key switch

* use uniform rudderKey variable names

* retain compatibility with existing pipeline

* reduce to just production/test

* unit test with valid test license

* simplify Playbooks telemetry initialization

* restore dev service environment

* emit ServiceEnvironment when running e2e tests

* [MM 22957] webapp a11y: fix sso btns focus issue (mattermost#23326)

* make suggested changes

* added form tag and removed event handler

* fix snapshot

---------

Co-authored-by: Mattermost Build <build@mattermost.com>

* Upgrade docker CI image to 23.0.1 (mattermost#23664)

Automatic Merge

* MM-52995: Fix opening DM/GM thread from thread footer (mattermost#23579)

* MM-52487: fix more playbooks tests (mattermost#23475)

* fix playbooks/channels/rhs/template_spec.js

* fix playbooks/channels/update_request_post_spec.js

* fix playbooks/runs/rdp_rhs_runinfo_spec.js

* fix playbooks/runs/rdp_rhs_statusupdates_spec.js

* remove enableexperimentalfeatures flag in e2e tests

* rdp_main_header_spec: simplify channel loaded assertion

* playbooks rhs participants: fix infinite fetch loop

* improved onboarding skipping

* simplify participants fetching

* Support json.RawMessage in configuration env overrides (mattermost#23610)

* support json.RawMessage in env overrides

* update more_channels for ui and show all channels

* remove header button

* put back header button

* [MM-52979]: Remove code around abandoned MUI modal migration (mattermost#23556)

* fix import

* update snapshot

* Update e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/accessibility_modals_dialogs_spec.js

* fix e2e tests

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com>
Co-authored-by: M-ZubairAhmed <m-zubairahmed@protonmail.com>
Co-authored-by: Agniva De Sarker <agnivade@yahoo.co.in>
Co-authored-by: mvitale1989 <mvitale1989@hotmail.com>
Co-authored-by: Saturnino Abril <saturnino.abril@gmail.com>
Co-authored-by: Antonis Stamatiou <stamatiou.antonis@gmail.com>
Co-authored-by: Kyriakos Z <3829551+koox00@users.noreply.github.com>
Co-authored-by: Kyriakos Ziakoulis <koox00@Kyriakoss-MacBook-Pro.local>
Co-authored-by: Kyriakos Ziakoulis <koox00@192.168.2.3>
Co-authored-by: Ben Cooke <benkcooke@gmail.com>
Co-authored-by: Pablo Andrés Vélez Vidal <pablovv2012@gmail.com>
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>
Co-authored-by: Devin Binnie <52460000+devinbinnie@users.noreply.github.com>
Co-authored-by: Sai Deepesh <saideepesh000@gmail.com>
Co-authored-by: Doug Lauder <wiggin77@warpmail.net>
Co-authored-by: Harshil Sharma <18575143+harshilsharma63@users.noreply.github.com>
Co-authored-by: Akis Maziotis <akis.maziotis@mattermost.com>
Co-authored-by: Hideaki Matsunami <mahaker@users.noreply.github.com>
Co-authored-by: Konstantinos Pittas <konstantinos.pittas+github@gmail.com>
Co-authored-by: Konstantinos Pittas <konstantinos.pittas@mattermost.com>
Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com>
Co-authored-by: Daniel Espino García <larkox@gmail.com>
Co-authored-by: Christopher Speller <crspeller@gmail.com>
Co-authored-by: Tejas Karelia <tejas.karelia17@gmail.com>
Co-authored-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>
Co-authored-by: KyeongSoo Kim <gaganso71@korea.ac.kr>
Co-authored-by: Matheus <20505926+MattSilvaa@users.noreply.github.com>
Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
Co-authored-by: Julien Tant <785518+JulienTant@users.noreply.github.com>
Co-authored-by: Karan Mishra <karan.m2704@gmail.com>
Co-authored-by: Judy Hanson <106325339+Esterjudith@users.noreply.github.com>
Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com>
Co-authored-by: Caleb Roseland <caleb@calebroseland.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Contributor Docs/Not Needed Does not require documentation release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browse Channels modal: add member count and membership status to the channel list