MM-52979 : Remove code around abandoned MUI modal migration #23556

M-ZubairAhmed · 2023-05-31T14:16:09Z

Summary

GenericModal which was marked as Legacy has been renamed back to just 'GenericModal'
Removed compass preparatory code in mattermost/components
Removed components/generic_modal in Channels which was just re-exporting the GenericModal in favour of importing directly from mattermost/components

Epic which tracked the progress of the task was https://mattermost.atlassian.net/browse/MM-50998 However in that epic only following PRs were raised

[WebApp][MM-52138]: Wrap all the components using compass-components with compass-components theme provider #22941 : This PR wraps many components with the ThemeProvider which just imports the theme into the component. Therefore no reverting here is not mandatory.
[WebApp][MM-51266]: Add compass (MUI wrapper components) in common components package #22942 : From here much of the code is reverted in this PR

Ticket Link

https://mattermost.atlassian.net/browse/MM-52979

Screenshots

n/a

Release Note

NONE

mattermost-build · 2023-05-31T14:16:23Z

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

marianunez

Thanks @M-ZubairAhmed for reverting this changes as we put on hold the migration to MUI modals effort! Some minor observations below

marianunez · 2023-05-31T19:12:28Z

...ponents/admin_console/license_settings/enterprise_edition/enterprise_edition_right_panel.tsx

@@ -1,7 +1,7 @@
 // Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
 // See LICENSE.txt for license information.

-import * as React from 'react';
+import React, {memo} from 'react';


Do we still need the whole React import here?

Suggested change

import React, {memo} from 'react';

import {memo} from 'react';

Yeah we dont have to.

I'm pretty sure you need to import React itself for all the JSX syntax to work since it gets converted to React.createElement by the tooling. My information on that could be very dated though

I'm the one probably dated here so just ignore me 🤐

marianunez · 2023-05-31T19:20:28Z

webapp/channels/src/components/delete_category_modal/delete_category_modal.tsx

+// TODO MM-51399 These strings are properly defined in @mattermost/components, but the i18n tooling currently can't
+// find them there, so we've had to redefine them here


https://mattermost.atlassian.net/browse/MM-51399 refers to the whole epic of post monorepo work. Is there a specific ticket you are referring here that needs to be fixed?

Also, it seems this was done before at the GenericModal level, why are we moving this to this specific modal?

mattermost.atlassian.net/browse/MM-51399 refers to the whole epic of post monorepo work. Is there a specific ticket you are referring here that needs to be fixed?

Added the correct ticket

Also, it seems this was done before at the GenericModal level, why are we moving this to this specific modal?

Yes as mentioned in description that file is now removed, so until the translations of platform folder is sorted this can live here

hmhealey

I'm disappointed to see this all go, but it's definitely a good idea to clean up this half-finished effort. We'll always have the old code around anyway if we ever get back to this

yasserfaraazkhan · 2023-06-05T06:02:17Z

/e2e-test

mattermost-build · 2023-06-05T06:02:21Z

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

yasserfaraazkhan · 2023-06-05T06:47:30Z

/e2e-test

mattermost-build · 2023-06-05T06:47:33Z

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

yasserfaraazkhan · 2023-06-05T08:10:42Z

/e2e-test

mattermost-build · 2023-06-05T08:10:46Z

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

yasserfaraazkhan · 2023-06-05T08:30:30Z

tested few flow around

settings
profile
invite
pricing & purchase
message actions
set header

nothing failed and no F.E errors observed on dev console

yasserfaraazkhan

hi @M-ZubairAhmed
please feel free to run e2e and merge this. its been timing out. I've done the manual pass.

M-ZubairAhmed · 2023-06-05T09:31:30Z

/update-branch

M-ZubairAhmed · 2023-06-05T09:32:58Z

/e2e-test

mattermost-build · 2023-06-05T09:33:01Z

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

M-ZubairAhmed · 2023-06-05T11:30:36Z

/e2e-test

mattermost-build · 2023-06-05T11:30:39Z

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

M-ZubairAhmed · 2023-06-05T11:56:33Z

@yasserfaraazkhan the test are running again. I just updated my branch to latest master I think that solved it 🤷🏽

mm-cloud-bot · 2023-06-05T11:57:05Z

Test server destroyed

…ost#23556)

* update more_channels for ui and show all channels * update searchable channel list * fix style * fix tests * fix style for delete icon * fix failing tests * fix style * remove dot * remove header button * put back header button * Fix duplicate keys in CombinedSystemMessage component (#23507) * MM-52873 : Switch to npm's 'reselect' for Playbooks (#23396) * Enable golangci-lint (attempt 2) (#23517) This time we are just using the Makefile command to see if that makes a difference ```release-note NONE ``` * MM-52888 Always load users mentioned in message attachments (#23460) Co-authored-by: Mattermost Build <build@mattermost.com> * Prepare: run E2E smoketests with GitHub actions (#23301) - Port E2E testing scripts from cypress-ui-automation - Move server to docker-compose, move E2E images to ecrpublic * Integrate General channel renaming, fixes - Add local automation-dashboard - Add readme - Add E2E smoketests - Bump postgres to 12 --------- Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Saturnino Abril <saturnino.abril@gmail.com> Co-authored-by: Antonis Stamatiou <stamatiou.antonis@gmail.com> * MM-47064/MM-34345/MM-47072 Remove inheritance from Suggestion components and migrate to TS (#23455) * MM-47064 Remove inheritance from Suggestion components * Address feedback * Fix users without DM channels not appearing in the channel switcher --------- Co-authored-by: Mattermost Build <build@mattermost.com> * MM-52544 Fix missing reply bar mention highlight (#23534) * MM-52513: fixes deleting a reply (#23177) * MM-52513: fixes deleting a reply Currently when we receive a WS event for a reply being deleted we might accidentally push it to a wrong team's store. This might happen if the thread is already loaded in store and we are viewing another team. In that case we were fetching the thread from the API using the team id of the current team. The API returns the thread, even though the team id is not the one which the thread belongs to. This commit is fixing the above issue by getting the team id in which the thread belongs to, or current team id in the case of DM/GM messages, and using that to fetch the thread from the API. PS: the fetching is needed since we don't send a thread_update WS event upon deleting a reply, and we need to get the new participants list. * Fixes team id on another occasion * Refactors a bit * Reverts returning empty string as team id * Refactor a bit to pass the post as argument --------- Co-authored-by: Kyriakos Ziakoulis <koox00@Kyriakoss-MacBook-Pro.local> Co-authored-by: Kyriakos Ziakoulis <koox00@192.168.2.3> Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com> * Avoid calling the user count query in future if we get a count > 0 (#23545) * Avoid calling the user count query in future if we get a count > 0 * re-adding mock session to avoid adding the old mitigation in future * adjustments based on feedback * MM-52365 - fix JS error banner (#23501) * MM-52365 - fix js error banner * add null type to bindings as an optional type * Make used of typed atomic.Pointer (#23550) * Make save_post_spec less affected by other E2E tests (#23541) * Revert "Prepare: run E2E smoketests with GitHub actions (#23301)" (#23553) This reverts commit 68be3a6. * adding debug log when executing query (#23559) * server/docker-compose.yml: updates to run HA in local after monorepo (#23552) * [MM-52919] Remove all uses of window.desktop.version from webapp (#23558) Co-authored-by: Mattermost Build <build@mattermost.com> * [MM-21096] webapp: Migrate "components/suggestion/search_channel_with_permissions_provider.jsx" to Typescript (#23323) * migrate to ts * linting * fix test * refactor * Remove accidental comments from merge --------- Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com> * fix server ci after renaming the project (#23576) * Temporarily let AdvancedLoggingConfig take precedence over AdvancedLoggingJSON (#23578) * Temporarily let AdvancedLoggingConfig take precedence over AdvancedLoggingJSON * Repo name ci fixes (#23569) * mattermost-server -> mattermost * mattermost-server -> mattermost * Empty-Commit * Empty-Commit * Empty-Commit --------- Co-authored-by: Antonis Stamatiou <stamatiou.antonis@gmail.com> Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Akis Maziotis <akis.maziotis@mattermost.com> * MM-51585 : Fix duplicated date separator in center channel when Pinned posts RHS is open (#23068) * Fix references from 'packages/*' to 'platform/*' in READMEs (#23498) * [MM-52541] Mark files as deleted along with thread (#23226) * mark thread files as deleted * add missing check * improve query * Stopped rendering post preview if post is deleted * Fixed lint error * Fixed test * updated types * Removed deleted post from other post's embed data * Added tests * Apply suggestions from code review Co-authored-by: Daniel Espino García <larkox@gmail.com> * lint fix --------- Co-authored-by: Konstantinos Pittas <konstantinos.pittas@mattermost.com> Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com> Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Harshil Sharma <18575143+harshilsharma63@users.noreply.github.com> Co-authored-by: Daniel Espino García <larkox@gmail.com> * MM-52476 Fix guest users access to playbooks. (#23279) * Fix guest users access to playbooks. * Fix guest access. * Add guests list restriction. * Update PULL_REQUEST_TEMPLATE.md to include Jira ticket for contributors (#23589) * [MM-52836] : Migrate "components/admin_console/admin_definition_constants.jsx" to TypeScript (#23566) * MM-52297 Fix reactions disappearing with search open and add testing utilities (#23510) * MM-52297 Fix reactions disappearing when search is open * Add unit tests and extra utilities * Fix typing issue * MM-53002: Fix ESR CI (#23599) * Do not use the mattermost path The /mattermost path is used by the image and it seems to conflict with the container running the binary * Use a regular machine in the esr-upgrade-diff job * Add missing space * [MM-52955] Fix panic for not found posts (#23561) * [MM-52973] Avoid thundering herd problem in IsFirstUserAccount (#23549) * [MM-45802] Clear CRT notification on deleted reply (#23568) * reduce the counter on post deletion * add test * change translations * fix collecting mentions for DMs * add translation texts * extract logic for getting mentions * send WS event * add e2e tests * tidy mod * WIP * Deleting notification async * Fixed a unit test * Added more tests * Updated i18n * CI * mattermost-server -> mattermost * mattermost-server -> mattermost --------- Co-authored-by: Konstantinos Pittas <konstantinos.pittas@mattermost.com> Co-authored-by: Mattermost Build <build@mattermost.com> * Includes mmctl into the mono-repo (#23091) * Includes mmctl into the mono-repo * Update to use the new public module paths * Adds docs check to the mmctl CI * Fix public utils import path * Tidy up modules * Fix linter * Update CI tasks to use the new file structure * Update CI references * [MM-30432]: Allow users to specify different desktop notification sounds per channel (#21671) * [MM-44165]: When Help link is left blank Help Resources option should not be visible in the help menu (#23609) * Clean up at .github due to repo rename (#23580) * update .github after repo rename * update * Update PULL_REQUEST_TEMPLATE.md --------- Co-authored-by: M-ZubairAhmed <m-zubairahmed@protonmail.com> Co-authored-by: Mattermost Build <build@mattermost.com> * MM-52819 : "medical_symbol", "male_sign" and "female_sign" emojis are broken (#23538) * [MM-52979]: Remove code around abandoned MUI modal migration (#23556) * Re-export all React Testing Library functions (#23522) * Fix panic if JSON null value is passed as channel update (#23629) * MM-52818 - create config setting to enable/disable playbooks product (#23508) * create config setting to enable/disable playbooks product * fix to config name * fix typo * revert changes to package-lock.json * update name of test --------- Co-authored-by: Mattermost Build <build@mattermost.com> * [MM-52926] Deprecating work templates (#23466) Co-authored-by: Mattermost Build <build@mattermost.com> * [MM-52839]: Migrate "components/admin_console/remove_file_setting.jsx" to Typescript (#23565) * [MM-52833]: Migrate "components/admin_console/multiselect_settings.jsx" to Typescript (#23542) * [MM-52835]: Migrate "components/admin_console/settings_group.jsx" and tests to Typescript (#23563) * fix typo in index name for idx_teammembers_create_at (#23632) * [MM-49989] Pass a context.Context to Client4 methods (#22922) * Migrate all method in model/client4.go to accept a context.Context * Fix th.*Client * Fix remaining issues * Empty commit to triger CI * Fix test * Add cancellation test * Test that returned error is context.Canceled * Fix bad merge * Update mmctl code --------- Co-authored-by: Mattermost Build <build@mattermost.com> * Service environment (#23443) * fix fileutils.TestFindFile on MacOS * introduce model.ExternalServiceEnvironment * pick license public key from external service env * pick Stripe public key from external service env * pick Rudder key from external service env * configure Sentry DSN from external service env * always log external_service_environment, Unsetenv * clear faked BuildEnv, improve logging * strip out unset GOTAGS * fix Sentry tests * simplify to just ServiceEnvironment * relocate ServiceEnvironment in client config * initialize CWS URLs based on service environment * unset rudder key for boards dev * harden service environment to avoid accidental production * fix TestSentry again * fix DEFAULT -> ENTERPRISE * s/dev/test when naming playbooks rudder key * simplify boards rudder key switch * use uniform rudderKey variable names * retain compatibility with existing pipeline * reduce to just production/test * unit test with valid test license * simplify Playbooks telemetry initialization * restore dev service environment * emit ServiceEnvironment when running e2e tests * [MM 22957] webapp a11y: fix sso btns focus issue (#23326) * make suggested changes * added form tag and removed event handler * fix snapshot --------- Co-authored-by: Mattermost Build <build@mattermost.com> * Upgrade docker CI image to 23.0.1 (#23664) Automatic Merge * MM-52995: Fix opening DM/GM thread from thread footer (#23579) * MM-52487: fix more playbooks tests (#23475) * fix playbooks/channels/rhs/template_spec.js * fix playbooks/channels/update_request_post_spec.js * fix playbooks/runs/rdp_rhs_runinfo_spec.js * fix playbooks/runs/rdp_rhs_statusupdates_spec.js * remove enableexperimentalfeatures flag in e2e tests * rdp_main_header_spec: simplify channel loaded assertion * playbooks rhs participants: fix infinite fetch loop * improved onboarding skipping * simplify participants fetching * Support json.RawMessage in configuration env overrides (#23610) * support json.RawMessage in env overrides * update more_channels for ui and show all channels * remove header button * put back header button * [MM-52979]: Remove code around abandoned MUI modal migration (#23556) * fix import * update snapshot * Update e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/accessibility_modals_dialogs_spec.js * fix e2e tests --------- Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com> Co-authored-by: M-ZubairAhmed <m-zubairahmed@protonmail.com> Co-authored-by: Agniva De Sarker <agnivade@yahoo.co.in> Co-authored-by: mvitale1989 <mvitale1989@hotmail.com> Co-authored-by: Saturnino Abril <saturnino.abril@gmail.com> Co-authored-by: Antonis Stamatiou <stamatiou.antonis@gmail.com> Co-authored-by: Kyriakos Z <3829551+koox00@users.noreply.github.com> Co-authored-by: Kyriakos Ziakoulis <koox00@Kyriakoss-MacBook-Pro.local> Co-authored-by: Kyriakos Ziakoulis <koox00@192.168.2.3> Co-authored-by: Ben Cooke <benkcooke@gmail.com> Co-authored-by: Pablo Andrés Vélez Vidal <pablovv2012@gmail.com> Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com> Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com> Co-authored-by: Devin Binnie <52460000+devinbinnie@users.noreply.github.com> Co-authored-by: Sai Deepesh <saideepesh000@gmail.com> Co-authored-by: Doug Lauder <wiggin77@warpmail.net> Co-authored-by: Harshil Sharma <18575143+harshilsharma63@users.noreply.github.com> Co-authored-by: Akis Maziotis <akis.maziotis@mattermost.com> Co-authored-by: Hideaki Matsunami <mahaker@users.noreply.github.com> Co-authored-by: Konstantinos Pittas <konstantinos.pittas+github@gmail.com> Co-authored-by: Konstantinos Pittas <konstantinos.pittas@mattermost.com> Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com> Co-authored-by: Daniel Espino García <larkox@gmail.com> Co-authored-by: Christopher Speller <crspeller@gmail.com> Co-authored-by: Tejas Karelia <tejas.karelia17@gmail.com> Co-authored-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com> Co-authored-by: Miguel de la Cruz <miguel@mcrx.me> Co-authored-by: KyeongSoo Kim <gaganso71@korea.ac.kr> Co-authored-by: Matheus <20505926+MattSilvaa@users.noreply.github.com> Co-authored-by: Scott Bishel <scott.bishel@mattermost.com> Co-authored-by: Julien Tant <785518+JulienTant@users.noreply.github.com> Co-authored-by: Karan Mishra <karan.m2704@gmail.com> Co-authored-by: Judy Hanson <106325339+Esterjudith@users.noreply.github.com> Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com> Co-authored-by: Caleb Roseland <caleb@calebroseland.com>

* update more_channels for ui and show all channels * update searchable channel list * fix style * fix tests * fix style for delete icon * fix failing tests * fix style * remove dot * remove header button * put back header button * Fix duplicate keys in CombinedSystemMessage component (mattermost#23507) * MM-52873 : Switch to npm's 'reselect' for Playbooks (mattermost#23396) * Enable golangci-lint (attempt 2) (mattermost#23517) This time we are just using the Makefile command to see if that makes a difference ```release-note NONE ``` * MM-52888 Always load users mentioned in message attachments (mattermost#23460) Co-authored-by: Mattermost Build <build@mattermost.com> * Prepare: run E2E smoketests with GitHub actions (mattermost#23301) - Port E2E testing scripts from cypress-ui-automation - Move server to docker-compose, move E2E images to ecrpublic * Integrate General channel renaming, fixes - Add local automation-dashboard - Add readme - Add E2E smoketests - Bump postgres to 12 --------- Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Saturnino Abril <saturnino.abril@gmail.com> Co-authored-by: Antonis Stamatiou <stamatiou.antonis@gmail.com> * MM-47064/MM-34345/MM-47072 Remove inheritance from Suggestion components and migrate to TS (mattermost#23455) * MM-47064 Remove inheritance from Suggestion components * Address feedback * Fix users without DM channels not appearing in the channel switcher --------- Co-authored-by: Mattermost Build <build@mattermost.com> * MM-52544 Fix missing reply bar mention highlight (mattermost#23534) * MM-52513: fixes deleting a reply (mattermost#23177) * MM-52513: fixes deleting a reply Currently when we receive a WS event for a reply being deleted we might accidentally push it to a wrong team's store. This might happen if the thread is already loaded in store and we are viewing another team. In that case we were fetching the thread from the API using the team id of the current team. The API returns the thread, even though the team id is not the one which the thread belongs to. This commit is fixing the above issue by getting the team id in which the thread belongs to, or current team id in the case of DM/GM messages, and using that to fetch the thread from the API. PS: the fetching is needed since we don't send a thread_update WS event upon deleting a reply, and we need to get the new participants list. * Fixes team id on another occasion * Refactors a bit * Reverts returning empty string as team id * Refactor a bit to pass the post as argument --------- Co-authored-by: Kyriakos Ziakoulis <koox00@Kyriakoss-MacBook-Pro.local> Co-authored-by: Kyriakos Ziakoulis <koox00@192.168.2.3> Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com> * Avoid calling the user count query in future if we get a count > 0 (mattermost#23545) * Avoid calling the user count query in future if we get a count > 0 * re-adding mock session to avoid adding the old mitigation in future * adjustments based on feedback * MM-52365 - fix JS error banner (mattermost#23501) * MM-52365 - fix js error banner * add null type to bindings as an optional type * Make used of typed atomic.Pointer (mattermost#23550) * Make save_post_spec less affected by other E2E tests (mattermost#23541) * Revert "Prepare: run E2E smoketests with GitHub actions (mattermost#23301)" (mattermost#23553) This reverts commit 68be3a6. * adding debug log when executing query (mattermost#23559) * server/docker-compose.yml: updates to run HA in local after monorepo (mattermost#23552) * [MM-52919] Remove all uses of window.desktop.version from webapp (mattermost#23558) Co-authored-by: Mattermost Build <build@mattermost.com> * [MM-21096] webapp: Migrate "components/suggestion/search_channel_with_permissions_provider.jsx" to Typescript (mattermost#23323) * migrate to ts * linting * fix test * refactor * Remove accidental comments from merge --------- Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com> * fix server ci after renaming the project (mattermost#23576) * Temporarily let AdvancedLoggingConfig take precedence over AdvancedLoggingJSON (mattermost#23578) * Temporarily let AdvancedLoggingConfig take precedence over AdvancedLoggingJSON * Repo name ci fixes (mattermost#23569) * mattermost-server -> mattermost * mattermost-server -> mattermost * Empty-Commit * Empty-Commit * Empty-Commit --------- Co-authored-by: Antonis Stamatiou <stamatiou.antonis@gmail.com> Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Akis Maziotis <akis.maziotis@mattermost.com> * MM-51585 : Fix duplicated date separator in center channel when Pinned posts RHS is open (mattermost#23068) * Fix references from 'packages/*' to 'platform/*' in READMEs (mattermost#23498) * [MM-52541] Mark files as deleted along with thread (mattermost#23226) * mark thread files as deleted * add missing check * improve query * Stopped rendering post preview if post is deleted * Fixed lint error * Fixed test * updated types * Removed deleted post from other post's embed data * Added tests * Apply suggestions from code review Co-authored-by: Daniel Espino García <larkox@gmail.com> * lint fix --------- Co-authored-by: Konstantinos Pittas <konstantinos.pittas@mattermost.com> Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com> Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Harshil Sharma <18575143+harshilsharma63@users.noreply.github.com> Co-authored-by: Daniel Espino García <larkox@gmail.com> * MM-52476 Fix guest users access to playbooks. (mattermost#23279) * Fix guest users access to playbooks. * Fix guest access. * Add guests list restriction. * Update PULL_REQUEST_TEMPLATE.md to include Jira ticket for contributors (mattermost#23589) * [MM-52836] : Migrate "components/admin_console/admin_definition_constants.jsx" to TypeScript (mattermost#23566) * MM-52297 Fix reactions disappearing with search open and add testing utilities (mattermost#23510) * MM-52297 Fix reactions disappearing when search is open * Add unit tests and extra utilities * Fix typing issue * MM-53002: Fix ESR CI (mattermost#23599) * Do not use the mattermost path The /mattermost path is used by the image and it seems to conflict with the container running the binary * Use a regular machine in the esr-upgrade-diff job * Add missing space * [MM-52955] Fix panic for not found posts (mattermost#23561) * [MM-52973] Avoid thundering herd problem in IsFirstUserAccount (mattermost#23549) * [MM-45802] Clear CRT notification on deleted reply (mattermost#23568) * reduce the counter on post deletion * add test * change translations * fix collecting mentions for DMs * add translation texts * extract logic for getting mentions * send WS event * add e2e tests * tidy mod * WIP * Deleting notification async * Fixed a unit test * Added more tests * Updated i18n * CI * mattermost-server -> mattermost * mattermost-server -> mattermost --------- Co-authored-by: Konstantinos Pittas <konstantinos.pittas@mattermost.com> Co-authored-by: Mattermost Build <build@mattermost.com> * Includes mmctl into the mono-repo (mattermost#23091) * Includes mmctl into the mono-repo * Update to use the new public module paths * Adds docs check to the mmctl CI * Fix public utils import path * Tidy up modules * Fix linter * Update CI tasks to use the new file structure * Update CI references * [MM-30432]: Allow users to specify different desktop notification sounds per channel (mattermost#21671) * [MM-44165]: When Help link is left blank Help Resources option should not be visible in the help menu (mattermost#23609) * Clean up at .github due to repo rename (mattermost#23580) * update .github after repo rename * update * Update PULL_REQUEST_TEMPLATE.md --------- Co-authored-by: M-ZubairAhmed <m-zubairahmed@protonmail.com> Co-authored-by: Mattermost Build <build@mattermost.com> * MM-52819 : "medical_symbol", "male_sign" and "female_sign" emojis are broken (mattermost#23538) * [MM-52979]: Remove code around abandoned MUI modal migration (mattermost#23556) * Re-export all React Testing Library functions (mattermost#23522) * Fix panic if JSON null value is passed as channel update (mattermost#23629) * MM-52818 - create config setting to enable/disable playbooks product (mattermost#23508) * create config setting to enable/disable playbooks product * fix to config name * fix typo * revert changes to package-lock.json * update name of test --------- Co-authored-by: Mattermost Build <build@mattermost.com> * [MM-52926] Deprecating work templates (mattermost#23466) Co-authored-by: Mattermost Build <build@mattermost.com> * [MM-52839]: Migrate "components/admin_console/remove_file_setting.jsx" to Typescript (mattermost#23565) * [MM-52833]: Migrate "components/admin_console/multiselect_settings.jsx" to Typescript (mattermost#23542) * [MM-52835]: Migrate "components/admin_console/settings_group.jsx" and tests to Typescript (mattermost#23563) * fix typo in index name for idx_teammembers_create_at (mattermost#23632) * [MM-49989] Pass a context.Context to Client4 methods (mattermost#22922) * Migrate all method in model/client4.go to accept a context.Context * Fix th.*Client * Fix remaining issues * Empty commit to triger CI * Fix test * Add cancellation test * Test that returned error is context.Canceled * Fix bad merge * Update mmctl code --------- Co-authored-by: Mattermost Build <build@mattermost.com> * Service environment (mattermost#23443) * fix fileutils.TestFindFile on MacOS * introduce model.ExternalServiceEnvironment * pick license public key from external service env * pick Stripe public key from external service env * pick Rudder key from external service env * configure Sentry DSN from external service env * always log external_service_environment, Unsetenv * clear faked BuildEnv, improve logging * strip out unset GOTAGS * fix Sentry tests * simplify to just ServiceEnvironment * relocate ServiceEnvironment in client config * initialize CWS URLs based on service environment * unset rudder key for boards dev * harden service environment to avoid accidental production * fix TestSentry again * fix DEFAULT -> ENTERPRISE * s/dev/test when naming playbooks rudder key * simplify boards rudder key switch * use uniform rudderKey variable names * retain compatibility with existing pipeline * reduce to just production/test * unit test with valid test license * simplify Playbooks telemetry initialization * restore dev service environment * emit ServiceEnvironment when running e2e tests * [MM 22957] webapp a11y: fix sso btns focus issue (mattermost#23326) * make suggested changes * added form tag and removed event handler * fix snapshot --------- Co-authored-by: Mattermost Build <build@mattermost.com> * Upgrade docker CI image to 23.0.1 (mattermost#23664) Automatic Merge * MM-52995: Fix opening DM/GM thread from thread footer (mattermost#23579) * MM-52487: fix more playbooks tests (mattermost#23475) * fix playbooks/channels/rhs/template_spec.js * fix playbooks/channels/update_request_post_spec.js * fix playbooks/runs/rdp_rhs_runinfo_spec.js * fix playbooks/runs/rdp_rhs_statusupdates_spec.js * remove enableexperimentalfeatures flag in e2e tests * rdp_main_header_spec: simplify channel loaded assertion * playbooks rhs participants: fix infinite fetch loop * improved onboarding skipping * simplify participants fetching * Support json.RawMessage in configuration env overrides (mattermost#23610) * support json.RawMessage in env overrides * update more_channels for ui and show all channels * remove header button * put back header button * [MM-52979]: Remove code around abandoned MUI modal migration (mattermost#23556) * fix import * update snapshot * Update e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/accessibility_modals_dialogs_spec.js * fix e2e tests --------- Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com> Co-authored-by: M-ZubairAhmed <m-zubairahmed@protonmail.com> Co-authored-by: Agniva De Sarker <agnivade@yahoo.co.in> Co-authored-by: mvitale1989 <mvitale1989@hotmail.com> Co-authored-by: Saturnino Abril <saturnino.abril@gmail.com> Co-authored-by: Antonis Stamatiou <stamatiou.antonis@gmail.com> Co-authored-by: Kyriakos Z <3829551+koox00@users.noreply.github.com> Co-authored-by: Kyriakos Ziakoulis <koox00@Kyriakoss-MacBook-Pro.local> Co-authored-by: Kyriakos Ziakoulis <koox00@192.168.2.3> Co-authored-by: Ben Cooke <benkcooke@gmail.com> Co-authored-by: Pablo Andrés Vélez Vidal <pablovv2012@gmail.com> Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com> Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com> Co-authored-by: Devin Binnie <52460000+devinbinnie@users.noreply.github.com> Co-authored-by: Sai Deepesh <saideepesh000@gmail.com> Co-authored-by: Doug Lauder <wiggin77@warpmail.net> Co-authored-by: Harshil Sharma <18575143+harshilsharma63@users.noreply.github.com> Co-authored-by: Akis Maziotis <akis.maziotis@mattermost.com> Co-authored-by: Hideaki Matsunami <mahaker@users.noreply.github.com> Co-authored-by: Konstantinos Pittas <konstantinos.pittas+github@gmail.com> Co-authored-by: Konstantinos Pittas <konstantinos.pittas@mattermost.com> Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com> Co-authored-by: Daniel Espino García <larkox@gmail.com> Co-authored-by: Christopher Speller <crspeller@gmail.com> Co-authored-by: Tejas Karelia <tejas.karelia17@gmail.com> Co-authored-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com> Co-authored-by: Miguel de la Cruz <miguel@mcrx.me> Co-authored-by: KyeongSoo Kim <gaganso71@korea.ac.kr> Co-authored-by: Matheus <20505926+MattSilvaa@users.noreply.github.com> Co-authored-by: Scott Bishel <scott.bishel@mattermost.com> Co-authored-by: Julien Tant <785518+JulienTant@users.noreply.github.com> Co-authored-by: Karan Mishra <karan.m2704@gmail.com> Co-authored-by: Judy Hanson <106325339+Esterjudith@users.noreply.github.com> Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com> Co-authored-by: Caleb Roseland <caleb@calebroseland.com>

…ost#23556)

* update more_channels for ui and show all channels * update searchable channel list * fix style * fix tests * fix style for delete icon * fix failing tests * fix style * remove dot * remove header button * put back header button * Fix duplicate keys in CombinedSystemMessage component (mattermost#23507) * MM-52873 : Switch to npm's 'reselect' for Playbooks (mattermost#23396) * Enable golangci-lint (attempt 2) (mattermost#23517) This time we are just using the Makefile command to see if that makes a difference ```release-note NONE ``` * MM-52888 Always load users mentioned in message attachments (mattermost#23460) Co-authored-by: Mattermost Build <build@mattermost.com> * Prepare: run E2E smoketests with GitHub actions (mattermost#23301) - Port E2E testing scripts from cypress-ui-automation - Move server to docker-compose, move E2E images to ecrpublic * Integrate General channel renaming, fixes - Add local automation-dashboard - Add readme - Add E2E smoketests - Bump postgres to 12 --------- Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Saturnino Abril <saturnino.abril@gmail.com> Co-authored-by: Antonis Stamatiou <stamatiou.antonis@gmail.com> * MM-47064/MM-34345/MM-47072 Remove inheritance from Suggestion components and migrate to TS (mattermost#23455) * MM-47064 Remove inheritance from Suggestion components * Address feedback * Fix users without DM channels not appearing in the channel switcher --------- Co-authored-by: Mattermost Build <build@mattermost.com> * MM-52544 Fix missing reply bar mention highlight (mattermost#23534) * MM-52513: fixes deleting a reply (mattermost#23177) * MM-52513: fixes deleting a reply Currently when we receive a WS event for a reply being deleted we might accidentally push it to a wrong team's store. This might happen if the thread is already loaded in store and we are viewing another team. In that case we were fetching the thread from the API using the team id of the current team. The API returns the thread, even though the team id is not the one which the thread belongs to. This commit is fixing the above issue by getting the team id in which the thread belongs to, or current team id in the case of DM/GM messages, and using that to fetch the thread from the API. PS: the fetching is needed since we don't send a thread_update WS event upon deleting a reply, and we need to get the new participants list. * Fixes team id on another occasion * Refactors a bit * Reverts returning empty string as team id * Refactor a bit to pass the post as argument --------- Co-authored-by: Kyriakos Ziakoulis <koox00@Kyriakoss-MacBook-Pro.local> Co-authored-by: Kyriakos Ziakoulis <koox00@192.168.2.3> Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com> * Avoid calling the user count query in future if we get a count > 0 (mattermost#23545) * Avoid calling the user count query in future if we get a count > 0 * re-adding mock session to avoid adding the old mitigation in future * adjustments based on feedback * MM-52365 - fix JS error banner (mattermost#23501) * MM-52365 - fix js error banner * add null type to bindings as an optional type * Make used of typed atomic.Pointer (mattermost#23550) * Make save_post_spec less affected by other E2E tests (mattermost#23541) * Revert "Prepare: run E2E smoketests with GitHub actions (mattermost#23301)" (mattermost#23553) This reverts commit 68be3a6. * adding debug log when executing query (mattermost#23559) * server/docker-compose.yml: updates to run HA in local after monorepo (mattermost#23552) * [MM-52919] Remove all uses of window.desktop.version from webapp (mattermost#23558) Co-authored-by: Mattermost Build <build@mattermost.com> * [MM-21096] webapp: Migrate "components/suggestion/search_channel_with_permissions_provider.jsx" to Typescript (mattermost#23323) * migrate to ts * linting * fix test * refactor * Remove accidental comments from merge --------- Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com> * fix server ci after renaming the project (mattermost#23576) * Temporarily let AdvancedLoggingConfig take precedence over AdvancedLoggingJSON (mattermost#23578) * Temporarily let AdvancedLoggingConfig take precedence over AdvancedLoggingJSON * Repo name ci fixes (mattermost#23569) * mattermost-server -> mattermost * mattermost-server -> mattermost * Empty-Commit * Empty-Commit * Empty-Commit --------- Co-authored-by: Antonis Stamatiou <stamatiou.antonis@gmail.com> Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Akis Maziotis <akis.maziotis@mattermost.com> * MM-51585 : Fix duplicated date separator in center channel when Pinned posts RHS is open (mattermost#23068) * Fix references from 'packages/*' to 'platform/*' in READMEs (mattermost#23498) * [MM-52541] Mark files as deleted along with thread (mattermost#23226) * mark thread files as deleted * add missing check * improve query * Stopped rendering post preview if post is deleted * Fixed lint error * Fixed test * updated types * Removed deleted post from other post's embed data * Added tests * Apply suggestions from code review Co-authored-by: Daniel Espino García <larkox@gmail.com> * lint fix --------- Co-authored-by: Konstantinos Pittas <konstantinos.pittas@mattermost.com> Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com> Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Harshil Sharma <18575143+harshilsharma63@users.noreply.github.com> Co-authored-by: Daniel Espino García <larkox@gmail.com> * MM-52476 Fix guest users access to playbooks. (mattermost#23279) * Fix guest users access to playbooks. * Fix guest access. * Add guests list restriction. * Update PULL_REQUEST_TEMPLATE.md to include Jira ticket for contributors (mattermost#23589) * [MM-52836] : Migrate "components/admin_console/admin_definition_constants.jsx" to TypeScript (mattermost#23566) * MM-52297 Fix reactions disappearing with search open and add testing utilities (mattermost#23510) * MM-52297 Fix reactions disappearing when search is open * Add unit tests and extra utilities * Fix typing issue * MM-53002: Fix ESR CI (mattermost#23599) * Do not use the mattermost path The /mattermost path is used by the image and it seems to conflict with the container running the binary * Use a regular machine in the esr-upgrade-diff job * Add missing space * [MM-52955] Fix panic for not found posts (mattermost#23561) * [MM-52973] Avoid thundering herd problem in IsFirstUserAccount (mattermost#23549) * [MM-45802] Clear CRT notification on deleted reply (mattermost#23568) * reduce the counter on post deletion * add test * change translations * fix collecting mentions for DMs * add translation texts * extract logic for getting mentions * send WS event * add e2e tests * tidy mod * WIP * Deleting notification async * Fixed a unit test * Added more tests * Updated i18n * CI * mattermost-server -> mattermost * mattermost-server -> mattermost --------- Co-authored-by: Konstantinos Pittas <konstantinos.pittas@mattermost.com> Co-authored-by: Mattermost Build <build@mattermost.com> * Includes mmctl into the mono-repo (mattermost#23091) * Includes mmctl into the mono-repo * Update to use the new public module paths * Adds docs check to the mmctl CI * Fix public utils import path * Tidy up modules * Fix linter * Update CI tasks to use the new file structure * Update CI references * [MM-30432]: Allow users to specify different desktop notification sounds per channel (mattermost#21671) * [MM-44165]: When Help link is left blank Help Resources option should not be visible in the help menu (mattermost#23609) * Clean up at .github due to repo rename (mattermost#23580) * update .github after repo rename * update * Update PULL_REQUEST_TEMPLATE.md --------- Co-authored-by: M-ZubairAhmed <m-zubairahmed@protonmail.com> Co-authored-by: Mattermost Build <build@mattermost.com> * MM-52819 : "medical_symbol", "male_sign" and "female_sign" emojis are broken (mattermost#23538) * [MM-52979]: Remove code around abandoned MUI modal migration (mattermost#23556) * Re-export all React Testing Library functions (mattermost#23522) * Fix panic if JSON null value is passed as channel update (mattermost#23629) * MM-52818 - create config setting to enable/disable playbooks product (mattermost#23508) * create config setting to enable/disable playbooks product * fix to config name * fix typo * revert changes to package-lock.json * update name of test --------- Co-authored-by: Mattermost Build <build@mattermost.com> * [MM-52926] Deprecating work templates (mattermost#23466) Co-authored-by: Mattermost Build <build@mattermost.com> * [MM-52839]: Migrate "components/admin_console/remove_file_setting.jsx" to Typescript (mattermost#23565) * [MM-52833]: Migrate "components/admin_console/multiselect_settings.jsx" to Typescript (mattermost#23542) * [MM-52835]: Migrate "components/admin_console/settings_group.jsx" and tests to Typescript (mattermost#23563) * fix typo in index name for idx_teammembers_create_at (mattermost#23632) * [MM-49989] Pass a context.Context to Client4 methods (mattermost#22922) * Migrate all method in model/client4.go to accept a context.Context * Fix th.*Client * Fix remaining issues * Empty commit to triger CI * Fix test * Add cancellation test * Test that returned error is context.Canceled * Fix bad merge * Update mmctl code --------- Co-authored-by: Mattermost Build <build@mattermost.com> * Service environment (mattermost#23443) * fix fileutils.TestFindFile on MacOS * introduce model.ExternalServiceEnvironment * pick license public key from external service env * pick Stripe public key from external service env * pick Rudder key from external service env * configure Sentry DSN from external service env * always log external_service_environment, Unsetenv * clear faked BuildEnv, improve logging * strip out unset GOTAGS * fix Sentry tests * simplify to just ServiceEnvironment * relocate ServiceEnvironment in client config * initialize CWS URLs based on service environment * unset rudder key for boards dev * harden service environment to avoid accidental production * fix TestSentry again * fix DEFAULT -> ENTERPRISE * s/dev/test when naming playbooks rudder key * simplify boards rudder key switch * use uniform rudderKey variable names * retain compatibility with existing pipeline * reduce to just production/test * unit test with valid test license * simplify Playbooks telemetry initialization * restore dev service environment * emit ServiceEnvironment when running e2e tests * [MM 22957] webapp a11y: fix sso btns focus issue (mattermost#23326) * make suggested changes * added form tag and removed event handler * fix snapshot --------- Co-authored-by: Mattermost Build <build@mattermost.com> * Upgrade docker CI image to 23.0.1 (mattermost#23664) Automatic Merge * MM-52995: Fix opening DM/GM thread from thread footer (mattermost#23579) * MM-52487: fix more playbooks tests (mattermost#23475) * fix playbooks/channels/rhs/template_spec.js * fix playbooks/channels/update_request_post_spec.js * fix playbooks/runs/rdp_rhs_runinfo_spec.js * fix playbooks/runs/rdp_rhs_statusupdates_spec.js * remove enableexperimentalfeatures flag in e2e tests * rdp_main_header_spec: simplify channel loaded assertion * playbooks rhs participants: fix infinite fetch loop * improved onboarding skipping * simplify participants fetching * Support json.RawMessage in configuration env overrides (mattermost#23610) * support json.RawMessage in env overrides * update more_channels for ui and show all channels * remove header button * put back header button * [MM-52979]: Remove code around abandoned MUI modal migration (mattermost#23556) * fix import * update snapshot * Update e2e-tests/cypress/tests/integration/channels/enterprise/accessibility/accessibility_modals_dialogs_spec.js * fix e2e tests --------- Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com> Co-authored-by: M-ZubairAhmed <m-zubairahmed@protonmail.com> Co-authored-by: Agniva De Sarker <agnivade@yahoo.co.in> Co-authored-by: mvitale1989 <mvitale1989@hotmail.com> Co-authored-by: Saturnino Abril <saturnino.abril@gmail.com> Co-authored-by: Antonis Stamatiou <stamatiou.antonis@gmail.com> Co-authored-by: Kyriakos Z <3829551+koox00@users.noreply.github.com> Co-authored-by: Kyriakos Ziakoulis <koox00@Kyriakoss-MacBook-Pro.local> Co-authored-by: Kyriakos Ziakoulis <koox00@192.168.2.3> Co-authored-by: Ben Cooke <benkcooke@gmail.com> Co-authored-by: Pablo Andrés Vélez Vidal <pablovv2012@gmail.com> Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com> Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com> Co-authored-by: Devin Binnie <52460000+devinbinnie@users.noreply.github.com> Co-authored-by: Sai Deepesh <saideepesh000@gmail.com> Co-authored-by: Doug Lauder <wiggin77@warpmail.net> Co-authored-by: Harshil Sharma <18575143+harshilsharma63@users.noreply.github.com> Co-authored-by: Akis Maziotis <akis.maziotis@mattermost.com> Co-authored-by: Hideaki Matsunami <mahaker@users.noreply.github.com> Co-authored-by: Konstantinos Pittas <konstantinos.pittas+github@gmail.com> Co-authored-by: Konstantinos Pittas <konstantinos.pittas@mattermost.com> Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com> Co-authored-by: Daniel Espino García <larkox@gmail.com> Co-authored-by: Christopher Speller <crspeller@gmail.com> Co-authored-by: Tejas Karelia <tejas.karelia17@gmail.com> Co-authored-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com> Co-authored-by: Miguel de la Cruz <miguel@mcrx.me> Co-authored-by: KyeongSoo Kim <gaganso71@korea.ac.kr> Co-authored-by: Matheus <20505926+MattSilvaa@users.noreply.github.com> Co-authored-by: Scott Bishel <scott.bishel@mattermost.com> Co-authored-by: Julien Tant <785518+JulienTant@users.noreply.github.com> Co-authored-by: Karan Mishra <karan.m2704@gmail.com> Co-authored-by: Judy Hanson <106325339+Esterjudith@users.noreply.github.com> Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com> Co-authored-by: Caleb Roseland <caleb@calebroseland.com>

init

271a909

M-ZubairAhmed requested a review from a team as a code owner May 31, 2023 14:16

M-ZubairAhmed requested review from devinbinnie and removed request for a team May 31, 2023 14:16

mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 31, 2023

M-ZubairAhmed added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels May 31, 2023

M-ZubairAhmed requested review from marianunez and hmhealey and removed request for devinbinnie May 31, 2023 14:17

snap

b19f1fb

marianunez approved these changes May 31, 2023

View reviewed changes

lint

9bd1741

M-ZubairAhmed added the EETests label Jun 1, 2023

mattermost-build removed the EETests label Jun 1, 2023

marianunez added the Setup Cloud Test Server Setup an on-prem test server label Jun 2, 2023

marianunez requested a review from yasserfaraazkhan June 2, 2023 16:33

hmhealey approved these changes Jun 2, 2023

View reviewed changes

hmhealey removed the 2: Dev Review Requires review by a developer label Jun 2, 2023

yasserfaraazkhan approved these changes Jun 5, 2023

View reviewed changes

Merge branch 'master' into rev-comp

fb1ccab

M-ZubairAhmed removed the 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review label Jun 5, 2023

M-ZubairAhmed added 4: Reviews Complete All reviewers have approved the pull request and removed Setup Cloud Test Server Setup an on-prem test server labels Jun 5, 2023

M-ZubairAhmed merged commit f4f420d into master Jun 5, 2023
15 checks passed

M-ZubairAhmed deleted the rev-comp branch June 5, 2023 13:10

amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jun 5, 2023

sinansonmez pushed a commit to sinansonmez/mattermost that referenced this pull request Jun 8, 2023

[MM-52979]: Remove code around abandoned MUI modal migration (matterm…

d3a9bfe

…ost#23556)

sinansonmez pushed a commit to sinansonmez/mattermost that referenced this pull request Jun 8, 2023

[MM-52979]: Remove code around abandoned MUI modal migration (matterm…

3ef9388

…ost#23556)

sbishel pushed a commit to sbishel/mattermost that referenced this pull request Aug 15, 2023

[MM-52979]: Remove code around abandoned MUI modal migration (matterm…

f535b28

…ost#23556)

jwilander added the kind/refactor Categorizes issue or PR as related to refactor of production code. label Nov 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MM-52979 : Remove code around abandoned MUI modal migration #23556

MM-52979 : Remove code around abandoned MUI modal migration #23556

M-ZubairAhmed commented May 31, 2023 •

edited

mattermost-build commented May 31, 2023

marianunez left a comment

marianunez May 31, 2023

M-ZubairAhmed Jun 1, 2023

hmhealey Jun 2, 2023

marianunez Jun 5, 2023

marianunez May 31, 2023

marianunez May 31, 2023

M-ZubairAhmed Jun 1, 2023

hmhealey left a comment

yasserfaraazkhan commented Jun 5, 2023

mattermost-build commented Jun 5, 2023

yasserfaraazkhan commented Jun 5, 2023

mattermost-build commented Jun 5, 2023

yasserfaraazkhan commented Jun 5, 2023

mattermost-build commented Jun 5, 2023

yasserfaraazkhan commented Jun 5, 2023

yasserfaraazkhan left a comment •

edited

M-ZubairAhmed commented Jun 5, 2023

M-ZubairAhmed commented Jun 5, 2023

mattermost-build commented Jun 5, 2023

M-ZubairAhmed commented Jun 5, 2023

mattermost-build commented Jun 5, 2023

M-ZubairAhmed commented Jun 5, 2023

mm-cloud-bot commented Jun 5, 2023

	import React, {memo} from 'react';
	import {memo} from 'react';

		// TODO MM-51399 These strings are properly defined in @mattermost/components, but the i18n tooling currently can't
		// find them there, so we've had to redefine them here

MM-52979 : Remove code around abandoned MUI modal migration #23556

MM-52979 : Remove code around abandoned MUI modal migration #23556

Conversation

M-ZubairAhmed commented May 31, 2023 • edited

Summary

Ticket Link

Screenshots

Release Note

mattermost-build commented May 31, 2023

marianunez left a comment

Choose a reason for hiding this comment

marianunez May 31, 2023

Choose a reason for hiding this comment

M-ZubairAhmed Jun 1, 2023

Choose a reason for hiding this comment

hmhealey Jun 2, 2023

Choose a reason for hiding this comment

marianunez Jun 5, 2023

Choose a reason for hiding this comment

marianunez May 31, 2023

Choose a reason for hiding this comment

marianunez May 31, 2023

Choose a reason for hiding this comment

M-ZubairAhmed Jun 1, 2023

Choose a reason for hiding this comment

hmhealey left a comment

Choose a reason for hiding this comment

yasserfaraazkhan commented Jun 5, 2023

mattermost-build commented Jun 5, 2023

yasserfaraazkhan commented Jun 5, 2023

mattermost-build commented Jun 5, 2023

yasserfaraazkhan commented Jun 5, 2023

mattermost-build commented Jun 5, 2023

yasserfaraazkhan commented Jun 5, 2023

yasserfaraazkhan left a comment • edited

Choose a reason for hiding this comment

M-ZubairAhmed commented Jun 5, 2023

M-ZubairAhmed commented Jun 5, 2023

mattermost-build commented Jun 5, 2023

M-ZubairAhmed commented Jun 5, 2023

mattermost-build commented Jun 5, 2023

M-ZubairAhmed commented Jun 5, 2023

mm-cloud-bot commented Jun 5, 2023

M-ZubairAhmed commented May 31, 2023 •

edited

yasserfaraazkhan left a comment •

edited