Adding Vietnamese as a new language (beta) #24074

ctlaltdieliet · 2023-07-20T07:14:23Z

Summary

Adding Vietnamese as a new shipped language (beta)
@cwarnermm
This PR is related to mattermost/mattermost-mobile#7462 and to mattermost/desktop#2872

Release Note

NONE

mm-cloud-bot · 2023-07-20T07:14:26Z

@ctlaltdieliet: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

mattermost-build · 2023-07-20T07:14:32Z

Hello @ctlaltdieliet,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

devinbinnie

Approving to unblock, but looks like the lint isn't passing.

ctlaltdieliet · 2023-07-24T15:26:06Z

Lint fails because the translations aren't merged yet from Weblate

mattermost-build · 2023-08-09T01:01:42Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Willyfrog · 2023-08-21T12:21:22Z

Lint fails because the translations aren't merged yet from Weblate

@ctlaltdieliet is that something we need to do here or in weblate?

ctlaltdieliet · 2023-08-21T12:26:53Z

Vietnamese was added in Weblate that wants to be the one and only true source of translations but was removed after a rebase.
I can add it again and if we merge the translations into master it would be ok.
But we also have this PR that brings the WIP-languages under the shipped repository. So maybe there needs to be some coordination between this and that PR but I'm not sure.

ctlaltdieliet · 2023-09-14T19:00:41Z

/update-branch

ctlaltdieliet · 2023-09-28T14:29:00Z

/update-branch

ctlaltdieliet · 2023-10-05T07:39:51Z

/update-branch

ctlaltdieliet · 2023-10-05T08:59:58Z

I see that the vi.json file isn't pushed from Weblate to Master. Will be done probably Monday Oct 13th

ctlaltdieliet · 2023-10-10T15:26:34Z

/update-branch

mattermost-build · 2023-10-12T16:14:29Z

E2E tests not automatically triggered, because the PR is not in a mergeable state. Please update the branch with the base branch and resolve outstanding conflicts.

lieut-data · 2023-10-12T16:15:00Z

@lindalumitchell, can you help me find the right owner for QA'ing the addition of this supported language?

lieut-data · 2023-10-12T19:42:27Z

@ctlaltdieliet, I added Vietnamese as a server supported language (this is required because of the change to merge WIP languages but "hide" them from the server). Unfortunately, it looks like there might be a parsing error with the current translation?

Error: unable to load Mattermost translation files: unable to parse translation #934 because template: Không thể thêm tùy chọn kênh trực tiếp cho người dùng user_id = {{. UserId}}, team_id = {{. TeamId}}, err = {{. Error}}:1: function "UserId" not defined
map[id:api.user.add_direct_channels_and_forget.failed.error translation:Không thể thêm tùy chọn kênh trực tiếp cho người dùng user_id = {{. UserId}}, team_id = {{. TeamId}}, err = {{. Error}}]

…into i18n-vi

ctlaltdieliet · 2023-10-13T08:17:50Z

Hi @lieut-data,
I checked the translation string but didn't see an error. I took the current vi.json from Weblate, removed the string from vi.json and added to this PR. But still no test-server spinning up

lieut-data · 2023-10-13T14:29:34Z

@ctlaltdieliet, actually removing that looks good! No more CI issues starting up the server, so I think we're good for a QA pass before merging.

lieut-data · 2023-10-13T14:29:46Z

/e2e-test

mattermost-build · 2023-10-13T14:29:50Z

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

lindalumitchell

Checked through e2es and no relevant failures found. Also ran through various pages in Vietnamese and a couple other languages with no issues found. LGTM!

lieut-data · 2023-10-17T13:08:04Z

Thank you, @lindalumitchell!

mm-cloud-bot · 2023-10-17T13:08:26Z

Test server destroyed

* adding vietnamese * ran npm run test:updatesnapshot * ran npm run test:updatesnapshot * Update i18n.jsx * updatesed snapshot * fix whitespace in snapshots * add vi as supported server locale * update docs to point at server-side list of supported locales * removed incorrect translation --------- Co-authored-by: Tom De Moor <tom@controlaltdieliet.be> Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com>

Tom De Moor added 3 commits July 19, 2023 16:48

adding vietnamese

6a1568f

ran npm run test:updatesnapshot

36fad11

ran npm run test:updatesnapshot

c4ff19a

mm-cloud-bot added the do-not-merge/release-note-label-needed label Jul 20, 2023

mattermost-build added the Contributor label Jul 20, 2023

ctlaltdieliet mentioned this pull request Jul 20, 2023

adding Vietnamese as a new language (beta) mattermost/mattermost-mobile#7462

Merged

mm-cloud-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed labels Jul 20, 2023

M-ZubairAhmed approved these changes Jul 20, 2023

View reviewed changes

M-ZubairAhmed requested a review from devinbinnie July 20, 2023 09:17

devinbinnie approved these changes Jul 20, 2023

View reviewed changes

mattermost-build added the Lifecycle/1:stale label Aug 9, 2023

Merge branch 'master' into i18n-vi

74293eb

Merge branch 'master' into i18n-vi

1ee7d35

mattermost-build and others added 2 commits October 5, 2023 09:39

Merge branch 'master' into i18n-vi

ac2ae3b

Update i18n.jsx

22c0018

ctlaltdieliet mentioned this pull request Oct 5, 2023

adding Vietnamese language as beta mattermost/desktop#2872

Merged

3 tasks

Merge branch 'mattermost:master' into i18n-vi

5f9d1bc

Merge branch 'master' into i18n-vi

74d4667

lieut-data added the 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review label Oct 12, 2023

lieut-data requested a review from lindalumitchell October 12, 2023 16:14

lieut-data added 3 commits October 12, 2023 14:54

Merge remote-tracking branch 'origin/master' into i18n-vi

9d160b1

add vi as supported server locale

b42e073

update docs to point at server-side list of supported locales

10671c5

Tom De Moor and others added 4 commits October 13, 2023 08:10

removed incorrect translation

733f034

Merge branch 'i18n-vi' of github.com:ctlaltdieliet/mattermost-server …

ee551f4

…into i18n-vi

Merge branch 'mattermost:master' into i18n-vi

a0ce6db

Merge branch 'i18n-vi' of github.com:ctlaltdieliet/mattermost-server …

d03efea

…into i18n-vi

lindalumitchell approved these changes Oct 17, 2023

View reviewed changes

lieut-data removed the 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review label Oct 17, 2023

lieut-data merged commit 1de790a into mattermost:master Oct 17, 2023
31 checks passed

mattermost-build removed the Setup Cloud Test Server Setup an on-prem test server label Oct 17, 2023

amyblais added Docs/Needed Requires documentation Changelog/Done Required changelog entry has been written labels Oct 17, 2023

amyblais added this to the v9.3.0 milestone Oct 17, 2023

cwarnermm mentioned this pull request Nov 13, 2023

+ Vietnamese as Beta; + Hungarian where missing mattermost/docs#6777

Merged

cwarnermm added Docs/Done Required documentation has been written and removed Docs/Needed Requires documentation labels Nov 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Vietnamese as a new language (beta) #24074

Adding Vietnamese as a new language (beta) #24074

ctlaltdieliet commented Jul 20, 2023 •

edited

mm-cloud-bot commented Jul 20, 2023

mattermost-build commented Jul 20, 2023

devinbinnie left a comment

ctlaltdieliet commented Jul 24, 2023

mattermost-build commented Aug 9, 2023

Willyfrog commented Aug 21, 2023

ctlaltdieliet commented Aug 21, 2023 •

edited

ctlaltdieliet commented Sep 14, 2023

ctlaltdieliet commented Sep 28, 2023

ctlaltdieliet commented Oct 5, 2023

ctlaltdieliet commented Oct 5, 2023

ctlaltdieliet commented Oct 10, 2023

mattermost-build commented Oct 12, 2023

lieut-data commented Oct 12, 2023

lieut-data commented Oct 12, 2023

ctlaltdieliet commented Oct 13, 2023

lieut-data commented Oct 13, 2023

lieut-data commented Oct 13, 2023

mattermost-build commented Oct 13, 2023

lindalumitchell left a comment

lieut-data commented Oct 17, 2023

mm-cloud-bot commented Oct 17, 2023

Adding Vietnamese as a new language (beta) #24074

Adding Vietnamese as a new language (beta) #24074

Conversation

ctlaltdieliet commented Jul 20, 2023 • edited

Summary

Release Note

mm-cloud-bot commented Jul 20, 2023

mattermost-build commented Jul 20, 2023

devinbinnie left a comment

Choose a reason for hiding this comment

ctlaltdieliet commented Jul 24, 2023

mattermost-build commented Aug 9, 2023

Willyfrog commented Aug 21, 2023

ctlaltdieliet commented Aug 21, 2023 • edited

ctlaltdieliet commented Sep 14, 2023

ctlaltdieliet commented Sep 28, 2023

ctlaltdieliet commented Oct 5, 2023

ctlaltdieliet commented Oct 5, 2023

ctlaltdieliet commented Oct 10, 2023

mattermost-build commented Oct 12, 2023

lieut-data commented Oct 12, 2023

lieut-data commented Oct 12, 2023

ctlaltdieliet commented Oct 13, 2023

lieut-data commented Oct 13, 2023

lieut-data commented Oct 13, 2023

mattermost-build commented Oct 13, 2023

lindalumitchell left a comment

Choose a reason for hiding this comment

lieut-data commented Oct 17, 2023

mm-cloud-bot commented Oct 17, 2023

ctlaltdieliet commented Jul 20, 2023 •

edited

ctlaltdieliet commented Aug 21, 2023 •

edited