Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding Vietnamese language as beta #2872

Merged
merged 1 commit into from Oct 17, 2023
Merged

adding Vietnamese language as beta #2872

merged 1 commit into from Oct 17, 2023

Conversation

ctlaltdieliet
Copy link
Collaborator

@ctlaltdieliet ctlaltdieliet commented Oct 5, 2023 •
edited

Summary

Adding Vietnamese as beta

Ticket Link

Related to mattermost/mattermost#24074 and mattermost/mattermost-mobile#7462

Checklist

Release Note

Adding Vietnamese as a beta language

@mattermost-build
Copy link
Contributor

Hello @ctlaltdieliet,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

This was referenced Oct 5, 2023
Merged
Merged
devinbinnie
devinbinnie approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@devinbinnie devinbinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

cwarnermm
cwarnermm approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ctlaltdieliet! YAY for a new beta language!!

@cwarnermm cwarnermm added 4: Reviews Complete All reviewers have approved the pull request and removed Lifecycle/1:stale labels Oct 16, 2023
@ctlaltdieliet
Copy link
Collaborator Author

This PR can be merged as mattermost/mattermost#24074 and mattermost/mattermost-mobile#7462 are merged as well
We have a new supported language 💙 🎉

@devinbinnie devinbinnie merged commit 10a2a14 into master Oct 17, 2023
16 checks passed
@devinbinnie devinbinnie deleted the i18n-adding-vi branch October 17, 2023 14:17
@amyblais amyblais added this to the v5.6.0 milestone Oct 17, 2023
@cwarnermm cwarnermm mentioned this pull request Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinbinnie devinbinnie devinbinnie approved these changes

@cwarnermm cwarnermm cwarnermm approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Contributor Docs/Done Hacktoberfest null release-note
Projects
None yet
Milestone
v5.6.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ctlaltdieliet @mattermost-build @devinbinnie @cwarnermm @amyblais @mm-cloud-bot