-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-58341] db/migrations: mysql-8.4 fix for 000027_create_status #27080
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MySQL is dead. Long live MySQL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this fixes the migration, we also need to make the same change wherever we're querying this column in SQL store. For example, running this branch generates this error on opening webapp when the server tries to update user's status-
{
"timestamp": "2024-05-23 09:04:18.344 +05:30",
"level": "warn",
"msg": "Failed to save status",
"caller": "platform/status.go:288",
"user_id": "ctgbai6zc3fyupk6zpynzdrsme",
"error": "failed to upsert Status: Error 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'Manual,LastActivityAt,DNDEndTime,PrevStatus) VALUES (?,?,?,?,?,?) ON DUPLICATE K' at line 1"
}
So, we need to handle this in other places as well.
Ah nice catch Harshil |
|
/update-branch |
Summary
MySQL v8.4 introduces a new reserved work for
Manual
hence it was causing errors during creating the newStatus
table. This issue was affecting new installations using mysql-8.4.Ticket Link
https://mattermost.atlassian.net/browse/MM-58341
Release Note