Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-58274] No side padding in plugins section of user profile popover #27084

Merged
merged 3 commits into from
May 24, 2024
Merged

[MM-58274] No side padding in plugins section of user profile popover #27084

merged 3 commits into from
May 24, 2024

Conversation

M-ZubairAhmed
Copy link
Member

@M-ZubairAhmed M-ZubairAhmed commented May 21, 2024 •
edited
Loading

Summary

Ticket Link

https://mattermost.atlassian.net/browse/MM-58274

Screenshots

Release Note

NONE

@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 21, 2024
@M-ZubairAhmed M-ZubairAhmed added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels May 21, 2024
@unified-ci-app
Copy link
Contributor

Not triggering E2E tests: this PR has 9 commit status(es) or check-runs that are not passing. Ensure all statuses aside from the E2E testing ones are green, before triggering E2E tests.

@M-ZubairAhmed M-ZubairAhmed added the Setup Cloud Test Server Setup an on-prem test server label May 21, 2024
@amyblais amyblais added this to the v9.10.0 milestone May 21, 2024
harshilsharma63
harshilsharma63 approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@harshilsharma63 harshilsharma63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yasserfaraazkhan
Copy link
Contributor

/e2e-tests

@unified-ci-app
Copy link
Contributor

E2E test triggered successfully for PR #27084. The corresponding commit's status check will be available shortly.

@github-actions GitHub Actions
Copy link

E2E test run is starting for commit 6e302a49e6f9d874bea37efe1020ef7b0876b44f.
You can check its progress by either:

@M-ZubairAhmed M-ZubairAhmed removed the 2: Dev Review Requires review by a developer label May 23, 2024
yasserfaraazkhan
yasserfaraazkhan approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for adding GitHub plugin for testing

@M-ZubairAhmed M-ZubairAhmed added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review Setup Cloud Test Server Setup an on-prem test server labels May 24, 2024
@mm-cloud-bot
Copy link

Test server destroyed

@M-ZubairAhmed M-ZubairAhmed merged commit 09c0eb7 into master May 24, 2024
25 checks passed
@M-ZubairAhmed M-ZubairAhmed deleted the MM-58274 branch May 24, 2024 12:04
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasserfaraazkhan yasserfaraazkhan yasserfaraazkhan approved these changes

@harshilsharma63 harshilsharma63 harshilsharma63 approved these changes

@devinbinnie devinbinnie devinbinnie approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
v9.10.0
Development

Successfully merging this pull request may close these issues.
6 participants
@M-ZubairAhmed @yasserfaraazkhan @mm-cloud-bot @harshilsharma63 @devinbinnie @amyblais