Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Duplicate command make-private in channel #575

Closed
ChandanChainani opened this issue Oct 12, 2022 · 2 comments · Fixed by #605
Closed

Duplicate command make-private in channel #575

ChandanChainani opened this issue Oct 12, 2022 · 2 comments · Fixed by #605

Comments

@ChandanChainani
Copy link
Contributor

ChandanChainani commented Oct 12, 2022 •
edited
Loading

The same functionality is available through modify command which allow us to make channel private or public

I would love to work on the issue
@isacikgoz
Copy link
Member

Great point @ChandanChainani This is actually right. The reason why we kept both is to maintain backwards compatibility. Having said that, since you'd like to work on this. Would you mind adding a deprecation flag to the command? You should add https://pkg.go.dev/github.com/spf13/cobra#Command Deprecated string to the command.

ChandanChainani added a commit to ChandanChainani/mmctl that referenced this issue Nov 3, 2022
@ChandanChainani
Added Deprecated warning in channel make-private cmd mattermost#575
97faba2
@ChandanChainani ChandanChainani mentioned this issue Nov 3, 2022
Merged
@ChandanChainani
Copy link
Contributor Author

@isacikgoz I have raised PR with suggested changes please review

isacikgoz pushed a commit that referenced this issue Nov 4, 2022
@ChandanChainani
[GH-575] Added Deprecated warning in channel make-private cmd (#605)
6c005c9
ChandanChainani added a commit to ChandanChainani/mmctl that referenced this issue Nov 4, 2022
@ChandanChainani
Updated docs as per channel make-private cmd changes mattermost#575
ad742d8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[GH-575] Added Deprecated warning in channel make-private cmd ChandanChainani/mmctl
2 participants
@isacikgoz @ChandanChainani