Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

[GH-575] Added Deprecated warning in channel make-private cmd #605

Conversation

ChandanChainani
Copy link
Contributor

Fixes #575

@mattermod
Copy link
Contributor

Hello @ChandanChainani,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@ChandanChainani
Copy link
Contributor Author

/check-cla

@isacikgoz
Copy link
Member

Hey @ChandanChainani you need to run make docks to generate newly added documentation to the commands. That will fix the CI issue.

@isacikgoz isacikgoz self-requested a review November 4, 2022 07:04
Copy link
Member

@isacikgoz isacikgoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ChandanChainani awesome!

@isacikgoz isacikgoz merged commit 6c005c9 into mattermost:master Nov 4, 2022
@isacikgoz isacikgoz added the 4: Reviews Complete All reviewers have approved the pull request label Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate command make-private in channel
3 participants