Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

commands/permissions and commands/permissions_role: add some e2e tests (batch 3) #339

Merged
merged 3 commits into from
Apr 6, 2021
Merged

commands/permissions and commands/permissions_role: add some e2e tests (batch 3) #339

merged 3 commits into from
Apr 6, 2021

Conversation

isacikgoz
Copy link
Member

@isacikgoz isacikgoz added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Mar 16, 2021
mgdelacroix
mgdelacroix reviewed Mar 24, 2021
View reviewed changes
Copy link
Member

@mgdelacroix mgdelacroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good! Only one question about test isolation

commands/system_e2e_test.go Outdated
func (s *MmctlE2ETestSuite) TestClearBusyCmd() {
s.SetupEnterpriseTestHelper().InitBasic()

s.th.App.Srv().Busy.Set(time.Minute)
Copy link
Member

@mgdelacroix mgdelacroix Mar 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hum... here I'm leaning more towards enabling this and making sure that it gets disabled with a defer at the beginning of each test case, to avoid the state to pollute from a test case to the next (as it happens here, as the second TC expects the server to be busy and leaves it busy for a minute).

What do you think about refactoring this so each test case is completely isolated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes sense! Will update accordingly 👍

@isacikgoz isacikgoz requested a review from lindy65 March 29, 2021 12:55
lindy65
lindy65 approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @isacikgoz - these commands will be tested after merge 👍

Please help add Zephyr (TM4J) test codes to s.Run lines:

image

@lindy65 lindy65 requested a review from mgdelacroix April 5, 2021 09:21
@lindy65 lindy65 added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Apr 5, 2021
@isacikgoz isacikgoz merged commit 05218a3 into enable_enterprise Apr 6, 2021
@isacikgoz isacikgoz deleted the ee_e2e_batch_3 branch April 6, 2021 11:06
mgdelacroix pushed a commit that referenced this pull request Sep 23, 2021
@isacikgoz @metanerd
Enable ee build for e2e tests (#310)
f3f42cf 
* enable ee build for e2e tests

* update server dependency

* commands/permissions and commands/permissions_role: add some e2e tests (batch 3) (#339)

* commands/permissions: add some e2e tests

* clear busy status

* add test codes

* commands/license and commands/ststem: add some e2e tests (batch 4) (#340)

* commands/license and commands/ststem: add some e2e tests

* remove system_e2e_test.go

* add test codes

* add system

* commands/group, commands/ldap: add e2e tests batch 1 (#337)

* commands/group, commands/ldap: add e2e tests batch 1

* reflect revivew comments

* commands/group: add e2e tests batch 2 (#338)

* commands/group: add e2e tests batch 2

* reflect review comments

* add TM4J test codes

* add test codes

* update v6

* mod vendor

* update server dependencies

* add ci files (similar to server)

* renanme step

* fix cp path

* fix db driver constant

* Enable ee tests (#395)

* Fix GitLab side

* Update .gitlab-ci.yml

Co-authored-by: Elisabeth Kulzer <elikul@elikul.de>

Co-authored-by: Elisabeth Kulzer <elikul@elikul.de>
cpanato pushed a commit that referenced this pull request Nov 24, 2021
@isacikgoz @metanerd @cpanato
Enable ee build for e2e tests (#310)
eccff51 
* enable ee build for e2e tests

* update server dependency

* commands/permissions and commands/permissions_role: add some e2e tests (batch 3) (#339)

* commands/permissions: add some e2e tests

* clear busy status

* add test codes

* commands/license and commands/ststem: add some e2e tests (batch 4) (#340)

* commands/license and commands/ststem: add some e2e tests

* remove system_e2e_test.go

* add test codes

* add system

* commands/group, commands/ldap: add e2e tests batch 1 (#337)

* commands/group, commands/ldap: add e2e tests batch 1

* reflect revivew comments

* commands/group: add e2e tests batch 2 (#338)

* commands/group: add e2e tests batch 2

* reflect review comments

* add TM4J test codes

* add test codes

* update v6

* mod vendor

* update server dependencies

* add ci files (similar to server)

* renanme step

* fix cp path

* fix db driver constant

* Enable ee tests (#395)

* Fix GitLab side

* Update .gitlab-ci.yml

Co-authored-by: Elisabeth Kulzer <elikul@elikul.de>

Co-authored-by: Elisabeth Kulzer <elikul@elikul.de>
cpanato pushed a commit that referenced this pull request Nov 24, 2021
@isacikgoz @mgdelacroix
@streamer45 @metanerd
several cherry picks that is needed for the release-6.0 branch (#409)
f1272d9 
* [MM-38097] Update client (#385)

* update deps

* add human package

* fix typo

* unskip log tests

* mmctl plugin add: introduce optional 'force' flag to allow existing plugins to be replaced (#390)

* mmctl plugin add: introduce default-replace 'force' flag

This allows users to add a plugin with add-and-replace-if-exists semantics when using the `mmctl plugin add`, by specifying the `--force` flag.

This is implemented by calling the `client.UploadPluginForced` function.

* Update documentation

* Add end-to-end test (test-e2e) coverage for plugin addition in the presence of an existing copy of the plugin

* lint fixup: remove unnecessary use of fmt.Sprintf

* Remove redundant error string assertion

* Clear contents of output printer between repeated 'plugin add' actions

* Add output message check for successful forced plugin replacement via 'plugin add'

* printer: add pager option (#377)

* printer: add pager option

* add pager flag

* Apply suggestions from code review

Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>

* add print warning function

* Apply suggestions from code review

Co-authored-by: Claudio Costa <cstcld91@gmail.com>

* reflect review comments

* remove progress indicator

Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>
Co-authored-by: Claudio Costa <cstcld91@gmail.com>

* fix a merge error (#396)

* Enable ee build for e2e tests (#310)

* enable ee build for e2e tests

* update server dependency

* commands/permissions and commands/permissions_role: add some e2e tests (batch 3) (#339)

* commands/permissions: add some e2e tests

* clear busy status

* add test codes

* commands/license and commands/ststem: add some e2e tests (batch 4) (#340)

* commands/license and commands/ststem: add some e2e tests

* remove system_e2e_test.go

* add test codes

* add system

* commands/group, commands/ldap: add e2e tests batch 1 (#337)

* commands/group, commands/ldap: add e2e tests batch 1

* reflect revivew comments

* commands/group: add e2e tests batch 2 (#338)

* commands/group: add e2e tests batch 2

* reflect review comments

* add TM4J test codes

* add test codes

* update v6

* mod vendor

* update server dependencies

* add ci files (similar to server)

* renanme step

* fix cp path

* fix db driver constant

* Enable ee tests (#395)

* Fix GitLab side

* Update .gitlab-ci.yml

Co-authored-by: Elisabeth Kulzer <elikul@elikul.de>

Co-authored-by: Elisabeth Kulzer <elikul@elikul.de>

* commands/user: add migrate auth e2e tests (#341)

* add arm64 targets and update mm deps to 6.0.2 (#402)

* add arm64 targets and update mm deps to 6.0.2

* add vendor

* refactor lint job

* update deprecated lint

* fix lints

Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>
Co-authored-by: James Addison <james.addison@collabora.com>
Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>
Co-authored-by: Claudio Costa <cstcld91@gmail.com>
Co-authored-by: Elisabeth Kulzer <elikul@elikul.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkraft mkraft mkraft approved these changes

@lindy65 lindy65 lindy65 approved these changes

@mgdelacroix mgdelacroix Awaiting requested review from mgdelacroix

Assignees
No one assigned
Labels
2: Dev Review Requires review by a core committer QA Review Done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@isacikgoz @mgdelacroix @mkraft @lindy65