This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
commands/group, commands/ldap: add e2e tests batch 1 #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isacikgoz
added
2: Dev Review
mgdelacroix
approved these changes
Mar 24, 2021
| printer.Clean() | ||
|
|
||
| // we rely on the test data generated for the openldap server | ||
| // i.e. "test-data.ldif" script |
There was a problem hiding this comment.
thanks for making this explicit!
commands/ldap_e2e_test.go
Outdated
| jobs, appErr = s.th.App.GetJobsByTypePage(model.JOB_TYPE_LDAP_SYNC, 0, 100) | ||
| s.Require().Nil(appErr) | ||
| s.Require().NotEmpty(jobs) | ||
| s.Assert().Greater(len(jobs), initialNumJobs) |
There was a problem hiding this comment.
does it make sense to be more precise and test for len(jobs) + 1?
mkraft
approved these changes
Mar 29, 2021
* commands/group: add e2e tests batch 2 * reflect review comments * add TM4J test codes
Codecov Report
@@ Coverage Diff @@
## enable_enterprise #337 +/- ##
==================================================
Coverage 73.34% 73.34%
==================================================
Files 38 38
Lines 3204 3204
==================================================
Hits 2350 2350
Misses 710 710
Partials 144 144 Continue to review full report at Codecov.
|
lindy65
approved these changes
Apr 5, 2021
There was a problem hiding this comment.
Thanks @isacikgoz - these commands will be tested after merge 👍
Please help add Zephyr test codes to s.Run lines:
lindy65
added
4: Reviews Complete
mgdelacroix
pushed a commit
that referenced
this pull request
Sep 23, 2021
* enable ee build for e2e tests * update server dependency * commands/permissions and commands/permissions_role: add some e2e tests (batch 3) (#339) * commands/permissions: add some e2e tests * clear busy status * add test codes * commands/license and commands/ststem: add some e2e tests (batch 4) (#340) * commands/license and commands/ststem: add some e2e tests * remove system_e2e_test.go * add test codes * add system * commands/group, commands/ldap: add e2e tests batch 1 (#337) * commands/group, commands/ldap: add e2e tests batch 1 * reflect revivew comments * commands/group: add e2e tests batch 2 (#338) * commands/group: add e2e tests batch 2 * reflect review comments * add TM4J test codes * add test codes * update v6 * mod vendor * update server dependencies * add ci files (similar to server) * renanme step * fix cp path * fix db driver constant * Enable ee tests (#395) * Fix GitLab side * Update .gitlab-ci.yml Co-authored-by: Elisabeth Kulzer <elikul@elikul.de> Co-authored-by: Elisabeth Kulzer <elikul@elikul.de>
cpanato
pushed a commit
that referenced
this pull request
Nov 24, 2021
* enable ee build for e2e tests * update server dependency * commands/permissions and commands/permissions_role: add some e2e tests (batch 3) (#339) * commands/permissions: add some e2e tests * clear busy status * add test codes * commands/license and commands/ststem: add some e2e tests (batch 4) (#340) * commands/license and commands/ststem: add some e2e tests * remove system_e2e_test.go * add test codes * add system * commands/group, commands/ldap: add e2e tests batch 1 (#337) * commands/group, commands/ldap: add e2e tests batch 1 * reflect revivew comments * commands/group: add e2e tests batch 2 (#338) * commands/group: add e2e tests batch 2 * reflect review comments * add TM4J test codes * add test codes * update v6 * mod vendor * update server dependencies * add ci files (similar to server) * renanme step * fix cp path * fix db driver constant * Enable ee tests (#395) * Fix GitLab side * Update .gitlab-ci.yml Co-authored-by: Elisabeth Kulzer <elikul@elikul.de> Co-authored-by: Elisabeth Kulzer <elikul@elikul.de>
cpanato
pushed a commit
that referenced
this pull request
Nov 24, 2021
* [MM-38097] Update client (#385) * update deps * add human package * fix typo * unskip log tests * mmctl plugin add: introduce optional 'force' flag to allow existing plugins to be replaced (#390) * mmctl plugin add: introduce default-replace 'force' flag This allows users to add a plugin with add-and-replace-if-exists semantics when using the `mmctl plugin add`, by specifying the `--force` flag. This is implemented by calling the `client.UploadPluginForced` function. * Update documentation * Add end-to-end test (test-e2e) coverage for plugin addition in the presence of an existing copy of the plugin * lint fixup: remove unnecessary use of fmt.Sprintf * Remove redundant error string assertion * Clear contents of output printer between repeated 'plugin add' actions * Add output message check for successful forced plugin replacement via 'plugin add' * printer: add pager option (#377) * printer: add pager option * add pager flag * Apply suggestions from code review Co-authored-by: Miguel de la Cruz <miguel@mcrx.me> * add print warning function * Apply suggestions from code review Co-authored-by: Claudio Costa <cstcld91@gmail.com> * reflect review comments * remove progress indicator Co-authored-by: Miguel de la Cruz <miguel@mcrx.me> Co-authored-by: Claudio Costa <cstcld91@gmail.com> * fix a merge error (#396) * Enable ee build for e2e tests (#310) * enable ee build for e2e tests * update server dependency * commands/permissions and commands/permissions_role: add some e2e tests (batch 3) (#339) * commands/permissions: add some e2e tests * clear busy status * add test codes * commands/license and commands/ststem: add some e2e tests (batch 4) (#340) * commands/license and commands/ststem: add some e2e tests * remove system_e2e_test.go * add test codes * add system * commands/group, commands/ldap: add e2e tests batch 1 (#337) * commands/group, commands/ldap: add e2e tests batch 1 * reflect revivew comments * commands/group: add e2e tests batch 2 (#338) * commands/group: add e2e tests batch 2 * reflect review comments * add TM4J test codes * add test codes * update v6 * mod vendor * update server dependencies * add ci files (similar to server) * renanme step * fix cp path * fix db driver constant * Enable ee tests (#395) * Fix GitLab side * Update .gitlab-ci.yml Co-authored-by: Elisabeth Kulzer <elikul@elikul.de> Co-authored-by: Elisabeth Kulzer <elikul@elikul.de> * commands/user: add migrate auth e2e tests (#341) * add arm64 targets and update mm deps to 6.0.2 (#402) * add arm64 targets and update mm deps to 6.0.2 * add vendor * refactor lint job * update deprecated lint * fix lints Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com> Co-authored-by: James Addison <james.addison@collabora.com> Co-authored-by: Miguel de la Cruz <miguel@mcrx.me> Co-authored-by: Claudio Costa <cstcld91@gmail.com> Co-authored-by: Elisabeth Kulzer <elikul@elikul.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add e2e tests for:
listLdapGroupsCmdFchannelGroupStatusCmdFchannelGroupListCmdFldapSyncCmdFldapIDMigrateCmdFTicket Link
PS: will change base to
masteronce we merge #310, alternatively we can merge toenable_enterprisebranch.